From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFAE73C2772 for ; Thu, 4 Jun 2026 08:00:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780560003; cv=none; b=FmqWa/nXT/sYE6TyBP8s8Xm9Gf5fGN4zl/5jQ3XVW5qhsJRWZgjepUon3df5E4nCURYyE1BxfamoDrXvni1jugdE+Ewq0Ld9L8YKUB/8pAH8cXd07wU3ayonRKjlNbxnAxA64M/qFJy4iiBjrDcym00MV1mcbm1RMt82nCPsrIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780560003; c=relaxed/simple; bh=pyvpBySNof2P4AFNtUMMRUcnYxBjiroFzOjK7/u5M7k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oDM+w8OzSJF4yC3GQui/gPCsEg2ZooUBwf9RgWk3T+0PDbDw00OO0tTFMeKGx6PDQUtqlX7zBsDH4mAMnclUslhoCIKxPeI/pzmyT0zItayjEml48hEGEwADQ1CpD2DPEBMmxjjySculI6z45dZBex/O5ZHzQ1JbtxdPJow0nrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nnn+/6S3; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nnn+/6S3" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-9158c621ebbso57455085a.2 for ; Thu, 04 Jun 2026 01:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780560002; x=1781164802; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oygxAdSSs192vre1eZBfC4ed2lZJxHGD3rZsgt76Mtc=; b=Nnn+/6S3EtbuX4otSHLmEmpYoSlUFDcpiao4eaif6YfAcHtlSXOvLkx9jveChiFKA4 VHXScCYDST7yC6ep0o6fUNEmjljPNxgD/hK7bLG9wLk5S6prD1L14BtrklXMqepqFsHK D0cgPvrfy9uRzfxiafhTJlCcBIZMzqNDTlniKrr+PIOgWw85vnwvBKXC5nM2t4cl3+0+ 3240cg7PLm8VlhF0HTzcqizveUdHpdMkVjj7hXbXoEaTAGC6pdJwbAv4CVwzqtB2oB9o s5dKSLMolMhd/GZQYED3dGR7WJcucAbuincLaTxHozn8IetLpkrF98V1ee7QxUsyTkZf n6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780560002; x=1781164802; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oygxAdSSs192vre1eZBfC4ed2lZJxHGD3rZsgt76Mtc=; b=MQ1UQebhCO757fkdJSkoi8/O0JNCKK5lkpIXs7A4rThNd57yi8/H7XJKQhLyQ5v8Dy jZXrTnfLnruywsXuIgQY4AZ18idGGkBwvU60Ry2jzGXvuiyXk3a8xenqfrTiDZ1uTFdL gNCQhYg0TdCnw+jNlLdw8Kg172OEzHAJ0LVRDcIYEw7aG7mPGkmQtMcfPzP4FBqsLeQg vi8XRl3bk901UycZ10pv042IJgTfntwuvD5kTguz+blZ6HGzPWxUb6IVs5S9LH0Vg1TZ +noF6ZfmxfxAYKY+WAOAPa/Q4+Lojg9wROs8f4RdfUR6rCALHW9BzQHev/ZMHIhEjdjq yKTw== X-Forwarded-Encrypted: i=1; AFNElJ9qb1TdJ3S1aJXUITtL5gLCBFyfd1Sf7lw68VB4NSbubagtAoZ6CZD7jDNAhc9wJm/7ECJ2DMQZ4oC7Mr0=@vger.kernel.org X-Gm-Message-State: AOJu0YyqmPeOqsEPuD8ztzdww/k8T7l8SmF1feTBJm8ZN7FHQ+/wkKIJ mEWn9i9xBDQeE+tkznhxHvA1YXJ8XIi/92skCwYYMURJicODjA5WbWsU X-Gm-Gg: Acq92OEVpfdKB410cYU57IXg4R0RDTAbs/MRQsLrCMP7xjAMgTVxsprb46gbwPS8d+T RntCla6GfMUIiE7tTuJFri7Xi9rCGn7OoSlrTc6f03X7IQdKx+EW1nudPzZEqE2hDaVYqohCtP3 5QXxIW1xuBt4w+py7W7JYSpB4hdrqHQfMuvHG/VYmh2mld07C/1GAVGNnD+0+1G5YA509yzXJvt SLzbooDG4kelRb5FfWHFDO35bcb96WdK6J455YbRHmLuTUZskYzdwF6MdTVUyzePZxp1V5kNUkE uZsb9GO7SPiTFdf+yn15LDBm37RRzzSesVOPaO1qYb8zK/yj9Q0ZzAYjgg2TvEp5f9htavqHIqZ uAFih78/8rNOuffgV8KL3BGgtjixAB5ktXAJvbu2jeC/UnF43FnAyP3Gd47OdVMnP+fP1P9JTXV 02p7txO3iQw/DUnj1Hb6qWlUagSIE= X-Received: by 2002:a05:620a:f05:b0:915:9aa5:b5c6 with SMTP id af79cd13be357-9159aa5b72fmr470049585a.36.1780560001697; Thu, 04 Jun 2026 01:00:01 -0700 (PDT) Received: from localhost ([149.40.50.195]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cecd077be8sm45590716d6.40.2026.06.04.00.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 01:00:00 -0700 (PDT) Date: Thu, 4 Jun 2026 10:59:55 +0300 From: Dan Carpenter To: William Elder Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: remove comparisons to boolean literals Message-ID: References: <20260603195239.200775-1-williamxelder@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260603195239.200775-1-williamxelder@gmail.com> On Wed, Jun 03, 2026 at 01:52:39PM -0600, William Elder wrote: > Remove comparisons to true and false as they are error prone. > Use the idiomatic C forms instead > v2: Fix inverted logic for ht_option checks Nope. Still buggy. Please wait a day between resends. There are other issues with this patch. It needs to be split up. v2 rules etc. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter