From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 630452F8E80 for ; Thu, 4 Jun 2026 13:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780578732; cv=none; b=JpTPrtjAdSZU4t6SF1GXSa2kaMZMxGvjEqpdAmlzE+nZCFlkZx1mRpjWHPNh5rSKsXWAGLAgHm7Ba+pU9BHit3NAcQsnXhZeNC7DE5rd73//eX+sbgtZqqxYXRYvlG6yY56jJZmiUSLKRBA9Tle1GKOxQcw0ygKfABvZY2VvbuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780578732; c=relaxed/simple; bh=OBm1VVRLV9hTK6acHhaWSaLn8uBTeuKKPYlhF6rnx/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E/6OEKSjPz43kCxVgmJq899gib/YVLRRx7fGwKtQ7qi3YFs0jgAPujkwYLF+8yg3+SQNoEWLYHmTMcP6iAliQSBt0TrTgcGb4VUmQmBa99BuKxhcbCsu7hRNMkVXSKs71jZWzwxc6SGJH4/uq8qLSMmZ68hIhCPOlB9jzSeVt5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QlwGeDI+; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QlwGeDI+" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4903d730b1fso7776495e9.2 for ; Thu, 04 Jun 2026 06:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1780578730; x=1781183530; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PeztH7p5NnQQR0rqBoGB3AILnqpwzKey0VzI8U/0hC0=; b=QlwGeDI+vQBttrkUv4bB8A3QG6OeQkMqL8NOlGSO3/vB0mS5OVBTpIdv9xy95jEt4A JqRpzjN6TKjSKxgVOtDMfvRYKJcRzDohCPiW4udtZAz4lYFc4v+hdjTSsXnnV9zbuYsK sFa4KQuhmRuZXDFCaf21UbFwHoZRmCZQoRji/99A5YFs3eg8hxN23eP4whgkY5i0agQt l0u+5i8a6ZIbvtlHlk8FJcoW26AJRCJGvujr6sAJAsfgzLTu3k8c92HKJVad6TRCrU2C jqWWXD/MWMOk208FIOZXj8/mGJ/QvRqq8gvHZbjpmIu0pKXQFAb8JT5wKStQDPkPPd4b edzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780578730; x=1781183530; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PeztH7p5NnQQR0rqBoGB3AILnqpwzKey0VzI8U/0hC0=; b=AV/37YlNKncvCykIYfKYFNjBbnJ56rpP984L4oK68yu4v31lDmQXT9wAW3U2/qrFo/ ygoaaHp6w147UjAr/NFNISjVQGeJgJZrv5wy/cGW28FYGQ/Ekb0/zP9zUEN5gAZLFIHJ 6+cv+6F7Lz4nsDpfP0L3dtq3rGX4JpdhpiTo1ahwGyeG45tEizLRd9zxNOjjHjEaHcmD 9TT24PmS/CCnq2WC3CPwfeVCcL5+bH0p2gOzd9jD7yqIwQND9LMoJKLEUn8pLRy7DoV7 SC89l2jY1EH2Q1dTNBXrHjDhjEav6jTnbTqUuBjC+4vsJ5ktTjkyVQC74hh5A+BjwqP8 rICw== X-Forwarded-Encrypted: i=1; AFNElJ+m1/95TSYfGpIdfkH8Twpm19vJnqzOOA+CFYo/E8rWIH3k5riwnVMiRZDm0a6gyanptaixcolWZNs/ydM=@vger.kernel.org X-Gm-Message-State: AOJu0YymhX2yRi9eiqYQ9Wr1YrK36uXq/mNAAlNXd/+sN7WoxAAe0Lcc sotKybqWpVAp2wgU+jKYD3kqqVSfsz2O8/BIw/sK1SgEEieGG/ogeE6YyiD4brUw6Do= X-Gm-Gg: Acq92OEePxfGtaE+/ZuNop6GODg9W/tzl7OrK7WGwdaWfpc81l9BYghUkFm50NZwpjx YJ/UPguv9TgAbvZlZFtH+PqT4Fqnitoh4EFANsnOnnVB7AF2Zc+43iLMZOejeeV9IWMpY1Kax8T CWAr+Hgak8ILZW5gqx3aA9c4qUBF50Npu1f7O5uKTOlaeyUWUNQ3Wuh/89Vd/OWG416teFi6/2p EL7KcxyYSI6c9uDAymWRGn/4UCAiTE72WGXyWci2PJ19qgZSlMIpm08lEvQRteQS0F9Sk4Qk3l/ 2SQMp0bmDywYT4pLJQ1s5/vT06x6q67kPhUteTcrBFLFasF/gtySa2xj7T5mBK+Wz5SzRCYmZIN mKBgGu2/7kKJjmlSe0peBL2LCvcfvusoIznK0aNv5CFgjSTPOQ6zmz8aWAfflhnsDqaZ2k13mXj qv3HnyX4pip6mNDaG985rlgyPlh8jGvv4wGS5b X-Received: by 2002:a05:600c:46ce:b0:490:b4e5:ce7e with SMTP id 5b1f17b1804b1-490b5edcbe3mr118541755e9.25.1780578729826; Thu, 04 Jun 2026 06:12:09 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc413adbsm72658335e9.15.2026.06.04.06.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 06:12:09 -0700 (PDT) Date: Thu, 4 Jun 2026 15:12:07 +0200 From: Petr Mladek To: Rui Qi Cc: mbenes@suse.cz, jpoimboe@kernel.org, jikos@kernel.org, joe.lawrence@redhat.com, shuah@kernel.org, live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests/livepatch: fix resource leak in test_klp_syscall init error path Message-ID: References: <20260602124509.365996-1-qirui.001@bytedance.com> <20260604083208.1071428-1-qirui.001@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260604083208.1071428-1-qirui.001@bytedance.com> On Thu 2026-06-04 16:32:08, Rui Qi wrote: > In livepatch_init(), if klp_enable_patch() fails, the previously > created kobject and sysfs file are never cleaned up, causing a > resource leak. Capture the return value and add proper cleanup > on the error path. > > Signed-off-by: Rui Qi The patch looks good to me. I would ignore the proble reported by Sashiko. so: Reviewed-by: Petr Mladek Best Regards, Petr PS: I am going to push this patch early next week if nobody complained in the meantime.