From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A3C4014A8 for ; Thu, 4 Jun 2026 10:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780569587; cv=none; b=OE/g/fhQw7ttkZEQRzU/viKXDKH7D9RWtOdkXQp9JB1kcLdTlm4rjjaIDO3ThypT/6hjfwSzn/qvm93a2zGM61Z6u6lzJ5ZI5kZfmmCPczYGmXQsYJJr69A4YA7jjlZp1INAIoqSbyaJkmdSBCJvZI7vJhUNqqb+IjeHRqd8n78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780569587; c=relaxed/simple; bh=2Vh56h57Z0T91eA8r4mMnsXiuc3McXuOqM+28axWqVI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bR0PCxXu7fBNQw4dSc5wYaKJgb4Zu9St9fWcSgC3vHZkhuWRoBMtOad3ByCpKM0TlQAEplgfM46jMEtBeJLrLL4OQevzFLqcGo3xqFyai9uR1u387KDlieouUp24lwRYPhhO2DPJR7Fe+nGQ+krYPin8ohrCNs2hKZk8Fus7mbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=V+ilH8ko; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VpZCfonc; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V+ilH8ko"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VpZCfonc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780569585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aXLe0Lyqp3ntcJ5AmrAA7vOVVp+FJ2nW9Yvine+7m/M=; b=V+ilH8ko2mmfkyocfAHnaOlVAw1/mSkIh2VFO/C+EMjewjoRx1oTGOW+4aZBGwSP01JHhn zGgpmnHV0bj0jnNIaxkQSqqZgzOyUmOtoTthgx/RbvQY1JKin3It07j5FPtY6X7NzlKcvd GfRmWJ7RM0W9aLytT+11hULYCYUE+6w= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-QIRQfGEvNa2P4xtjA_6BAg-1; Thu, 04 Jun 2026 06:39:44 -0400 X-MC-Unique: QIRQfGEvNa2P4xtjA_6BAg-1 X-Mimecast-MFC-AGG-ID: QIRQfGEvNa2P4xtjA_6BAg_1780569583 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490b9318944so4056995e9.1 for ; Thu, 04 Jun 2026 03:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780569583; x=1781174383; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aXLe0Lyqp3ntcJ5AmrAA7vOVVp+FJ2nW9Yvine+7m/M=; b=VpZCfoncwY1fB4+hinZsrq1WO3odm3ru35Jv7VlxAyuFdxyxlFld4YGU6NZPSYXFMa Fzap4JsczqbEzOhQYFOt4FwyU7GOfEIq01dDkkx6Ia2HDmbpgi5BGRh64vKL3AlI5B2R 3ERL7y6Kmxar3lMR960bDa1NEdW8BJxAihz9Ov/LqChhY9dARMIRtHEFRELkrmp5weTq sU0NKG2t38jLokSJPwGQH/PqPZ4Xfgsd6MNcOHW2VoJRCCyqW6J9+jAXLxy0dAW/8Z8T tyD4AlgEYXi5zkX/dRYKgvzKI2fmRJ8iktitbZNcWxkNtnL4eHNTexK9cYJ3kIL79N+b ZVtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780569583; x=1781174383; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXLe0Lyqp3ntcJ5AmrAA7vOVVp+FJ2nW9Yvine+7m/M=; b=gAVYixvOxEAI5vFa9/kqvbwaeLT780xjYhfO/0slrmOKitMJz/TH1fV1Iq2oNtufA1 O0zfzQk68Uo9mmbIxALmSrzLlBW2ghx0pobFVBKYV2RZwQ4uunLkN9BmaMpc87j3ooxJ dR4eGaC9pK2Vu21mmX6PVo+gh0kY7HxCRpVYDvKBZwGU/9mpAVyADHzw9lDQZgbVBJ3Z XpCpeMcnrYYzEWLaMbNORxsNohMX8FDV1MWwU5/43cnnh0Feeqe+NbqfgNsIrZLv9Cz8 XnWrAsMn7bj8eT9sCgbQmmo5FqRikXyHWEo4Hk654LgTJi8qkn1/Q7ng3CQYs2dkQkpH 4akQ== X-Forwarded-Encrypted: i=1; AFNElJ9NdbnHXmdh0BbOOy0e8XCq6UPqWdg2Ln26NZDWoHRnCTZvTG8tPXlzrtXp6KsUszt1z1hQPT7d3Nnm5e0=@vger.kernel.org X-Gm-Message-State: AOJu0YyaOWkXGj6XuFaEdaHKzo3yp9OxyuNcX+HiOOXyUYuaKLw4hflM 9gcXEyvajh747vug9knguSxB6nw7QIKZ5HYpxHao5CK0i8u0EFtm53SBW/asBjQ7CoOE0e5MLHg KYnbrAbq8rS83m/WroCj/ZNIpmcC7PCNDr3xA2NZzNAWBEyV4oDYxVMd4QzQTB3Cc0jgCQ7Xjpw == X-Gm-Gg: Acq92OH6QLP3ZQLbowaUXP3NnjjiOIbCwK5y4vVch+EgU/05iGUprZ2Uq4O8WSNjsyf XHTevPqLpCNSdwIoZdHLu5PcQgu/LCO4SRh40RXMZMLD/s674x49hGhdR0nAXIL9BjomTgJ5xp9 8fKwM/f9tzYGGiaGvZmY8qi3cvMdeNGR6f3XID+g3SeX5Ozt9gS046UCorsLlOn3Lub5ora4VAO I60A9Z6MXahOKFmQ3IsXzo1LImmQuJm2t7EhSdAyBrDUdsloZz2M1uDKQITQN2xtZ5SdM+bgSmT I17EOEXKaQIbvX83rJDJ0ULsA5eF8jfEHSesqwU6WE4qsqQiQyaDZLEyg8h7fMKHx2hM9vMSj7o PUwuXl8vd4lJ3Vs1CLOIwor2fwfaezxiHMM4A0qk/z7Gyn5m5SMlzORka/nESNTTj5/7HvtrzBn B7YR8qSA== X-Received: by 2002:a05:600c:608d:b0:490:b8c0:d471 with SMTP id 5b1f17b1804b1-490b8c0d5eemr115722295e9.23.1780569582737; Thu, 04 Jun 2026 03:39:42 -0700 (PDT) X-Received: by 2002:a05:600c:608d:b0:490:b8c0:d471 with SMTP id 5b1f17b1804b1-490b8c0d5eemr115721305e9.23.1780569582103; Thu, 04 Jun 2026 03:39:42 -0700 (PDT) Received: from sgarzare-redhat (host-82-53-135-12.retail.telecomitalia.it. [82.53.135.12]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f351d69sm25192327f8f.29.2026.06.04.03.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 03:39:41 -0700 (PDT) Date: Thu, 4 Jun 2026 12:39:35 +0200 From: Stefano Garzarella To: Raf Dickson Cc: pabeni@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, stefanha@redhat.com, bryan-bt.tan@broadcom.com, vishnu.dasa@broadcom.com, bcm-kernel-feedback-list@broadcom.com, stable@vger.kernel.org Subject: Re: [PATCH] vsock/vmci: fix sk_ack_backlog leak on failed handshake Message-ID: References: <97069506-352b-4152-a57b-5a974320529d@redhat.com> <20260601095646.180085-1-rafdog35@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260601095646.180085-1-rafdog35@gmail.com> On Mon, Jun 01, 2026 at 09:56:46AM +0000, Raf Dickson wrote: >On Mon, Jun 1, 2026 at 9:26 AM Paolo Abeni wrote: >> I'm wondering if sk_acceptq_removed() should be bounded in >> vsock_remove_pending() ? (even if that change would probably be >> net-next material). > >Agreed, that would prevent this class of bug entirely. Happy to prepare >a follow-up patch for net-next once this fix lands, if that would be >useful. And maybe sk_acceptq_added() calls moved in vsock_add_pending(). That said I was wondering about other transports, but it seems both virtio and hyperv have a simplier handshake that doesn't require the pending list, since the socket is moved directly in the accept list. BTW if you are going to sent a follow up, maybe another improvement (unrelated so another patch) could be to use sk_acceptq_is_full() instead of `sk->sk_ack_backlog >= sk->sk_max_ack_backlog`. Discovered while comparing vmci with virtio. Thanks, Stefano