From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DAA240FD98 for ; Thu, 4 Jun 2026 11:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780572530; cv=none; b=R1Jedkcgrdje90t5D8d4iHv3XDexczB0M1sg0DSao3dqt7H9pC8RIW27KSFNagxWLPdS4axlM4r6l3JHra+lBsBS21h9i93H+pCtDddyCvAYOAhLs81yrfHKntHxkf6SLgDUJKaKPgu0HOcB84VR0C7IVb564xXSW9roKMZ4wvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780572530; c=relaxed/simple; bh=01YYHSUuwLuWDVbKswkCkl7XEsN7XLTXDUwsACoJPoU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tt31MCZW69jWAGIwAiNbLmrXrKsZUpsDM2OayzJgWZi5PEXwQdtU9Lrs+xDk7C7tqDc1EC2ObS89bxtFXYMV4qPd08cyN7pkCkiHcD+x+yJbk2PfTtdSf8EBDO5M/vDxAgwccQwrT2e4XYFqoYFj4j64OQCYhgaCicP0xPKOAlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NBkelSar; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hCoBT561; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NBkelSar"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hCoBT561" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6546uxU92477970 for ; Thu, 4 Jun 2026 11:28:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=LKnE3tc1RlkqqMOtABkKWPKA xR6YYffnuCDYRPtMBwM=; b=NBkelSarYTR2VYSxH8oE1QMBbNGlnftrTasO6eUK DHBshzwHZfov+rpmJq4C9dIUdzuIatepAx1hFz3JPHESS41Cn2aLvQggmGCh/ADe bhnC0i3+wronf1K29Jj0vqFCKL4seGtcYBrqk7/r7duPYIA7BRFHw+efqGPn56qh wWirqA8M6EdBQ3fACZayazdE9LqDOSvQxHvYeCmRjbg+zGCQFYzxfhyLplcjsNLK 5aeUtlVyz1ey3D4rD8NXXjbbTo0cYtRNpWXgeWlSXhqemznjwvn+WussJiJ5lgQf i/KgBRBxusu226OLWW5uhiO15wzk3TiTSlboVm4K5linuw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ek4hvh0kp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Jun 2026 11:28:47 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c85a2f1d1e5so379086a12.3 for ; Thu, 04 Jun 2026 04:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780572527; x=1781177327; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LKnE3tc1RlkqqMOtABkKWPKAxR6YYffnuCDYRPtMBwM=; b=hCoBT561IykoLr+KPuTXzC5dhj4fb+4rrBUDk53h58nYY67KYC2HaBtOnE6TNdxYiq Qzt94Omxo8/3z7ApY62e2aV+vsjywdWz1Q0b0J86VwHs22mRwI570Y3ByvrbLkS4cL4m xBr8S0obcgrhmQ6DoCnQ1qL5gPz8JoPcLw2Z6HMUnjaCPak7CmYg8IHKAO84D0xWHdI+ LZzgL7smrOM8faLHFvDZTosEEprST9mpZn+fGKpyuDW47oxGU/Cx2Rzat8RHDFFyBhRB ljHzibS09pNSyx6SPHGEqB3u6UvuIAM4RblIzaX/qwNfuUs9Kt1xP3aWx6GEM9Uy11vC ++eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780572527; x=1781177327; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LKnE3tc1RlkqqMOtABkKWPKAxR6YYffnuCDYRPtMBwM=; b=N12kkGJMoso5omnwSJ8bzLJP3ZXNcZOk1A8ENj4He0H9KOwlChfGTt9RPxHatBBK0q eK532JUhahty8v3KuLSE9jTt9DYWqrkR0bbHoKFTrI8V/OFJHSe5nSM5HWvUgJPIUF9x IT2cRSJHj8lTi4Z4bXcVE7xPwiUVsrZapHH8qknQEYTcuVkYF9BvK7GT9PTf/qBDoECF Xy4ArbwndgDGk6yVQlFsadJRRGS5Xxjj6TTscgZRfQaU0rSrb4a2i1WNgPomPeoGo+wh RWciSiOGazz5DMc6RCOHB+g5Yyou29gayQGCGf37GOy2bJXDKhiMa3KgTmeYG31uP6Qj NYhQ== X-Forwarded-Encrypted: i=1; AFNElJ9Alixvvm5zTaEX/X7A/ASHkvugCbTZ1vVONZfmovwVnT4Y/c7IR0x3VcimlfY583zPyJ9kmnIo3FKmeAw=@vger.kernel.org X-Gm-Message-State: AOJu0YysKLtnn4Z74u2fm8GGKC773vVprXKdEFBoEM6auDmtcignAo9L Jcl1522wgImazYpfv3vhh4cxfXMJg6jAq4Nh20+KymuRshKuzmQ/ou//MMdWF1dHrSGhoNeqdRm sMBHC32HCE6NGkff1M+Xfdiaa4amW+C3ywvX7UCDxjcgwX8I1/+QssRlgd1T9tReyxk4= X-Gm-Gg: Acq92OGVbOsDkl7BmKUEGw8ff0RXr2fq3OwpBUU+q2nmsUg4twLySCHa+ol+ZHHLntZ 8MWMVmAmP1F16Q5ZwR1oiytUnw11Lm8VnYvM86lX7PqdIXNDmpTlDMSeOwMXMiVPt93cZoc+lju jYc0Kfi/YHDxJOY8hjVcaMjpDgECvGXtYZw9eG8qBYvTMVg22GpahiJLz0/15J7Y9a6WxH2KpZM 8acOdry8vrIHO7wEiL58rZYQCFRaBpWE868MVaVdXkFUgVG5xFIhfkfdWXgLBHz5tfmczdhj0s5 OU3zQX5g6/IRwG7vPEcSFDpOSgb8PzqUl2rRiPXBM9S0PjLn05DD1FfPzo2K/nRLqzYjWyfXy1Q ejuAhTQ6ARjvUksynVY/DjA27Ad2+vatMxDOnfNlAaHsbjca8RkDELd1dbgVsO8EvJOlgB3+s2n bg5ba79IgsrmNtyV5/ew2njgZOAyc7Gq9P+Ds9TUzf6SeWizISu/tsqaJYoMJZoQ== X-Received: by 2002:a05:6a00:3288:b0:82f:1b1b:e166 with SMTP id d2e1a72fcca58-84284f23ab6mr7402418b3a.33.1780572526774; Thu, 04 Jun 2026 04:28:46 -0700 (PDT) X-Received: by 2002:a05:6a00:3288:b0:82f:1b1b:e166 with SMTP id d2e1a72fcca58-84284f23ab6mr7402388b3a.33.1780572526325; Thu, 04 Jun 2026 04:28:46 -0700 (PDT) Received: from hu-varada-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282374300sm7278706b3a.20.2026.06.04.04.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 04:28:45 -0700 (PDT) Date: Thu, 4 Jun 2026 16:58:38 +0530 From: Varadarajan Narayanan To: Konrad Dybcio Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5210: Enable PCIe support Message-ID: References: <20260514-pci-ipq5210-v1-0-a09436200b35@oss.qualcomm.com> <20260514-pci-ipq5210-v1-2-a09436200b35@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: 3YPs6g4ZgVc6RexFc5HpAGmpcB3Wv806 X-Proofpoint-ORIG-GUID: 3YPs6g4ZgVc6RexFc5HpAGmpcB3Wv806 X-Authority-Analysis: v=2.4 cv=Zp/d7d7G c=1 sm=1 tr=0 ts=6a21616f cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=XMczTv2Me4NSQKEp8ncA:9 a=CjuIK1q_8ugA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA0MDExMSBTYWx0ZWRfX/mbpFBDmlbH3 hCI2B8yka5ZuuTtuc0Cc8j7RKzjqkPus3dXZDzrLaDuL5qYN1z8aYf1nQEIOuyL1BYJcWrD8ine KIRaFYQOQB/3akYjkKo+eRaarTT/2EOdhiuqiqyu1BlG9y6QbglkXyEVi8g5s++LImzOXZSmu0S EstL3kGxu8lDqrK7jf/NKrGaKpqB+/Uj3mOcwn09uPPaGkf6b+RFe2S7/2H8MP2ZSR7ldp8Ff72 QmdlaOPrnJxpdck3Erbnn+aEqLEePZetFvJGsnaM/3ULmPaAX9jBnpEDIhluHz1y/wz0kJulmEu KEz5Es8y02fbP4a5WMBqP4X2fq7GWZt2S49vg/zhsbEQOew/RGTDTnqQ62jJNJMB0JlZ375rWd7 /xXErB1nJ+UZRVYeSKTHc01KdFECbgRFMGhdb+03+ZWHZkV/yXIpXkwoz90Rn66HgIygiBe3Cd9 yTpVKfBOqH90VYkQ9KQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606040111 On Fri, May 22, 2026 at 02:24:45PM +0200, Konrad Dybcio wrote: > On 5/14/26 6:13 AM, Varadarajan Narayanan wrote: > > Add DT entries to enable the PCIe controllers found in ipq5210. > > > > Signed-off-by: Varadarajan Narayanan > > --- > > [...] > > > &tlmm { > > + pcie0_default_state: pcie0-default-state { > > + pins = "gpio32"; > > + function = "gpio"; > > + drive-strength = <6>; > > + bias-pull-down; > > + output-low; > > + }; > > + > > + pcie1_default_state: pcie1-default-state { > > + pins = "gpio29"; > > + function = "gpio"; > > + drive-strength = <6>; > > + bias-pull-down; > > + output-low; > > You shouldn't need output-low in either of these definitions (+ sorting > by GPIO idx would be extra neat) Ok. > [...] > > > clocks { > > + pcie30_phy0_pipe_clk: pcie30_phy0_pipe_clk { > > + compatible = "fixed-clock"; > > + clock-frequency = <250000000>; > > + #clock-cells = <0>; > > + }; > > + > > + pcie30_phy1_pipe_clk: pcie30_phy1_pipe_clk { > > + compatible = "fixed-clock"; > > + clock-frequency = <250000000>; > > + #clock-cells = <0>; > > + }; > > Why do these exist? Just pass the QMPPHY reference straight to GCC Ok. > [...] > > > + pcie0_phy: phy@84000 { > > + compatible = "qcom,ipq5210-qmp-gen3x1-pcie-phy", > > + "qcom,ipq9574-qmp-gen3x1-pcie-phy"; > > + reg = <0x0 0x00084000 0x0 0x1000>; > > + > > + clocks = <&gcc GCC_PCIE0_AUX_CLK>, > > + <&gcc GCC_PCIE0_AHB_CLK>, > > + <&gcc GCC_PCIE0_PIPE_CLK>; > > + clock-names = "aux", "cfg_ahb", "pipe"; > > + > > + assigned-clocks = <&gcc GCC_PCIE0_AUX_CLK>; > > + assigned-clock-rates = <20000000>; > > Is this clock supposed to be fixed at that rate, regardless of the link > speed? And is the default rate incorrect? Will drop this. > > + > > + resets = <&gcc GCC_PCIE0_PHY_BCR>, > > + <&gcc GCC_PCIE0PHY_PHY_BCR>; > > + reset-names = "phy", "common"; > > + > > + #clock-cells = <0>; > > + clock-output-names = "gcc_pcie0_pipe_clk_src"; > > Having a gcc_ prefix here smells fishy.. Followed what was used in ipq9574, ipq5424 etc. Will remove gcc_ & _src. > [...] > > > + clocks = <&gcc GCC_PCIE1_AXI_M_CLK>, > > + <&gcc GCC_PCIE1_AXI_S_CLK>, > > + <&gcc GCC_PCIE1_AXI_S_BRIDGE_CLK>, > > + <&gcc GCC_PCIE1_RCHNG_CLK>, > > + <&gcc GCC_PCIE1_AHB_CLK>, > > + <&gcc GCC_PCIE1_AUX_CLK>; > > + > > + clock-names = "axi_m", > > stray \n above, also in resets Ok. > [...] > > > + pcie1_rp: pcie@0 { > > pcie1_port0 for consistency with other DTs, please > > Same comments for the other port Ok. Thanks Varada