From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from isilmar-4.linta.de (isilmar-4.linta.de [136.243.71.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B91B228DB49 for ; Thu, 4 Jun 2026 13:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.243.71.142 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780581536; cv=none; b=SKK5GppbfRF0oMrjpc5AMHgd8gNhrnQmHjIcnwnDwS9CIs9s2akCUzPZQkA9CnQgaiVCZkryuE3UEkZSUJ/DvSLSlrzLpdKICJ64YuODCbVaa5lvHPabnyQ3wRcF35grVAhQheDVVrXI8eFyxNkE6U4jIKX8iP8Rb75Jp43Ih8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780581536; c=relaxed/simple; bh=8j583DDQJbAhzpejaaX9ADc8p8ZRJBNDCn1RTpOpSk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cbp6RTHFmh4All2PO/6JU8BIZVDlgB5OtOadLKWiwWdfnxZ3P8ZyofYt5EsYz1dXmB5SC1J6pVgZaFVLv4FIgpfJbss7hPTuspy18+yUJSFoYvmSgB1RGCLck7G8mzphHPMh0bfW0aTZXWA6XYTRn4EPMNtcG1I1UfnLHSH2Qd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dominikbrodowski.net; spf=pass smtp.mailfrom=dominikbrodowski.net; dkim=pass (2048-bit key) header.d=dominikbrodowski.net header.i=@dominikbrodowski.net header.b=cS5DJFAv; arc=none smtp.client-ip=136.243.71.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dominikbrodowski.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dominikbrodowski.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dominikbrodowski.net header.i=@dominikbrodowski.net header.b="cS5DJFAv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=dominikbrodowski.net; s=k29.isilmar-4; t=1780581531; bh=8j583DDQJbAhzpejaaX9ADc8p8ZRJBNDCn1RTpOpSk0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cS5DJFAv0hR3/zLUSwYSM3++RM0cHgWbqZPLiBU+WP3zz14bHe8woRPv02Qv3N5HW jX6YCzZUIaGfFnQ/TKG9n9LCDnJtL2inVjTelfm5EDLlbGEdcfyz8V2/Thagw/Ui7L pO8IKgvJUb1E5c7eJhZCd10KVZk+VUAriQFgCzjuuv3H8ONRiBr9AvuttyyQdhg7bs XoDjzUumGOKOP2bTCGOJnBlqivwy395j9cdgNf4pIDmv+oJW3b6tV56/jhCtl4+UkX pRHI39h3Mt1Yk7fOWLw7p6kaGv5gVyi9iatCyNXashhY1F9LKuDlR6dtDp6zFB83lr +NFdLQhQa6jDw== Received: from shine.dominikbrodowski.net (brodo.linta [10.2.0.112]) by isilmar-4.linta.de (Postfix) with ESMTPSA id C45F5200719; Thu, 4 Jun 2026 13:58:51 +0000 (UTC) Received: by shine.dominikbrodowski.net (Postfix, from userid 1000) id 5B990A0094; Thu, 04 Jun 2026 15:40:40 +0200 (CEST) Date: Thu, 4 Jun 2026 15:40:40 +0200 From: Dominik Brodowski To: Maxwell Doose Cc: open list Subject: Re: [PATCH] pcmcia: cs: Replace manual mutex locking with guard(mutex) Message-ID: References: <20260603062714.45848-1-m32285159@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Am Thu, Jun 04, 2026 at 08:26:59AM -0500 schrieb Maxwell Doose: > Hi Dominik, > > On Thu, Jun 4, 2026 at 1:07 AM Dominik Brodowski > wrote: > > > > Am Wed, Jun 03, 2026 at 01:27:12AM -0500 schrieb Maxwell Doose: > > > The current code uses manual mutex locking. Replace it with the RAII > > > guard(mutex) alongside some helpers to help condense some sections and > > > increase readability. > > > > As the PCMCIA subsystem is in "odd fixes" mode, I don't see real advantages > > for this patch. > > > > Ah. Is that because not enough time or PCMCIA isn't in use much > anymore? Or something else? Both. If there are clear improvements (or even security-relevant fixes), I'm happy to take patches, but otherwise PCMCIA is slowly on its way out. Best, Dominik