From: Thorsten Blum <thorsten.blum@linux.dev>
To: "David S. Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
Kees Cook <kees@kernel.org>
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] sparc: vio: use sysfs_emit in sysfs show functions
Date: Thu, 4 Jun 2026 17:27:43 +0200 [thread overview]
Message-ID: <aiGZbzWglHiPIQzA@linux.dev> (raw)
In-Reply-To: <20260504181320.143003-2-thorsten.blum@linux.dev>
Gentle ping?
On Mon, May 04, 2026 at 08:13:20PM +0200, Thorsten Blum wrote:
> Replace sprintf() and scnprintf() with sysfs_emit() in sysfs show
> functions. sysfs_emit() is preferred to format sysfs output as it
> provides better bounds checking.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/sparc/kernel/vio.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c
> index 8b4f55047716..b7b06752a038 100644
> --- a/arch/sparc/kernel/vio.c
> +++ b/arch/sparc/kernel/vio.c
> @@ -13,6 +13,7 @@
> #include <linux/kernel.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <linux/sysfs.h>
> #include <linux/irq.h>
> #include <linux/export.h>
> #include <linux/init.h>
> @@ -121,7 +122,7 @@ static ssize_t devspec_show(struct device *dev,
> else if (!strcmp(vdev->type, "vdc-port"))
> str = "vdisk";
>
> - return sprintf(buf, "%s\n", str);
> + return sysfs_emit(buf, "%s\n", str);
> }
> static DEVICE_ATTR_RO(devspec);
>
> @@ -129,7 +130,7 @@ static ssize_t type_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> struct vio_dev *vdev = to_vio_dev(dev);
> - return sprintf(buf, "%s\n", vdev->type);
> + return sysfs_emit(buf, "%s\n", vdev->type);
> }
> static DEVICE_ATTR_RO(type);
>
> @@ -138,7 +139,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
> {
> const struct vio_dev *vdev = to_vio_dev(dev);
>
> - return sprintf(buf, "vio:T%sS%s\n", vdev->type, vdev->compat);
> + return sysfs_emit(buf, "vio:T%sS%s\n", vdev->type, vdev->compat);
> }
> static DEVICE_ATTR_RO(modalias);
>
> @@ -192,7 +193,7 @@ show_pciobppath_attr(struct device *dev, struct device_attribute *attr,
> vdev = to_vio_dev(dev);
> dp = vdev->dp;
>
> - return scnprintf(buf, PAGE_SIZE, "%pOF\n", dp);
> + return sysfs_emit(buf, "%pOF\n", dp);
> }
>
> static DEVICE_ATTR(obppath, S_IRUSR | S_IRGRP | S_IROTH,
next prev parent reply other threads:[~2026-06-04 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 18:13 Thorsten Blum
2026-06-04 15:27 ` Thorsten Blum [this message]
2026-06-09 13:24 ` Andreas Larsson
-- strict thread matches above, loose matches on Subject: below --
2026-03-09 22:44 [PATCH RESEND] sparc: vio: Use " Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiGZbzWglHiPIQzA@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome