mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: David Gibson <david@gibson.dropbear.id.au>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Ayush Singh <ayush@beagleboard.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	devicetree-compiler@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree-spec@vger.kernel.org,
	Hui Pu <hui.pu@gehealthcare.com>,
	Ian Ray <ian.ray@gehealthcare.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 05/10] fdtdump: Handle unknown tags
Date: Thu, 4 Jun 2026 17:19:42 -0400	[thread overview]
Message-ID: <aiHr7l0CsJjRem1S@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260409115426.352214-6-herve.codina@bootlin.com>

On Thu, Apr 09, 2026 at 01:54:21PM +0200, Herve Codina wrote:
> The structured tag value definition introduced recently gives the
> ability to ignore unknown tags without any error when they are read.
>
> Add support for those structured tags in fdtdump and introduce a command
> line option to dump unknown tags that should be ignored.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
>  fdtdump.c                              |  45 +++++++++-
>  tests/dumptrees.c                      |   4 +-
>  tests/run_tests.sh                     |  41 +++++++++
>  tests/testdata.h                       |   2 +
>  tests/trees.S                          | 116 +++++++++++++++++++++++++
>  tests/unknown_tags_can_skip.dtb.expect |  29 +++++++
>  6 files changed, 233 insertions(+), 4 deletions(-)
>  create mode 100644 tests/unknown_tags_can_skip.dtb.expect
>
...
>  };
>  static const char * const usage_opts_help[] = {
>  	"Dump debug information while decoding the file",
> +	"Dump unknown tags information while decoding the file (-uu to dump data)",
>  	"Scan for an embedded fdt in file",
>  	USAGE_COMMON_OPTS_HELP
>  };
> @@ -183,6 +218,7 @@ int main(int argc, char *argv[])
>  	const char *file;
>  	char *buf;
>  	bool debug = false;
> +	int dump_unknown = 0;
>  	bool scan = false;
>  	size_t len;
>
> @@ -198,6 +234,9 @@ int main(int argc, char *argv[])
>  		case 'd':
>  			debug = true;
>  			break;
> +		case 'u':
> +			dump_unknown++;

does dump_unknown should bool?

Frank

  reply	other threads:[~2026-06-04 21:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 11:54 [PATCH v2 00/10] Add support for structured tags and v18 dtb version Herve Codina
2026-04-09 11:54 ` [PATCH v2 01/10] libfdt: Introduce fdt_first_node() Herve Codina
2026-06-04 20:59   ` Frank Li
2026-04-09 11:54 ` [PATCH v2 02/10] libfdt: Don't assume that a FDT_BEGIN_NODE tag is available at offset 0 Herve Codina
2026-06-04 21:04   ` Frank Li
2026-06-18 10:13   ` David Gibson
2026-06-18 19:17     ` Herve Codina
2026-04-09 11:54 ` [PATCH v2 03/10] tests: asm: Introduce treehdr_vers macro Herve Codina
2026-06-04 21:09   ` Frank Li
2026-06-18 10:15   ` David Gibson
2026-06-18 19:55     ` Herve Codina
2026-04-09 11:54 ` [PATCH v2 04/10] Introduce structured tag value definition Herve Codina
2026-06-04 21:14   ` Frank Li
2026-04-09 11:54 ` [PATCH v2 05/10] fdtdump: Handle unknown tags Herve Codina
2026-06-04 21:19   ` Frank Li [this message]
2026-04-09 11:54 ` [PATCH v2 06/10] flattree: " Herve Codina
2026-06-04 21:22   ` Frank Li
2026-04-09 11:54 ` [PATCH v2 07/10] libfdt: Handle unknown tags in fdt_next_tag() Herve Codina
2026-06-04 21:25   ` Frank Li
2026-04-09 11:54 ` [PATCH v2 08/10] libfdt: Introduce fdt_ptr_offset_ Herve Codina
2026-06-04 21:26   ` Frank Li
2026-04-09 11:54 ` [PATCH v2 09/10] libfdt: Handle unknown tags on dtb modifications Herve Codina
2026-06-04 21:30   ` Frank Li
2026-04-09 11:54 ` [PATCH v2 10/10] Introduce v18 dtb version Herve Codina
2026-06-04 21:33   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiHr7l0CsJjRem1S@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=ayush@beagleboard.org \
    --cc=conor+dt@kernel.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=devicetree-compiler@vger.kernel.org \
    --cc=devicetree-spec@vger.kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=herve.codina@bootlin.com \
    --cc=hui.pu@gehealthcare.com \
    --cc=ian.ray@gehealthcare.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®