From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8074395AF8 for ; Fri, 5 Jun 2026 06:12:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780639966; cv=none; b=BAaQKg9HpS7rrQSS7Dh6H8uC3nCHrnX8TNu9OlrO6IRxQ4b3qWFKslff+jM6c8u7eMvo5FabsgqJONoFlhmR0BTdSNd/wEQqqOtGVT4W2EONEiO7rQTzxygpZL1m2uBcqb0hJgTl0LbPnDmFQK4b5VED5ND5HXgiQWSb4Or2nUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780639966; c=relaxed/simple; bh=7iU6z91ycljbm0po7ZNnr4gsCKmCcBFKZQnQbJmK7to=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lT7jgqoh64TBmHN2XmuSYG4YhOoEf8Q7DNp8CaPSX3IExuVPKvCvWBtGiNgFjgMb9DuIQNUQwWc9oibNXW+RTH3oF34UAbzEZZgBCsXvcCxLBoLR6iyIHcEbmW3ryWgXMdQ+4ZXwIKCDIKls5oocBkBidhzzOkNvtJsT059m2po= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dY8DTxaj; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dY8DTxaj" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490b4e1ade7so15854795e9.0 for ; Thu, 04 Jun 2026 23:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780639963; x=1781244763; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lgxx/Rs2dNmB7kmYA8c5lq8xrDwo/RsROcUUe32SZ/o=; b=dY8DTxajQfSDiVsGelG7WvsXa7jfXDTZkOxWCpe24eNdmQj9wDOxa0NvYNVyLhIdux Z2oIO1BwQ279LO5RK/VNgileTlXlonnSKu6e9fuLvwmba0rAGTNGcIsmhWysT0ySo8ON cdnDP5OFnvBxzhJKTCQ6PWBhao0BKB5yTZttukD+oCXYcvXtR0HQyY5yTCMYpBtlrdiM gG+PwHlukRFfVYiNxJ2SXVRGgGxVoC/SuaYkP97NS3ACQo9OAOlbxSwpyqmBG7niXQnU qDwa2Qxte2IOQjp5zlKJ/mBGMmF2OV4WnZAII100N12xoR7ky6XLgJq4lRLJCmVFABnt bX1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780639963; x=1781244763; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lgxx/Rs2dNmB7kmYA8c5lq8xrDwo/RsROcUUe32SZ/o=; b=K5lOk98n+1QhJJPnn92CquPM74Qm6T+pIMgoTuV13LqiF5dpfZwPOFjepMoEctVYQC KIEa5vsds1O80w9k+IkiPhG+MNdAk12Uz3PnTBlubVxqOakH35PNETrnQphAY/HGV4Ad ZY6oYr+xopJZ1f+WS4e3Bdknl46x8PwLgV8rtZsihHKMn2PbqoycgxO76Tn6IxB/dj3w CaFOay27sLwWlTaN9k4PjHqgSjhpWKlCD8xt/6sOAjN8nsIumoXSQcZ9q4dbOJeI1D5G vxp2x1X4kyzXWIxUFjYcmnNBnxP0cGDa9F0BIHqWYOkM0DbXejdNHAIKygeRANcn5lDV ytGA== X-Forwarded-Encrypted: i=1; AFNElJ8w0R0n9X6KRtRNmTKoSnCyHgHaY2veiECMeYV2avDG25VAEaNmlEa4utSEhnHWVY9kiQ2vsf9mFKi7wKE=@vger.kernel.org X-Gm-Message-State: AOJu0YwH7msB/1A2jCNROAVmEHVKkgAa4iB/bcPIEMMop3tDzFYRFCgc V/cdpr+4dhzhpfEgyvMCdfa2U7bkqKkLYYRGMNCzbCeYe6BGgZXNuhpk X-Gm-Gg: Acq92OG/5STq1h8oalF1WX91WxtKzjL0Nmn19K3FH0MeeRdZQqzjnGr4ObBOtTvLxDb gevfdqReKay4l/Kp/K6Ca7WFPyTX6myDFWp3egN7Zo9vxY6j0zSrGSkOXesxF0oSprGZKUpr1Yu xmQVyO7YX3MJzMzRe51AVY8H7g/QnOtJnXq8KCTe2Ww53MW1nUNsoE/kxikt0clSsPxHe3VkJ1m 6walHAZZf5NNdD0nNJvp4tlZFUAG8E92hkWp6FDcNTs1yf0fGmWYxMtj6zlh9ccjic81uAUvVdE mP20E/TEILexN3ScerNCLVHaxrAHaeUvXw4w9SnXSn12Mm9/Uur5M1K0D5nwzN6B4Ks3TLCgFiN krDH8tCAboJAAn9dSpXe34TxvitRYs5YYgVuuxr3b9MFonZlKUZiO8DP1szxsMehjpI1WIp3Kli EIgr1AxtaVCR4q8I6YGfNKW+TIWjbuDw== X-Received: by 2002:a05:600c:3515:b0:490:b5d0:598e with SMTP id 5b1f17b1804b1-490c2604783mr26573285e9.21.1780639962756; Thu, 04 Jun 2026 23:12:42 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3e59f5sm129250445e9.14.2026.06.04.23.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 23:12:42 -0700 (PDT) Date: Fri, 5 Jun 2026 09:12:38 +0300 From: Dan Carpenter To: Andy Shevchenko Cc: Jonathan Cameron , Maxwell Doose , Nuno Sa , Olivier Moysan , David Lechner , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] iio: backend: fix uninitialized data in debugfs Message-ID: References: <20260526191946.409160c8@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 04, 2026 at 05:55:08PM +0300, Andy Shevchenko wrote: > On Thu, Jun 04, 2026 at 01:42:11PM +0300, Dan Carpenter wrote: > > On Thu, Jun 04, 2026 at 01:38:50PM +0300, Dan Carpenter wrote: > > > 168 ret = sscanf(buf, "%i %i", &back->cached_reg_addr, &val); > > > ^^^ > > > Uninitialized variable. > > > > s/variable/data/. > > With what I asked in the previous reply and what you explained there > (thanks, btw!) I still think your patches are not fully correct. They > will require to atomically write all or nothing. If we want support > partial writes we need to go with that differently (reset ppos when > we got enough or more than enough data). Requiring writes to syfs and debugfs be atomic is pretty normal and works well in practice. These are very small writes. regards, dan carpenter