From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [180.181.231.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD524C77D3; Fri, 5 Jun 2026 10:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=180.181.231.80 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780657181; cv=none; b=tQqfxFFDMp6tk4umGa5uszX/lgkt7dXydm/+oeQUd5rgYpnn+AgdzvWg7aQYCOHF4jCkrBEgwTX0D40hUmsWKeZss+1b44+nc7OJ265aYyNOwcUl9A6iFDftldn7FoJQ5vWUTAj+Ut3zFJEqR+Cxu2fDrrVFr+ELFmIvTGxWVOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780657181; c=relaxed/simple; bh=PXb5JSuwGumLdCnZZP8fzBzDnTLRIq2SGiNizRd03YA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NSc/3NV/jSq8Ctu0MV097Jl20RsT+W7lKvgQ3Yqpn5DQAbkN89ZMNi6EffTXro2EIIkLuJx0sZmH640cVKnjJVh4D8N9PxT0DAKOOC5rkoGHC33b4KRF2gQwugWwjzrkHZCTUoVD61IHXvewBYABt1LKXBNCn9IYum6JERLG8Pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b=nQidnNEl; arc=none smtp.client-ip=180.181.231.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b="nQidnNEl" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gondor.apana.org.au; s=h01; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:cc:to:subject:message-id:date: from:content-type:reply-to; bh=XcDjXzBgSOCqOqLOATz57mfoHuQf9L1/ma18NCcbBRg=; b=nQidnNEldXLWW62lg8p9JNr6WIQvRLJ0UfJ13lPKQ8TrSLw+Wkbdmq3i4ncafCY9VlV+NXr4yex /pLYAwZgA0PgLoOQ/lAsNuOTa3P6av7f4YhxQrfv+BtvQFWEh366kNi6IgAZ2zVC94KlcE2drCELU R9YUlgo4vISsd5Xpoi+kt+HrwOFsvkb010bm6h4MeMab9/B3wrsbWKJduJkBNJakn1ZHJSMwsfulb wFwG9X5VsZsQ0b1CkWyTjsgk3itYW/NUKna+BW5Ci5MzvYQ3Q5fNimFMLd8+G/BVc4HKhZV3vFU4r KR2vw5Bqn9T4W2kkMpCGwIPOYgfPyM4ejrsA==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1wVSGy-002o4x-20; Fri, 05 Jun 2026 18:59:33 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 05 Jun 2026 18:59:32 +0800 Date: Fri, 5 Jun 2026 18:59:32 +0800 From: Herbert Xu To: T Pratham Cc: "David S. Miller" , Manorit Chawdhry , Kamlesh Gurudasani , Shiva Tripathi , Kavitha Malarvizhi , Vishal Mahaveer , Praneeth Bajjuri , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v4 1/3] crypto: ti - Add support for SHA224/256/384/512 in DTHEv2 driver Message-ID: References: <20260526094355.555712-1-t-pratham@ti.com> <20260526094355.555712-2-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jun 05, 2026 at 04:11:49PM +0530, T Pratham wrote: > > .cra_flags sets CRYPTO_AHASH_ALG_BLOCK_ONLY and > CRYPTO_AHASH_ALG_FINAL_NONZERO flags. An update of 64 bytes will do an > update of block size and carry over at least one byte to final. We > always go into this if block when there is non-zero data coming into update. For AHASH_BLOCK_ONLY algorithms, the export format must be identical between different implementations. Therefore FINAL_NONZERO cannot be used for only one implementation since the user can import the partial state from a different implementation which does not have FINAL_NONZERO set. For sha you cannot use FINAL_NONZERO since the generic implementation doesn't use it. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt