From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34155229B38 for ; Sat, 6 Jun 2026 09:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780737831; cv=none; b=YNmUqKPX/Pox/E4p69MvL6ZIlWZUvLWpKXYckGj8OuP6s7kFP0CM5H5UIAdls7WjBxB5zmqM8NrpMKcSbMh7iQv5Y4aDsfMeDpEdtZQ49aL3OEv3ae3VT8PbHM11Ejf/y+X3+1+nGMqxUbI3fn5aImzllBjWf6KND3FlmWOrjnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780737831; c=relaxed/simple; bh=BwhE7xdI5+5inoubbMFMEgTrsdY/m7GE7gSoGyMgy0w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GWuM7c4weUTe9s04sypGkzpOjb9uxzxTxhJzhvfzuvBgev2DFsPcMLGGvm4ZCHyToHdjc5nyK9Z9sM6kL5y39vlxeF30ZxWa/CDtrexFa6yRp1hg3OVOFArvAYAfECMfyOqJhwYf5agzsIi9Pul21QOvup+/AIIO3spqiHSyAY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FhAcSub2; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FhAcSub2" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-490afc47455so13253415e9.2 for ; Sat, 06 Jun 2026 02:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780737828; x=1781342628; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o3AECBOGH+bhiXvCtacqMdiArKuJwpVAkabTm5OFjxQ=; b=FhAcSub2FfhjWGfqL3Bdr9r4pcBiQCHYG4E7Div64s9BQJMLNVgJkrCwkjAY8Au5Y+ ylCyr8T5tqTdpJ6MAYxsD12yYof/9UGvArjzs+L66OxRZB9r+uLLyH5au/ikdOhjjO2E EbKC9NYimspoYIswt8vU7tx5mRSjitYkN2qTlgR3bIxlzC+b5kRqjYCA/7Tgm3AnmmDl aNhRVH7NPfvPWPnwcaESAXpgoAKusqt/AyZEXgpRKvvnCrwVkFlQSgcDWdNdvbeYW3t2 FZIUSVctpgMFVhHmH28SaBScakqVkWmpvBN9fJ9A7CzxfxH43bWPwYqfkVK2W4ZqDYbC xHfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780737828; x=1781342628; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o3AECBOGH+bhiXvCtacqMdiArKuJwpVAkabTm5OFjxQ=; b=FhhTD5qDTEzJrdzFvNIIy5GIszMtRja+XV/KLk448WfoPpUeE6XGCzm5OVBkzTmRCH qQNCoA2sRroG04Xc1NIrikS/jdNGn80Gt4ihvK73c3RcAF0sImpebeg1WpEs7MNSxFVL YRXUVm6BRcIPSKgxZ9lMMNCuqmoWlQ87ijf+bjs1KxeV25bJiKZsZDF7pdz1P5xA1c/+ NhnWptiO6A+sJT4xwXd2OAxHWbEgokRmc35mXwFm+j1dKozpbvRycOtREbLOZnayur6m avhyUE9dbAl0MdvqDxH/jKzGMjxv5mkwN1uKm5h8KnVHtF+L4iJYmMTEji+7DFYsYkQw zkLA== X-Forwarded-Encrypted: i=1; AFNElJ8qMajgrRwpudt/Z//5DYQHWezYebfnsYe6dScBUFoMHsIc/Orltisb34b7vhpy8v1RN31MkBEm6bKK224=@vger.kernel.org X-Gm-Message-State: AOJu0YyZQxBJF32+bNX3l0htYjuQxp8W2L/ZBH+wnZVohZ9gJfXYuBY3 Oat/BDKRVFFmVVZSrpw4U0hdypNiFwrCAS/mK+nGB63GLoKJrFUDzH05 X-Gm-Gg: Acq92OEBNmBFrdfxsFRvedwmOUrVP1FV1MmzzKGp66RxriCAMU+V4mW+e0TJbBZGkuT l4yJ9UCx9aX+yKwTgnA9n3BPr5pVaAd0GWRkYMgNCMIsV2KgfCsnNSOqjIuPO/0mygwyvV9dsDc WEef4fmXc7KAIrm3nOA/wb+/ezz1RRBsw0lVxE58U+Siy4Bz+qoQzA5R2jNFW/6fyuplRugxz1t F+UoDNKqHn9C/4DvHm9Nk5b06610Llt/SYarB6F+dLti6Sc1xGUbenmlrqNJRZYH4rZpIdlqKja eElQKmiaXiVAuIi50vFgQexlb1+n5yVcF2UNwLZYCbAlb8fM0stf230Mz0/wVnzfgPKRAOU02Ee d0c8pADLtTJHFiS/whKJw9er/raCrUbsvvTPkpKtYR/dwq+LMSSzukzWO6GLU38T9tthIWkgDO9 scutuMJPHtD6PauyC6nGDRXyiko7H6TA== X-Received: by 2002:a05:600c:468a:b0:490:c2a2:e91e with SMTP id 5b1f17b1804b1-490c2a2ea2fmr119883895e9.34.1780737828479; Sat, 06 Jun 2026 02:23:48 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc40716bsm230650815e9.12.2026.06.06.02.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 02:23:47 -0700 (PDT) Date: Sat, 6 Jun 2026 12:23:44 +0300 From: Dan Carpenter To: Rhys Tumelty Cc: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, andy@kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: atomisp: remove unused macros Message-ID: References: <20260606091447.168262-1-rhys@tumelty.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260606091447.168262-1-rhys@tumelty.co.uk> On Sat, Jun 06, 2026 at 10:14:47AM +0100, Rhys Tumelty wrote: > diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/debug.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/debug.c > index 8513e78856b2..d05832e7f337 100644 > --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/debug.c > +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/debug.c > @@ -12,7 +12,6 @@ > #include "debug_private.h" > #endif /* __INLINE_DEBUG__ */ > > -#define __INLINE_SP__ > #include "sp.h" > This is used. It should eventually be cleaned up, but not by randomly deleting stuff. regards, dan carpenter