From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36970315D5B for ; Sat, 6 Jun 2026 10:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780740092; cv=none; b=jnxDncGXN/HlzDcYTuYFWS3K5ElLzEEY4uQRmPMX0Vb31K8VUUw+UJ7G4c76ToIi2xvImxVA5X4TkeVKl8FznqTV5emBNeFkrg7OPLlmSeIfBx5eS0XJqGssNamedZb2zxvwTc+7874ATngIj3IXEXqgknndGegfklHqXrYQCM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780740092; c=relaxed/simple; bh=guHEDFa2rsm6aDL298zfk3vUhvYea+kgX4Mbo76bW0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CfCO7P0/j4j+b7AjSCubvtTVL4xydoA400nkCB00bIMlfEJlBIjbBBvAFfdRhUZwbt+8o3wJJhUbEDBgJlGCxCtHuUcbDku1TzPwaDhX8AL3Hsu4go6UwCmXc65QnMAtz8pZo9Hivp/w5fQ+pdpaIkppMXFUMbQwqSEl5sZEd04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WQt75umF; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WQt75umF" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4905529b933so27942725e9.0 for ; Sat, 06 Jun 2026 03:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780740089; x=1781344889; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W1uZ2JiW4gZ0Z6L+R/fOYTQ/AJABctRJmpqhLtiuumQ=; b=WQt75umFMs4pfOLPZnrAiMIDT0yBhIlawwm9OfIRTNpjNPPXMV26/H1Ntq2fJT96Oq 8eei107+7jcdkrugS9xkFF7+1tat/inqs+96pk0KdZ3nqkdsdne2Cnlwfgb5tKZIKtcG tgcH9KounpiB3OIcx42ZyKATNjj/rEsChAl4c4K5mcIsk6MUrZ5m+6B3msJ6UYWZrsuj OuQZ0WYag5U8DCt2Xc1bQYnipy3Pa+uiUDkUY94jzUNlnC1UCwybDRPnmvnpVaRihP76 e9JpBfN6tjkmU+rJh9IR3Jj86ksN1e16FTmiT+M/0FyNOV4v8bImXffZ77Tl8LAD+VJt HUiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780740089; x=1781344889; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W1uZ2JiW4gZ0Z6L+R/fOYTQ/AJABctRJmpqhLtiuumQ=; b=sU7iD2prP6jj2Hyxjay3oLUkpv5190W3aEJL3H2B+5W2Nae+l7IaJzRkDE1KIvQtqX QfNvNpjDo+YqSHY8IslrReCZIxbJH5/cm/dCsjgxgEHXmT/ebZMna15T57J8TCPftKws bdkkfjsgGW/Dwaud5RiM5PM26yGxVO1m5Ht9yTMdDvoZd+0scKWzXkwiL0O+2eWoH/HY iRt08ex7gVjpaOjxbozKMnI5MiC/PyIz3g99t+HybTrOvyh91wHksPV1oWp60srUMd3Z 9KY3ZNnfGi5e2JklETtHQV1vRrjDhQoBvx7PgTjDUufVblvKy5pIVqCeliZnWfon1mVF T3/g== X-Forwarded-Encrypted: i=1; AFNElJ+Llj5d2fiUbhCnW5DA4uglo/KahlNBlf6xTDJjR07nhRKHfTxoJ+VkTq+HWq/3YiTVgDWdUDHh0EWl/p8=@vger.kernel.org X-Gm-Message-State: AOJu0YyX5AFmRdkfRrASszbVAgG+gqISJ4bwWewFdPd41az5bQWT9jEW F448a5c4a52KHVr/DKj9/3996FM5YwoQke1aZfAQm/WRKlgkqsnwVw3v X-Gm-Gg: Acq92OE7Ct+EWkAr27rnOI7PwZvjHWMwFfwoCJjT85myCYL38QJKQfyb5fcU/sam6us U5Gbo5USwAcuRa1L+2kK1MIkgqdeNdYInO3cB8iWb4kf8lCru+mgf/su/nSRmXz9jgk92gIpW8N 4by+NnXBdPxYtX5dY4ZgC5KhKg53sbHbg9pTfFtI6b+ztHYfxBlPpdVwUO0uZ8dteGJvhidUf21 ULToeVKTGkTz+oQPJvRDeGsTb47lhd6MqTl7vxY/UgzfBVF6RWvsrFeBBOugWKY4/02ml/2tKfJ 2/fQWLevuDNbfXe7aqIgRjqxQpbdSNMdI0iORLzgWAAmfvs6ZPcS84PF58pKjq5+bj0y+xSwf+4 3FE2mBl9qips7sHAdQsii5uePthoF+Tg8C0Ypor6ODCxixRnu1MchUjD0qQG56etH1J/JRxWBTL HE5N/+lLoW9FDqKjSIlfD3Urtu+e2zBw== X-Received: by 2002:a05:600c:4e45:b0:490:c01a:5f10 with SMTP id 5b1f17b1804b1-490c257f8cdmr121984425e9.15.1780740089546; Sat, 06 Jun 2026 03:01:29 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f351d69sm57473786f8f.29.2026.06.06.03.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 03:01:28 -0700 (PDT) Date: Sat, 6 Jun 2026 13:01:25 +0300 From: Dan Carpenter To: Rhys Tumelty Cc: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, andy@kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: media: atomisp: remove unused macros Message-ID: References: <20260606092842.179826-1-rhys@tumelty.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260606092842.179826-1-rhys@tumelty.co.uk> On Sat, Jun 06, 2026 at 10:28:42AM +0100, Rhys Tumelty wrote: > removed unused macros across the atomisp driver that are defined > in .c files, but never used, which was flagged as errors in a > W=2 build, due to -Werror=unused-macros. > > Signed-off-by: Rhys Tumelty > --- Please slow down. Don't resend a patch twice in the same day. Follow all the v2 rules etc. I will review this patch when you resend it (not today hopefully). https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter