From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B419337E301 for ; Sat, 6 Jun 2026 10:12:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780740753; cv=none; b=WEZrPecHEfUE+Aj9jmYjSKgdEPAHf1zet5YXJ4vrO29HDdciBBcR1FZ9a36Fh/qOrPYDpmuW1nYWAggshsvsDVmZrg8fdbN0AHksDR9eZQwsfpk+ILGmLlhYI7OIqWifLz7tyRagyRQUrZ5I2aJmcJc7bdO930OcNlqPhl7Z47s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780740753; c=relaxed/simple; bh=TE++nM4Wwd5ozZqtx2iL6VDzdT29u/7ZQlw+SdcdkJA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ttCF5bo3fF8LPxCO+8A5u3DlmSDbZ3xii1J3+Ogl4tFsMHNAfyAya45da0gdBYjBQiupa0huo+bK0TLRUgYD4lTH3CcfVZYr93eXLGhxFRSoh0oQ9Gm9wlc22zN+6Y+gaHwgwz5MVm3iTFvnOAYPCTlmqfTQFtR/4reUCugSFZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Razc3XRF; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Razc3XRF" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-490b2b037d2so23690115e9.3 for ; Sat, 06 Jun 2026 03:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780740750; x=1781345550; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wazHcUbE8DAQ9Lh67uXmhqDsxXBo5A1VJQ1lnl3eDOU=; b=Razc3XRFt7JKLd37r1yW0dgWIk312fDvpytHgWR6PWLE3RlRXpf11bUSiruxpur/ge dj3ZhjbsXKfgYiDzfSpPY611mxfHvqFoSYO5KsbQEGaEvqLubMx/2dIP46nw1utlD8LN Nt4tqoBehuspuXaVdoeZXnFv26HUASz42avs9a1owRMDGCevY/5gACHbgPSCYp0UC1R9 5+2cBWj84XeOaMuMiFjmAW8cyxAmVwWAfTSTsGCvDiCOSUhonnP3wgXsikuX+tprAT4p plYYbNfUnwBckA5vfGOEChAF5lJYqk92AH+IZrNWf1oOpcLD/LsAciLAVypRr+5nDU17 RFig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780740750; x=1781345550; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wazHcUbE8DAQ9Lh67uXmhqDsxXBo5A1VJQ1lnl3eDOU=; b=f7ACCwJUiqXbVd7HS/6Sfabzh2bvmp//0AZwMbUWw/AWn8isVM0iqAxOVPN2wRBh+P cUBuDbhHYRGlodksQqSmIX58lWzOJ/hRuM+H1ydM7FDzqiE6N8uHrM3d+PZ8ED4bOcBr WJFRgUpuT0miaROytYwQYHpV5JjFCaYmPQcaWpqGJB4hFuAjbMyNm8M91Ql5VYxIfgqy vanDDQQEHNcnNjpFxo4LwqKfmSJyTwD0Sya59ulck3Zn63JUPKwQ7tgUPRkYvcqmJgGH GzHJKsxU9svngQKtgyggyTZqm02IPQLKzlVGZ5V3r8/dR9fdyylRZUMNZwrywimqfTXD N1LQ== X-Forwarded-Encrypted: i=1; AFNElJ/EAszf+2/HgwbD9Ap2nBdomD1jOMPxb88d5gmdz+/T/LZDuHbgBsrLm/wlXb6aD245uP3I8/9eeOWZwp4=@vger.kernel.org X-Gm-Message-State: AOJu0YxmAPuiQ2aUGesfNXbN1Aec7n4q3yQKVMAE535jSb9Mbi7cWpNk 7agFB/f4WBi4RzTBBnLg54sEQJijSB7Cog3E8fRuM/1dqOwrGW3A0E+T X-Gm-Gg: Acq92OGa8OSY9vfLrZ9wIYvEo0jNCKuIjM+QdPuwNgf4qQ8EWOFgSF8ogfc9LZMIilt a2yNPV/SzaHu1DXm6Es8qnk84SGWwPdRbVXDUhR1G+ogrTUQxSRbl6skt8H6mPr37aT77d4yoGg 3RfNeS+VrjImP2qBGBVbQFd2KB/IvZqKISu5ZepAHcunLIGQUG8oKBqvUAqCdjzdA7qrtzhe1Bh nSIgaip8vMRk1C+ed88LhYzGykExhd45tk24lDaVKnkimqYqJz+oMbszJvan3bGVWmThcInc6t6 uKpt6EIT1kyaNJrgRRuU2d/k5sju3flc9VgmFsZLwdv/tCS5yk0YwsKO7YPTO2VO5KBQdKLFbvi KzfhnOJ67J6mPkpicamZvFmdEwiIa/g92zLklV0q2ruj5UkyGJ1n0MWSV+5IkwnO2LXMUE+Tbn4 TIAiHNu/4NJZ3zEBc9FVvlkfj4NOk11afDCLbCg16J X-Received: by 2002:a05:600c:4e55:b0:490:b642:ce29 with SMTP id 5b1f17b1804b1-490c25bec84mr121569395e9.8.1780740750095; Sat, 06 Jun 2026 03:12:30 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc39eb04sm224957455e9.6.2026.06.06.03.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 03:12:29 -0700 (PDT) Date: Sat, 6 Jun 2026 13:12:25 +0300 From: Dan Carpenter To: Rhys Tumelty Cc: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, andy@kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: media: atomisp: remove unused macros Message-ID: References: <20260606092842.179826-1-rhys@tumelty.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260606092842.179826-1-rhys@tumelty.co.uk> On Sat, Jun 06, 2026 at 10:28:42AM +0100, Rhys Tumelty wrote: > diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c > index 4026e98c5845..0eafd81c44cd 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c > @@ -48,7 +48,6 @@ enum clock_rate { > /* TI SND9039 PMIC register set */ > #define LDO9_REG 0x49 > #define LDO10_REG 0x4a > -#define LDO11_REG 0x4b Don't delete this. It's useful documentation. There are some other issues with this patch but I commented on them in my previous review. regards, dan carpenter