mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: mchehab@kernel.org, hverkuil+cisco@kernel.org,
	johannes.goede@oss.qualcomm.com, hao.yao@intel.com,
	jimmy.su@intel.com, jason.z.chen@intel.com, ribalda@chromium.org,
	kees@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: intel: ipu-bridge: add sentinel to ivsc_acpi_ids
Date: Sun, 7 Jun 2026 23:40:46 +0300	[thread overview]
Message-ID: <aiXXTkvSyWfUIVt7@kekkonen.localdomain> (raw)
In-Reply-To: <20260607130853.55980-2-dennylin0707@gmail.com>

Hi Hungyu,

On Sun, Jun 07, 2026 at 01:08:52PM +0000, Hungyu Lin wrote:
> Add a terminating empty entry to ivsc_acpi_ids[].
> 
> The table currently contains only valid ACPI IDs. Add a
> terminating entry to follow the common convention used by
> device ID tables.
> 
> No functional change intended.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/media/pci/intel/ipu-bridge.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index fc6608e33de4..471a449f11f6 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -168,6 +168,7 @@ static const struct acpi_device_id ivsc_acpi_ids[] = {
>  	{ "INTC1095" },
>  	{ "INTC100A" },
>  	{ "INTC10CF" },
> +	{}

There's no need to add a sentinel entry to the array as the code working on
it relies on its length for the boundary check (not its contents).

>  };
>  
>  static struct acpi_device *ipu_bridge_get_ivsc_acpi_dev(struct acpi_device *adev)

-- 
Regards,

Sakari Ailus

  reply	other threads:[~2026-06-07 20:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-07 13:08 [PATCH 0/2] media: intel: ipu-bridge: cleanup checkpatch warnings Hungyu Lin
2026-06-07 13:08 ` [PATCH 1/2] media: intel: ipu-bridge: add sentinel to ivsc_acpi_ids Hungyu Lin
2026-06-07 20:40   ` Sakari Ailus [this message]
2026-06-07 13:08 ` [PATCH 2/2] media: intel: ipu-bridge: add blank line after declarations Hungyu Lin
2026-06-07 20:36   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiXXTkvSyWfUIVt7@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=dennylin0707@gmail.com \
    --cc=hao.yao@intel.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jason.z.chen@intel.com \
    --cc=jimmy.su@intel.com \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ribalda@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®