From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9003397682 for ; Mon, 8 Jun 2026 08:02:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905750; cv=none; b=Ho+k4uKv7QqzgUzGmGl8o24hCI138OwuTBWMm9FgdGnwxU6bPTIRKwlGYHOrjxqOKcwgQ7FEBAfaBIYBBCjpcaAXFNXe+k1wydIM/dRoq46rxe0HWPuCbUkr9GVuLl9AZj6HngWLt8M7ZGXf5OAqD1D398oUSvz2t10+GrZAquY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905750; c=relaxed/simple; bh=oSjjQCOpHsmpRILc6WfiBhPToJInYMi/ObdCxNJwjnU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AZAad9CdgCEC4yaIJzggtbvL0patke1vjgnwbgmpI4szvWyFA/pwg4BibpodyMKkd8TXngwPzhlI2ozaagMEdzuXGbeYq9lhIYw3MrHDMXUbyu6rX3SLZxYHEglsYwFtTz0yVgq2PB/3elsuHkYubEidwS0dK0xbV5WVImfNAJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=aGQE7jsS; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="aGQE7jsS" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490af320e2aso44156185e9.2 for ; Mon, 08 Jun 2026 01:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1780905747; x=1781510547; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q4D+rfriPl0lY9EHYm9kP066Cn47rD/uQ0mtQTBMxuw=; b=aGQE7jsSpCnYf7/Qqqn/++ZD4bYeo7H0qfIvbXmQMnQGjVeyM5kP7MMWYofvjKuryJ rA1Psk9uurXHOVE3RyDGY1FDa2QGAaevkSMmJnwn7XnqJma7uJYEWdoUL/ItahsEFl7o IPvFZCN7m5knLEFLM2rj64PRKf2QiCmJPaEEnToZ0dF3e0MzZ5kd/yx+VlGRbUh+9FFO i/koabJIVRFVC689ZVT7cAnl1I/QikSz8y7/E24wgm7nWiZxuUmR4jZ1+dcZ8uvcSG1Z IKXGr4NpUDuTSn6bEWdHDiVcTB4okW0mbYdYh8GVTKmx86ST57DfYeCmQhzIHBZstwZe 34ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780905747; x=1781510547; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q4D+rfriPl0lY9EHYm9kP066Cn47rD/uQ0mtQTBMxuw=; b=cGauU/71Xog5QzZZdbQL4w3IjnpOusBZf1OGOPWNnxlanfavmbt68RUjDNGbODM/cd vahDPzDDsIKDSQxqVa66jjLJ7XS3r8GXEjkKDp/Ypt57iDXJyUlrC0pu5LsJhMEuqP2X S32e5TG2Rb7UlCqiE+lGYaxcSukI3JhGHC000nmV/7d3i/zpLrz5fCp1AGov2YmNS0MS eltgnKHnFYTvr7hLx1FmHgDdUaCTwtbMq8nZ6UrdTg1k/unTxEpilzx62Nfv5H8GtZ7o jzrsIgWbN9eCr07SsHIuDKLtyoHqq+M/m+mPXJIcG+BfWKrfx28m0Fzgy0DyXFvH6zuz Iwtw== X-Forwarded-Encrypted: i=1; AFNElJ9G6ZRNjdUHoPO177OaqSAIv249cDqGFYN/j3gddEHSWB6g2mz5djRWqjJa8E3rBo/zzeyaIxyiX9l1lz0=@vger.kernel.org X-Gm-Message-State: AOJu0YyGVyUYhzXPP8SkTeqA7Kat3OXri3S72/Z2HAdU73A/o63X4NEK Xcp5OakoVwLQu9dfpcAGPWW+NSb+CTz+OqlYzMk+rRTLiZkKodyxxrpqY9hAVuelo9zmOGy1TTV KyMoT7MU= X-Gm-Gg: Acq92OFofZCE6FRMqLd88mwBkzW3cx3MD3gmVeipUjTP5KPnp+DG6uSc73pRLtL3Bxh NpiwYcSx5xRJAOA6LMB4qaVSG5eyffHTlYKrbuxWKPPqlqnwLEHkmsHBw7m6MCm7VrYQSMdgw7B MnOlngzzQm61W2mORszrHVv5FdOhNHijuxo50vwagpWhZNL25+a3u/mLqlQ19jzyHqKkWwjj7L6 vPVudVvT1YzX8sVJZ/siRUSOr6q1rgj/3slODUlabSPizLHGs8/+UTD2B5YlH6lpOojyLs2QtMv WvNgPoHmMyCTb8hlyiyGsMZ5t+Uu8n6xF8oxcPDMMbzKDl3Oe2x0cTnu0PieLcov1bUxQtMzk1s OizXTLepkTpi4F3fbJH9T995zJ4/r6jUIesEn2OFXTIzC9Gu/8atefogL4bqoUKQzAtHZ1ksxDT Tx/aNVooPvfOtGiJYLpU4lyDupQWtyaeU2u1GM5iy49s9davA= X-Received: by 2002:a05:600c:1907:b0:490:b99c:9337 with SMTP id 5b1f17b1804b1-490c25a0800mr227077665e9.10.1780905747263; Mon, 08 Jun 2026 01:02:27 -0700 (PDT) Received: from localhost (109-81-90-161.rct.o2.cz. [109.81.90.161]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3cc140sm447585645e9.9.2026.06.08.01.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 01:02:26 -0700 (PDT) Date: Mon, 8 Jun 2026 10:02:25 +0200 From: Michal Hocko To: Ruoyu Wang Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol-v1: use nofail allocations for soft limit trees Message-ID: References: <20260608063644.39-1-ruoyuw560@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608063644.39-1-ruoyuw560@gmail.com> On Mon 08-06-26 14:36:44, Ruoyu Wang wrote: > memcg1_init() allocates one soft-limit tree node per NUMA node and > then initializes the returned object. If kzalloc_node() fails, the rb_root > and lock initialization dereference NULL. > > The per-node soft-limit tree is required by memcg v1. Use nofail > GFP_KERNEL allocations for these init-time objects so the init path does > not continue without the required tree nodes. This is an early init code executing in during boot. Have you really seen this allocation failing? > Signed-off-by: Ruoyu Wang > --- > mm/memcontrol-v1.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > index 433bba9dfe715..3f41a15d8a8cf 100644 > --- a/mm/memcontrol-v1.c > +++ b/mm/memcontrol-v1.c > @@ -2246,7 +2246,8 @@ static int __init memcg1_init(void) > for_each_node(node) { > struct mem_cgroup_tree_per_node *rtpn; > > - rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, node); > + rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL | __GFP_NOFAIL, > + node); > > rtpn->rb_root = RB_ROOT; > rtpn->rb_rightmost = NULL; > -- > 2.51.0 -- Michal Hocko SUSE Labs