From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8836D34E745 for ; Mon, 8 Jun 2026 07:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780902734; cv=none; b=ImAOwjyazVTnS4DprOG38agU9YEmqyghFxMixiLmFjwuWEvAhU9Ns50n1Bbglu9zXxxMnBtOq0xtEeAO/vf6XfnKK8qYNGd8cRyP/V5JWOzWAHKd22CVCDieP41V7AQp8nm9hGNhOtNPAJga5Mrmn9BLBz7aBsYeq3SZO3IX30I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780902734; c=relaxed/simple; bh=iQaxjTszkEjiEZiSiUlMn1vD781sN7kupsAHg0qLIh8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z++AS1HmqFZCfF2fhyMVFq57UQqNKSmpcYHiz+pkiA8N1L41nhF36SulvnTP2sUv+PK0LGhtALXceZh+Nj5KvUGcpEx4bVF+5nwyI1PMMocmHRwvW2y6bzFzSrVtS64IBNx4iCfY1r4vv3y/bt6KhK9sZ163Jl7UTEPw8h82wgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gu+n+BFd; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gu+n+BFd" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-490bc6a7958so34482855e9.1 for ; Mon, 08 Jun 2026 00:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780902732; x=1781507532; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F5DCeU5OediV57bcWcfJYqqGuezNisQJlQN4Qb2qUp8=; b=gu+n+BFdNsolDvg3e4G6uQhqCnqf0eMxjQNs7ZSapI92KdUKfrL5p0dVbi1L8NI2eq 9OKtZmvxz8LlbH5lm6qTNEZV45O+9cDNGQm2WsAojeezz5HZGjoKDE9SpM2pMT4H+NyI 7vYaNYchZfHi98RHuKzxDCfC66bLvoq7NDk1y0YE9oolLceG5hwhzo1/ZFLBV410egTB 15ILfKY9taMvCq/gS536bf6S5pOAu4ETS9SnAcZk3khLAP4/8zoSRdH2haNgiUdx38pb x3r5n1zV30G6z0+jutItHx9r6YlqJ9sQoaDK4q52WM+n4zIw/7fSz8ZEMpDG4lt4vI8t YIxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780902732; x=1781507532; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F5DCeU5OediV57bcWcfJYqqGuezNisQJlQN4Qb2qUp8=; b=pUpFwrKtVY4ne57NTP8D46PA0/eAaXHce7cgC+o9ijxUp8vChTUchxmYS9b/0579PV 58d1kBX216lrA5MdkLCFTLdSq79MNPfRIonpEC51pXUAEohqgx1VI7rGhR2qc+18evAa gKMgkhePqprmgiisrgYRoFeyXB1pilsnJ/I+/TtRK0uNXFe4/+6rxWmhnYL80VxPUucj MCTDwCjTi4vSDC4Dnix46PTLyLv95u0VLsbfq7tSKnn50ItWXJYX2ixhmiaS465rXLzM lk5nOGInDO58cxBOPnu7A1qqlT04vcrOr8+kChRhyhPme5xk3o5aowz7RVgNpQZ3Y2N9 XCKQ== X-Forwarded-Encrypted: i=1; AFNElJ8Q1MuXyfce6K0OZ7pfE/DXD2Oy4hzUhFTHLQNGeNaIF1DKPYeZsw4UyyhXdaj251ihhlXyxldSGWxZ650=@vger.kernel.org X-Gm-Message-State: AOJu0YzyIlQmteQGLTan3royrYdvAWNYevc8d2lFUzH5Yq07Q1UhTjdm 5h9sta1mdkXLhwhe9bzyX2SJPcZBXGpewsPYfDLgjWg90WhWoI56Hwkx X-Gm-Gg: Acq92OE0ShZG3t+bKu3nuKE5mZqS39d0EWWClgzfNQHYmNAwzBg+c6NvIew23bjMWcO T9ASk4Nf9X7kNl+pN/YO242C4tOY6RYf5aqVM+Seo77v4RRA9mHT8Q7vPoYaOyaiSbf8Lyf9BNx gl0aVg6ANINImwBqFmj8/f2smdr50Q5un8/t1uhEh+qilU17DwLScCFS77XVxlZ9Zci6Q3dkfmv doj2tqclWnAIOdsZhUjI229Ca9maurBpNHdkfm74ayuBJgc3w8LlnRXBn4tLvC1fKiW/VFv4Xt+ QjBrYIZFFJOriASC2jzvMurATHrUxkP/6rnMv9B9g8ycKcLf/UZgMogMHIPVZi/ihaX4cH2FRrM ZEE1zExxhVIruVEFfNLlcXTdk9AU1pjZswLkI/jRR7UUCfpTMaRyQJqGiPJrYZ78r3pIR+Ez/tI wbKgBuGD8wh6c1E7LkCtyr2xpK2YDmdsc5g60KPzt0 X-Received: by 2002:a05:600c:6096:b0:490:c1cb:48f4 with SMTP id 5b1f17b1804b1-490c2d038e8mr179174005e9.12.1780902731900; Mon, 08 Jun 2026 00:12:11 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bda4fd52sm353491175e9.0.2026.06.08.00.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 00:12:11 -0700 (PDT) Date: Mon, 8 Jun 2026 10:12:08 +0300 From: Dan Carpenter To: Rhys Tumelty Cc: Andy Shevchenko , Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: media: atomisp: remove unused macros Message-ID: References: <20260607094130.3208513-1-rhys@tumelty.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260607094130.3208513-1-rhys@tumelty.co.uk> On Sun, Jun 07, 2026 at 10:41:30AM +0100, Rhys Tumelty wrote: > Remove unused macros across the atomisp driver that are defined > in .c files but never used. This was flagged as an error in a > W=2 build due to -Werror=unused-macros. > > Signed-off-by: Rhys Tumelty > --- > v2: Removed some macros that are used, or should be kept for documentation, with feedback from Dan Carpenter Thanks. Looks okay to me now. regards, dan carpenter