From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31758353EC0 for ; Mon, 15 Jun 2026 12:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781527985; cv=none; b=owhRkzpZobec9punqhSJOZao2y8jzE3HqiM/tMBPo72iku4KjdlzK8BLvnvjca7VfvkytObTdSVughMVIMBsZWXCKJpmpbngGApcdpd0+v/KSDxa0cZAyNrxgn5MvvTi4oPGHeoUnUL3KNbeLKtqAutj2WwZ1hkffcLs3NDJurk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781527985; c=relaxed/simple; bh=KjVjeBmrJVKuyjmRMYFWhqezrlsqJFk38c5b0afCLUk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oZg+THRdUr3NMtY3OYYlokIaVl06E0vtTJwD0kSrf0c4zsOeNJHrEarcI2CfESoVbjqaJhzET291+Rq1lcbwMd8Lu9CrVVb074S+U1wjSocJ44chXBOOYEsI4xqMX0M8VwVPjdsZ7sfU63XXLN6mG84h72JKH+ozjeotpuumxDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YWU1MiR4; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YWU1MiR4" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-91562bf6c12so391314185a.2 for ; Mon, 15 Jun 2026 05:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781527983; x=1782132783; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rp+3cLG/IkZra8uWUBB1v0uK+PmlhsRsCaz+zT6XZRw=; b=YWU1MiR4NJMXGStSO2jq20crGfAhJvspnfLP++W1wKz2oCszhsYSD8a3SsTfBraG/H fbF5NLFc+0R3hA4+f7nMSO6QTNpuJwYNbT1E96Fyb+y+KixU9+u2fcTLCjoMl4xNTzxN /VPqSzAbw8kPBXNHvTRO+l66caMDnYcrXKAl9Q3cUT6LDaUojLL/27L2e02v+ZYAuxDd 0wPv7usEPTvzhUME6FHLD0CwMq5McPpyKBBngy738uAwMlUDRU8UsKw9wZ0DdKMucLMW XeULx921fFokazBsFv2MAK7KEZxjcpIl93/aycuOuKqEQfbBh63dTGoxlD9FXoPypfdh gnMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781527983; x=1782132783; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rp+3cLG/IkZra8uWUBB1v0uK+PmlhsRsCaz+zT6XZRw=; b=c+yjkMJbOV1Ssp/0l6SioY84+SD3IqexNNpX6LM+S5HUT2Vkx4qNBKDItnwGODDOYp VzfhGqe2wCmfGx2I8TnvqLVJBoOAbUDJSLH1jRhoQxol4rgiThZwzu0zSpfQMezMFMOR U8PV+JHgkLTY9GfKieYs1u4PBKO26gcEVmgHrKywchQc+xx8t8mMFrwxXnyxadbGzqCw LDy3L1CY+O+6l6KyeK9j1NW1/d9/GuSCpFWlhtH9yjyY/siJq2kaGdTXtwUEJuXYUH2C 80rU8irYHjKJY7rA+UHQonZD616CEqfy+iiQvwOUK6IA2lL2LTrvEL/ila+rq6Lff4JL 7jgA== X-Forwarded-Encrypted: i=1; AFNElJ+yLhH2VclYk7lTymoY1+W2CV+Qsw4mlQRTyV3+IdHm+ccFlLHINickBzJiS0hVjoyyfdMXtlP2Dk32hu8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4qIBlq9HdPVHPf51tyhrwnWodQQEi2/QM4COsiTTmW5k7Fucv EBUY49nPRyJYXrGIjJjYnsx2H6BJ8EvGY65uyQ8IqQ9aHfcVclnQwTKg X-Gm-Gg: Acq92OF6xxNP6kJietWG36boMqqFbqDyCCq1bLoQihho2LmJVvbqZ9Ww+JhIGJ6dykS yJ1NT4QT7jmZ0sEdx9GjpxRRrOvSbSIr7YJskhOV/ghI9znFpsX2IT8la1TwcGMqqQYizAW5++W aujRBGqVO9dBvrpVgd3PDNlsixoShDahqfRyNWdj8h7ySBbugoDmG/iB3r+4sprjYkWNrFi0MKp 6kDp6+IV06DsPYObxkQhX6a5vwcBUoU19AWo6Aq3c2dS8uwxejNg0WzL2sEV3yg3HGYS2P0yZWq oZq/fAMU9KAsbinUKaUm3DLwL4TODvmMyxrpmGl/ia8bk5JN61T+Cam7Ydqye0JNXDG1R3g8AOs TlEAghcm0+RimqCqGQ00GO6WROUEx2OCzVinPdOXK/edE1XopsWtGT751Iq2e55wdJl/FU0464w WguuK+zGVQ7mBiYGDx X-Received: by 2002:a05:620a:448f:b0:915:e2a7:bea5 with SMTP id af79cd13be357-9161bf9f59bmr2020356785a.50.1781527982986; Mon, 15 Jun 2026 05:53:02 -0700 (PDT) Received: from localhost ([43.225.189.75]) by smtp.gmail.com with ESMTPSA id af79cd13be357-91619ed7862sm1104760885a.10.2026.06.15.05.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 05:53:02 -0700 (PDT) Date: Mon, 15 Jun 2026 15:52:56 +0300 From: Dan Carpenter To: Devansh Soni Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: fix line length checkpatch warning Message-ID: References: <20260615121838.30825-1-devanshsoni874@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615121838.30825-1-devanshsoni874@gmail.com> On Mon, Jun 15, 2026 at 05:48:38PM +0530, Devansh Soni wrote: > Wrap a long pointer arithmetic line to resolve a checkpatch.pl line length warning. > > Signed-off-by: Devansh Soni > --- > drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c > index c1185c25e..d727a00f2 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > @@ -184,7 +184,8 @@ int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) > return -ENOMEM; > } > > - pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf + 4 - ((SIZE_PTR)(pcmdpriv->rsp_allocated_buf) & 3); > + pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf + 4 - > + ((SIZE_PTR)(pcmdpriv->rsp_allocated_buf) & 3); This code is ALIGN() the pointer to the 4 byte boundary. We have a macro for that. But also I bet that the pointer is already aligned to start with. Also check that we allocated enough space to align it. (I have not looked at this code outside of what I can see in this email). regards, dan carpenter