From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] w1: ds2482: Use named initializers for arrays of i2c_device_data
Date: Mon, 8 Jun 2026 11:43:55 +0200 [thread overview]
Message-ID: <aiaNUDU2MDv7A2uZ@monoceros> (raw)
In-Reply-To: <20260604165027.83922-4-krzk@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
Hello,
On Thu, Jun 04, 2026 at 06:50:28PM +0200, Krzysztof Kozlowski wrote:
> From: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
>
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> i2c_device_id that replaces .driver_data by an anonymous union.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits. The former was confirmed with x86 and arm64
> builds.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> Link: https://patch.msgid.link/20260518171456.872736-2-u.kleine-koenig@baylibre.com
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
I wonder about this patch because it was included in next as
10cc9de3d4fc between next-20260526 and next-20260604 (inclusive) but
isn't included any more in next-20260605.
I assume this mail is part of the submit path of w1 to mainline and
Krzysztof dropped it from his tree to not create a conflict in next when
Greg adds a slightly modified variant?
If so, the expectation that this patch makes it into 7.2-rc1 is still
justified, right?
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-06-08 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 16:50 [PATCH 0/1] w1 drivers patches Krzysztof Kozlowski
2026-06-04 16:50 ` [PATCH 1/1] w1: ds2482: Use named initializers for arrays of i2c_device_data Krzysztof Kozlowski
2026-06-08 9:43 ` Uwe Kleine-König (The Capable Hub) [this message]
2026-06-08 10:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiaNUDU2MDv7A2uZ@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®