From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Siratul Islam <email@sirat.me>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iio: proximity: cleanup fixes for vl53l1x-i2c
Date: Mon, 8 Jun 2026 14:39:44 +0300 [thread overview]
Message-ID: <aiaqAEMj4mX9un--@ashevche-desk.local> (raw)
In-Reply-To: <20260608033218.26514-2-email@sirat.me>
On Mon, Jun 08, 2026 at 09:32:06AM +0600, Siratul Islam wrote:
> - Sort register defines list
> - Extract vl53l1x_wait_data_ready() polling logic
> - Logically split regmap_read_poll_timeout()
You may want to rephrase the commit message as in the current form it feels
like it has to be split to a few patches. In practice, it's basically one with
small amendments in the code that may or may not be split depending on the
Jonathan's preferences.
Also, you don't need a cover letter for a single patch. The cover letter makes
sense for the series and rarely for a single patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-08 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 3:32 [PATCH 0/1] " Siratul Islam
2026-06-08 3:32 ` [PATCH 1/1] " Siratul Islam
2026-06-08 11:39 ` Andy Shevchenko [this message]
2026-06-08 12:15 ` Sirat
2026-06-08 17:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiaqAEMj4mX9un--@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®