From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE29B372ED0 for ; Mon, 8 Jun 2026 21:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780954435; cv=none; b=VgaN5Ho75mp2y3FSnUH6Ut0chdZ5TnmFbtSReTfVzMiPObLiH0gbyfi9qTEH2d8eGFuxXWFzyfdXU27RXNiQUVdA4VW4YZZfUWD3jjjzp2DKF0BDeN3/lRCdt+SGk55uUXi0ejzVA/35DZsml83jdDqK3l4UbZWfFMR17BXJcgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780954435; c=relaxed/simple; bh=uszGO4MNZllLL/tNWFtSqCfpuTZq+zRrEO2na9inYgM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f9WBRioWfV0+BVczoBSwmaXdeapIhFafGI+c42VhfEwzeQQu1TXCTTCOL6TbnjtsEIABAoMMCa7r1zkeyKAPUT40FbrihaP9DO8ES1F7mc0IWVBLbsIN3KFuShDEXGaqF0iEthJwitb45djRHNlbxgyaLAzDek1hn1TZa+I8Uks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=TVdQc2Cn; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="TVdQc2Cn" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-91588056619so330656785a.2 for ; Mon, 08 Jun 2026 14:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1780954434; x=1781559234; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OgdwZVogUbainy7/Unrt+E9dpZacJHCnboYcy2jriXI=; b=TVdQc2CnHUB+2Gpj60Bu2x6aTqq1Ak60tnPQ2Rbe+mNSqlylI6gVd1fcoZL+1+O1E+ c4ojLFdFf2yEra6cNgzzCJdMPtmJGWSPX98GEKk8aD6vciSQ8r5+XjKaLk2brjm2mpCE EZ5WAtSsa9p2IJU/vYc/cdhJOgN7Bn3vtYH7KWEkjjH8dnzR/qvzCIGyWDb15/iqIt31 56nYVMHCpArUZcxHgY7UO+wmkpRi6Ph+P54FopeOFpFeFSOx/OVzTWl4kZR7tyFxsdO9 MYnU+OHGWsFJViZZ5w0ImXvOV1qjdIn3mvO+AJOXZ8gbZyGCMrJ5MFhSxFSfrL9TAVBw CNOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780954434; x=1781559234; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OgdwZVogUbainy7/Unrt+E9dpZacJHCnboYcy2jriXI=; b=Yro2fRAUnC5xngJrwyOF3TMO3EYxihBp2hukuabfHKXVfZcK4VZOrEsN4hGNz7FR/h lOwSG8p1+lP5DhsdEoSkHVohJHYNhXjQHbo/8oPlmfAx/ht+RcUCwvfTv6rAg44BdHig W56JdRONRrJVZixPMjwvP6yKet8yCkDvqU6c+Gj5A/Vb7lzQcUPK1OD2x8UDjxMIZCv/ KgypdHpzaWpGUEcvwp7lprRezqxhtQRg1kDQf/cM1I/ZeNwKICe6RRc162pce0sH7zmJ iXrxUFLUKjROyj9uC5JdvOl69LDqqjN7PyY6hMTBCpM8Y9j4yuvNE2Ym5UuU7c5D8Nq9 IHTw== X-Forwarded-Encrypted: i=1; AFNElJ+l3yt9STcgPrHYXloAeSACDCYs2Vgxx/q952YwgWtrIq9n3VIfcKY56vZNIRTW6ZS/Gb93RRBArVUfnoE=@vger.kernel.org X-Gm-Message-State: AOJu0YxVteKXsUKlnNonSNcBNWzjpDFKyPexdMDf61I4ci1sRFV/1Zj6 NQeSRtBLnkPjwWu7Vq8h+tPtULsu+OnIPBGyPmI8oNgJm9z6KrsNpmhUMFmoaAefeCw= X-Gm-Gg: Acq92OEz6Gvn7XO8H0lZrQwrpG7mJE6+jBz9GDasm9im5rbNN90N0s5ARr44S8gCHE5 NsT2fDIt7RWWm4Ygr3UjlwNI8SxKPFIynG5KDja7T2MTRJB+lW3+kjiqupj7GHExF8VaUgz43Yi slsQOEq3zIVakNxuxi4tIYBBDXo+Q5Aazkqz1hc++WBkI8fJ86+RiGOWxqhQdbq5GvWG4rYuv5a ZUQwHLhpgYNQ0puHJHU9Yf1NLFi6B3gnka+geOJ5xL/HdIO2pmpZTGBcdYBfsSaFLiJE5tYYbKt 5ME7jIZisOtbnRfui5VZQkiOYGUuHe00w4leTtLtSYtcuBrdp/8s6k5x5w7uFvJqsWq2f6Ps3wF 3tMEgsbbgJOaeGnf8TG8z1JPkNlIxmM7MRpQPFw0HNr/Evrv88K3A05dobl3lKrDE0BIql4in3U kXAuqIdJvZ0LbxPRGjAH+GloK/+YpriP4Xbbo652xzGGxXkTv9E3AAGV0ayWoJZPu30oyHKsi5b fsLgIYoVonkQNiZ8Q== X-Received: by 2002:a05:620a:2589:b0:915:5576:df09 with SMTP id af79cd13be357-915a9c25802mr2949853985a.3.1780954433560; Mon, 08 Jun 2026 14:33:53 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-915a6935cd8sm1467977385a.21.2026.06.08.14.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 14:33:53 -0700 (PDT) Date: Mon, 8 Jun 2026 17:33:50 -0400 From: Gregory Price To: "Michael S. Tsirkin" Cc: Lorenzo Stoakes , linux-kernel@vger.kernel.org, "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: Re: [PATCH v10 12/37] mm: use folio_zero_user for user pages in post_alloc_hook Message-ID: References: <20260608154354-mutt-send-email-mst@kernel.org> <20260608161810-mutt-send-email-mst@kernel.org> <20260608170646-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608170646-mutt-send-email-mst@kernel.org> On Mon, Jun 08, 2026 at 05:16:53PM -0400, Michael S. Tsirkin wrote: > On Mon, Jun 08, 2026 at 04:53:14PM -0400, Gregory Price wrote: > > > > As a start: > > > > 1) the user_addr and zeroing piece seems like a discrete > > improvement worthy of its own set - aside from end goal. > > > > This is needed by your patch set, but was requested to > > try to push us towards a more reasonable pattern for > > folio_zero_user(). > > What I worry about is people can't agree what api they want. > Oh that's just our base state of existence. We mostly agree that all APIs are bad in some way and we don't want any of them :P What you're looking for is to get people to agree to the least-offensive, least-worst option :] I don't think we're far off from that. I suggest doing as Zi said and start a [DISCUSSION] thread on specifically this and lay out the needs and wants and design issues that you've learned from the past set of versions and continue the discussion there. It helps to take some snippets from your set to lay out what you've learned and explain why you need the folio_user_zero() stuff to get from A->Z, and then let maintainers hash out whether that should live in post_alloc_hook or new interfaces (or outside page_alloc.c altogether). > I don't mind trying all kind of approaches, but it seems to > be past the point where people feel it's costing too much of > their time with all of these revisions. > People are still commenting, so I don't think you've gotten there yet. I think the rate of revision is what's costing too much attention. You'd save yourself some revisions by taking the attention you have right now and starting the discussion thread (and consider submitting the topic to LPC if that's something interests you!). All this is to say you're doing fine, just keep on keepin' on. Maybe pivot your approach from iterations to discussion for a bit until the opinions settle. ~Gregory