From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03CD43C3458 for ; Tue, 9 Jun 2026 05:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780983487; cv=none; b=D9n1ln8Z5reBcZpk/cAp0PuPOU8IF1s2SvcqjEcRU+aQ/Fey0Swq/UQ3cgborkI5CZqV2GYNYMYTk89gwyRXRJCrnbunr63kAZZHKF4ZEjY8+Sq8ltdxgLOupLQzNpRDsr/EupCrjmzY4IBOHlLGwlOK2+yS4VL7LNdSk3H82Lw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780983487; c=relaxed/simple; bh=cs+J9gHBHnaDZm+4UkjjauIFjbjChIVZYz4kpHDFfjU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XeZIn3eCFYRhQK4v+xpuv5byce2dBcvHfnW1PTD7iZv6hr1A9IwhpiCWLWnA3m4SDY2VTkGZtYVoNCuYwyzfZFKesLkkjf9AhZMuL6+mwY7xDSMjVC+vhVg8gGS3/TFUV7yDmJPN+dJZ3Bia0Hkv2t8t6GGpVl+84RzFnF9qRaw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PozMVXZI; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PozMVXZI" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36b903567fdso5137644a91.1 for ; Mon, 08 Jun 2026 22:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780983485; x=1781588285; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f0Ar/8R/e3J60CqzzrjWc5oNGKXlmxhAN8jEmzPMJ3c=; b=PozMVXZIpw4f2gS323d37OTIsJErRI6teFabicGHgQGGR5smkftgBed9lQaHSoenI5 AdkOtTPsT4kV1F5W8lQPFYuj9BgS0gw09bbGVsOUR1euNPkESvuOZt/gQH6O6U9SEtTw DiOzTkRINHb9dIpEt12W9BwEBt2Ez90leeQQaNC2nx0mgUBoM+7rgGoyIu6A7d2LX1Z4 902aFB5bTfpI14NGbi+1n/ZjfNmfawYy4qvlKLT6/dgbJblAAF5e1Z2iN51c8PZbw/Ma PVpIXll0b1qkyCU+9Q7VzCdK0e8acPAkKta/K/ezp0/PsXwFVMiktVOwiQIY2/vrXsgq 7MzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780983485; x=1781588285; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f0Ar/8R/e3J60CqzzrjWc5oNGKXlmxhAN8jEmzPMJ3c=; b=XVJMr32x/JpqcCTOs+Kp64hWEmiN2pZgoUjxtyDZPpunruhXqBdSyRzyVvk9gLQUKV 3aFcORFP4eCFhb0dRQEMnNvXeWcnIpbYd8134B/1q1K/oQarlpsr4izuuNiL2FJTJekd Pdr3LHpK50XThFvpD0S5UZZSF1YaT/p+0ArdyK5AFb8pYjixR7cGsu63Xw/qDuFGZyDR VgYo1a9jGkBWKlD5e54nt3Bcrejn5xWL7qvy/ddcIVfpw0vq2RCfR1oxSNZndhSgOpyH vp+TSLrjnKunr1lYmT2p51lXSNGsNf84mhKg2RvYT7zlmudedasycGewjkqb0VPaZaiw RIpw== X-Forwarded-Encrypted: i=1; AFNElJ9pwmLSDh+tS8NLD732WDzbqfKbyjITpXMIQkf92ogJDzKhyfM3QeyCS3zY8kCf+ZzixvJSNsRG9Pn0/no=@vger.kernel.org X-Gm-Message-State: AOJu0YwBaLKKQxYC282Ku/mdETBfBXutjrfVMY+TK+xf6AylADW1H8ju oNsVvB56o1AZs6k+nMfDRDbxV3G+bZBY7R4/dB0lqQog02OZitn/R9aA X-Gm-Gg: Acq92OF4ISV93RatzLdRsm/vM2Hmd3BggKy08935AlBILyZLBnrFh7MnE/durxoCLkl bBS226YmabhNgGypeI033ZukNH8bbHEXBcqSEu0274konKOSB9zPFH0SFpYrZpzeRz2fhbP6+BL YldF204x2w/evpkA9/mF97g1xLngRCQEE3DoSj2qznFde+5XjgKPX5ItZ+F1bfvcw9qgakX/Tfk F2Pbkx5xLMz5D581aE99FwGzim2c2+CE4XCohekmqbt8IycKa0tWLnuvrMFUcuI31MhvcCFcTPb QS+h6Vpt89/IMEmICX6iKsQNIkVOzMW9LGQEZpfyl4mI3K8wHrb/3LLpX3YhGAf8pQ22hVpuTjn BzYZ5Wkp4251v28ZWyQ9Z2cve07RU+hyQ2oIe1T6behV1YTVmPA+03zeSQfbTurreRRdGC3EVsp odnPHina7epA== X-Received: by 2002:a17:90b:4b84:b0:36b:9c4a:e05d with SMTP id 98e67ed59e1d1-370f0772022mr19530435a91.17.1780983485272; Mon, 08 Jun 2026 22:38:05 -0700 (PDT) Received: from localhost ([2001:da8:7001:11::cb]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6bf82fecsm18042826a91.3.2026.06.08.22.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 22:38:04 -0700 (PDT) Date: Tue, 9 Jun 2026 13:37:56 +0800 From: Inochi Amaoto To: Andrew Rembrandt , Yixun Lan Cc: linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: dts: spacemit: k3-pico-itx: Fix non-functional ethernet TX timing Message-ID: References: <20260608182358.170489-1-kernel@rembrandt.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608182358.170489-1-kernel@rembrandt.dev> On Mon, Jun 08, 2026 at 08:23:58PM +0200, Andrew Rembrandt wrote: > The "rgmii-id" PHY mode applies a symmetric 2ns internal delay in the > PHY. On the Pico-ITX board this leaves insufficient TX timing margin and > no ethernet traffic passes. > > Add a 400ps MAC-side TX internal delay on top of the PHY's delay to > correct the TX clock/data skew. The value follows the vendor fork's > asymmetric tuning (tx-phase 73 x 33.3ps - 2000ps ID ~= 400ps); the > driver rounds tx-internal-delay-ps to the nearest supported step. > > This builds on commit 3ea695eb111f ("dts: riscv: spacemit: k3: Fix I/O > power settings"), which fixed the GMAC0 1.8V/3.3V I/O switch > > Tested on Pico-ITX hardware with iperf3: 60s TCP each direction and 60s > UDP, all at 1Gbps with no TX/RX errors on the interface. > > Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3") > Signed-off-by: Andrew Rembrandt > --- > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > index b89c1521e664..59aecaa2d32a 100644 > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > @@ -186,6 +186,7 @@ ð0 { > pinctrl-names = "default"; > pinctrl-0 = <&gmac0_rgmii_0_cfg>, <&gmac0_phy_0_cfg>; > phy-mode = "rgmii-id"; > + tx-internal-delay-ps = <400>; > phy-handle = <&phy0>; > status = "okay"; > You should set tx-internal-delay-ps of the phy instead of the controller. This is a phy in "rgmii-id" mode. Regards, Inochi