From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D9483F9F25 for ; Tue, 9 Jun 2026 11:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781003063; cv=none; b=Hb2076S8ANDbaVPMXek4uxMBGNMbGDX/0qOyxU8Q8XRKFowrZMcr7Osz8B8S9Iv/UclweE3fmEfbMJyjEKLHedtchecBIokIqDQk8IgeX/tkKXa++vQfKihmxaM/2iCEZ/geSz6KCQNtDYW22R8I4OqfzQ7PYvesqIsHUqj2UDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781003063; c=relaxed/simple; bh=m7GUmmN6TsaD2WekpATDGc8I7GOU+6aD4TPHY8OsMko=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g2YSmUYgDt1zTad2H30gkjmcEVNOdAvmBOvntSGA2e576Uth6JkvV4NOKuJSbbio5HMu3SMsSgcG5x9mmPR5170nB7ZO6A5SA+nUgbejwdmbyHDR5EHJWnu2DJCmHj7qLwiaO1/0sdcLaP8+S3hQUwX5AsPhfsHpuwXRUMX7M1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=N11oh+hB; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="N11oh+hB" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-490b8a97b11so59517135e9.0 for ; Tue, 09 Jun 2026 04:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781003060; x=1781607860; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qMZ+ugQTvKt1SoEeguI61AFpJPgRZUBObKRt06EYOjg=; b=N11oh+hBS5EsiVPwSqkrRDOFeko6YqsbNH5XFlOxPFLNHbgGVZ/lSdVzEp52EOftQR pMyFQznlPMRdYMo7o+VA18mlonJOwjlqjV7t+1QrHTIRfn6lIitnamEBZiHOJaV2uNts CJuXIfmXPwV7rZmFM69yztpk9dhMca6AlIEZs/sjOjLiO+Re9X9+fiMrLfYoAwpGMgW4 WYuRxjMM0hcs37v8cPOo3ZLh1s9yBvMSRRDnnv7PyXR6NJCKhiDWNumEm9ZLGpy512G6 kzBqEFkwnhUK9xy/BOx17kcP9QU17JDRDoHzj1Xgx2Kr1kfs50ACGUvP27lxB4tktBs5 4rBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781003060; x=1781607860; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qMZ+ugQTvKt1SoEeguI61AFpJPgRZUBObKRt06EYOjg=; b=Z1EovIWAM7JtJRNdTuj0qByEynZJdh5w2S2GWncBRyJGpkLEIC3rXU5MqCfD7faOVX JIbw/8XItU32lVJLq3E6fzeNkZ8AtpDuCObcaQ6sElj5DvANM6BzJGfaa2dq+DNb2Txl vI35cGLaW1Cmr4y8VpjwjprHepgbvSzZRfId4lcuKxeJ8MFqNhc+yzLzFWlajk+Kw9TL 6YnCMDEaf8oGXLj2Ig0HKmprLuMjnLoA4FHonT0G5sCsWLbAag5Q51BojTwSt68iyH9X 2PPfrl/2tlrb2ny8AfjHRLSaYbfRl/6x2fRZMAO6N76RtD7LDaSwaJI9AQiptehrCS/c hHSw== X-Forwarded-Encrypted: i=1; AFNElJ94ooPIiqLJTSRxtMRxWnFy2PPqlEMLqmiKejgfoIdbiW9InUCSsdIJxpPsKC9xCkpg09o9ystjpbIxCYs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywbc+ZuXDHH3Ex/luf918HC605h9E0HVUUBlzes3EPdB6JwTBHb dXPW7kU9/gt1WaPq5olQGUoiv0ImIyhnvaUXUKAzJ7N7qikflnyjmeVVqMO8faWC54c= X-Gm-Gg: Acq92OFiA790ipV3PqRzT8cJy2t9XfWockyyjlVp29peYWQnNJ986D8PLy7WaFOOQlB kiPUt4TjZYBfZ1RwQcqXXyQqC5AhC4Mn61hiGYhl53ZhSUxY/36inpu7HnjxCgNgU7I8Tqw431T YiwdaA7f+WmdU7PX0H0/l4hLIHGy1cDp/QorulRzkyXqWmnSdqkaQjF33ozyUZN4HDl9Ri3rfZK Nmu457pZPLm6SW/1gpTXjqInRQMTobWMUbJAHOD4Lt3R/wuwIZt3K3HxfWy/u8aRAZ9av8P1ixY HVODJQ/QCeX3++9B542vg5AOJcfuHwQ/Sq88EYY7aVu2AnD5Lfgp39ySMQhAWUnleQfVInZEs5A FCc4Xz4oPu0Z2I1BIYwIiuwub0do0IpBvsyNKpVc/6wc3ZGtS7/q6lybjGBY9CRVNyQApMqNnGf N60AgZ07HCxLHqjMo3PjtuUv9AyXEEhcpBqxxQ X-Received: by 2002:a05:600c:1d27:b0:490:add9:7f88 with SMTP id 5b1f17b1804b1-490c25dd709mr343342815e9.21.1781003060505; Tue, 09 Jun 2026 04:04:20 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3d66c8sm451185945e9.10.2026.06.09.04.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 04:04:20 -0700 (PDT) Date: Tue, 9 Jun 2026 13:04:17 +0200 From: Petr Mladek To: Rui Qi Cc: mbenes@suse.cz, jpoimboe@kernel.org, jikos@kernel.org, joe.lawrence@redhat.com, shuah@kernel.org, live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests/livepatch: fix resource leak in test_klp_syscall init error path Message-ID: References: <20260602124509.365996-1-qirui.001@bytedance.com> <20260604083208.1071428-1-qirui.001@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260604083208.1071428-1-qirui.001@bytedance.com> On Thu 2026-06-04 16:32:08, Rui Qi wrote: > In livepatch_init(), if klp_enable_patch() fails, the previously > created kobject and sysfs file are never cleaned up, causing a > resource leak. Capture the return value and add proper cleanup > on the error path. > > Signed-off-by: Rui Qi JFYI, the patch has been committed into livepatching.git, branch for-7.2-selftests. Best Regards, Petr