From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69B59381AEF for ; Tue, 9 Jun 2026 15:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781017916; cv=none; b=Yh5E6JlAfIgmFcMt0Mk2BHStTNRdvU8VRJrDKh+WYrAsVHXsPNNow2i7Gmsq4ifkm+Uji9ruw04HF1FUHx/xVGjQhl0Hlglb8B8e4BzROmWxUSyWrIP2mpl2AzB2LOTrpsmW+8GMtv5YIdkqna4dl4sxcMrb7pjKGQKU1jk5FS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781017916; c=relaxed/simple; bh=2N6jjPNXS8KHkA9ELWAn9DU9QeobkpuL9vsk9iqxtB4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N+Eh9Ii7l9BkIUlpm1EbUUjdhCw7VzuPNfU4+YY0JyoFsWTTmNuNuYbuCMMObxogj35HBIs+cSt/i8uPsCmMrtivJWm1CSToKlegq8Uawc+lpIl5WyJsXjVwfXRQy3V0mNqH+zYJ4Osz7tohFdsCaM6vmB3K9XxmL9WMG78ndjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=oMeq8jxa; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="oMeq8jxa" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-9159951f05aso660315085a.0 for ; Tue, 09 Jun 2026 08:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1781017914; x=1781622714; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4JHWQ15ZRzqnNTI4yBH6/uoHMgLXFxEcxAiVyb8DKfs=; b=oMeq8jxaYTIDpX3677iVIffpL40PQNwhQC7oEKFTbUgV/TAGmjp+dKmA2i9Y1OEU+W +L5JoR7wHQANPUBf4lwWVMnVQ2ZQfmcoIkvi3LjOGsJmoXjzhjZDPgsqpou153P9dwr7 s8sXGynBp+/1JTpDDk2vp+seRzQW3Jlu2NQcOKaUQTnKAwBHlNoRzUmIUDYjMKf3/SD2 fGqigpEZNr2XHtbL3ta40r4OMWst3qoDJdJX0HEcGeHXEjgVWJQuaKS/UjKSBNR0xKn7 DRyQLE36k1OG9Vo9eJ41OuCvtYV0yI4ESwHOGUL/aTY8AQo2CQIevQZQHitKSKxBA7+e Vwgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781017914; x=1781622714; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4JHWQ15ZRzqnNTI4yBH6/uoHMgLXFxEcxAiVyb8DKfs=; b=Ia/32ZCBG32LnfG6WKTOBysFUDIIWYKYpTCULthLMGXENzonHXvSM1iWzGoLiCtuvE bi7tFpAL7xSjo1Km55sjN63Qn3y38VrV1bcrKVcNX/UvAuaghNhetBg29vLYfw9x5AaG RQdqqcG82hXuwgbSh+501cmnJfrHm54+OBgl4jlVndzLzOT0sPaKRA6GcxTeUh1dIDWB SqY+1L4lbRzuH3iKpEVZp4xpL5z3cxHCNADTihH/zohMHE0ENJSUL+E2MPLJBzoNfOS2 eBYlvKl4hEErHaDosNHMdPKr9voSIzA4c7LhkH2mUlaqkBr3mW/wp0P+ZSodDDOKL9o+ as4Q== X-Forwarded-Encrypted: i=1; AFNElJ/CpeR02vJIzaD2C4mHF8ISeoYfbJdgW3ew7K5aqLxUs5gm9xprHQBxFltEVITkJSd3ODUn+ujsBQb5yXk=@vger.kernel.org X-Gm-Message-State: AOJu0YwlkiolpxlzQ1zNhho2rsY0xoYDfX8jLUDRFFuDEjNFKrLEwj3y WxXdCOIGV20wmG1rQauexRIVTUeSsdVKDIG0nlvq4K+kb7E3NSsPygdLARjx29FvWcc= X-Gm-Gg: Acq92OF57UFiMYQFuk5iPglcbcxpt3rKyitVeyvkbAHNdHVw3IEZF1wOOGH+k2RbpRD nnZJY7NUn7umo0jE/87fENo4FP1EFsmNjPFhpF9Usam4yWodZzhgEvkgRj3hOgd/1GSImjbTgMh u8WftF2iaaFuyC/EwkkHOIKS8ckl3yCdcTwjJfm3uowRxaQHrQn4usHxqqDdQ+HP9OzRRC9QIen 5UPQpBm53rrzoXyMAaSNvnfYp4s3TYzAZFgLFwlTUrNNHxeExOxPIXmF8q4hgtq5+zOli+UBsG8 0igtg2nXYZ88z9IjHPYEWqnxXsDFN+7OeAPpaG1e6+HeefWV/YPtCl/NX2eLgolrzd0MgsGSQyq F3t8RUug6lr7fpTVzyTSjsmaK2DWUG5mfB3suScqO04A1msTBBATpiX61ospXtYET8VTJIyTf/A FOiURHmrTHFag5dRCj+HYrL6Zk6JAldTLnb6eFu8FbwRw//qoujhvTuq7vRQiu5w0R62QhOdp16 blVKdvfMJgZNFOiyg== X-Received: by 2002:a05:620a:4546:b0:915:cf88:1e3b with SMTP id af79cd13be357-915cf882096mr1578753385a.47.1781017914136; Tue, 09 Jun 2026 08:11:54 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a237330sm2207058485a.16.2026.06.09.08.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 08:11:53 -0700 (PDT) Date: Tue, 9 Jun 2026 11:11:51 -0400 From: Gregory Price To: "David Hildenbrand (Arm)" Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, linux-cxl@vger.kernel.org, linux-kselftest@vger.kernel.org, djbw@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, akpm@linux-foundation.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, osalvador@suse.de, shuah@kernel.org, alison.schofield@intel.com, Smita.KoralahalliChannabasappa@amd.com, ira.weiny@intel.com, apopple@nvidia.com Subject: Re: [PATCH v4 3/9] mm/memory_hotplug: export mhp_get_default_online_type Message-ID: References: <20260605211911.2160954-1-gourry@gourry.net> <20260605211911.2160954-4-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 09, 2026 at 11:52:21AM +0200, David Hildenbrand (Arm) wrote: > On 6/5/26 23:19, Gregory Price wrote: > > Drivers which may pass hotplug policy down to DAX need MMOP_ symbols > > and the mhp_get_default_online_type function for hotplug use cases. > > > > Some drivers (cxl) co-mingle their hotplug and devdax use-cases into > > the same driver code, and chose the dax_kmem path as the default driver > > path - making it difficult to require hotplug as a predicate to building > > the overall driver (it may break other non-hotplug use-cases). > > > > Export mhp_get_default_online_type function to allow these drivers to > > build when hotplug is disabled and still use the DAX use case. > > > > In the built-out case we simply return MMOP_OFFLINE as it's > > Ah, you mean without CONFIG_MEMORY_HOTPLUG > Yeah i'll update the commit message, thanks! > > non-destructive. The internal function can never return -1 either, > > so we choose this to allow for defining the function with 'enum mmop'. > > Acked-by: David Hildenbrand (Arm) > > -- > Cheers, > > David