From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FBFD481AB9 for ; Tue, 9 Jun 2026 15:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781017960; cv=none; b=QZwe0HlCGO7wQEAYwKqThomniJpksMDEu2d8V+syLihNVhWaPlTa0AwGCCmPKT/v5EuL/7vTg0QfsYRfn/ZUjpZImyHIEVGxHyE7sYw/7pltuBymRjqDX93cHn2obeT0Ry0jP/JQLuJwwfUJ3Qq+bCciEMXDCjhbQNcXy2+4gzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781017960; c=relaxed/simple; bh=0bY3+VnKsZDDkii4NqRrIp5qMNrkGIBYkCIcna1PA6U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s1e9ZMuEMA+RrWvFUrKRZ66wbXNtGLeXAb/lR6TaYhV2u/xFopoGWVTLv5cgF1J2BZeDTccFiA+tJfRGisNI3hIdA7GxAe8aOh8shj7IddXrJ0vQofNC7/MCMufMC4J3gHy5NcZ5nq1YD8zxVyU/NZISE0+nKn9SEzbnpyUZC+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=SPIeTAfq; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="SPIeTAfq" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-915ab38ac14so621456785a.0 for ; Tue, 09 Jun 2026 08:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1781017952; x=1781622752; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PSHte4tw4Fe/hwOe0BydbVQDJ1bfJM9PJbtvHiFr8Bw=; b=SPIeTAfq/uVTl/qWnURHgq9vcM2ig2PCso96nfK+CWLcDp9CeWt9zpIcjt/7ZRItjv PYzMsTe7GwbPRNzwPXWnqKM5QzYM8fSP9nIZfjKs2jq9vn0W3XF4fZKRzos6e0H4K3oK 8TS5794ywJKGemb4SgIr87Lb2mNB7ZmzFv/gROITpCWvzJRppDBxsT86OSDYMHXjSNO0 aL48CnI69GtNAF6Z7KMOY5HdF/BwUiMPmFhbY8hxhWVUAfFJ/f/AcTjQTpQKXKr65AuF bHkV679q6101p+i3Jbkk9hSr3LNPI+8CKDGk3Na/uF5cWitQeBwWihsImNRsiLTwXlE2 6qcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781017952; x=1781622752; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PSHte4tw4Fe/hwOe0BydbVQDJ1bfJM9PJbtvHiFr8Bw=; b=Tdf7xiqOq31t3XfVzqibX8L3BMm/dan6AKW7qKjWwjo2QilAqFAEcGYddLfQbMb63s 5EOyX0FxnUZ2UAbr0tWjDndg6cO6bRkaerJ2mLnFnFdOFUPTT1+iY2gTEJTWY5klrGAc bOLrmjTdrD/B2ay5cZOc1pzyZD2Pg3zGXz7THBJrGgzqJRgUrqN6gJuCjwPJOdZIFTXv +YSkydOL+3aTLJ90Vx+pNyGJH41C9bZDcbFU7FDik0k5LLql8l6DSP8CLc9bAlwt1MS9 xA4K90Zz6lFme6NaYVklNepEZL4sSyUR7VrHoNo+UJhaj8WIvodut7cY54USslnPGAB1 vM0g== X-Forwarded-Encrypted: i=1; AFNElJ/SVI+ozSG3csf69braTByfToe/AQrrf6Voxc2rg5Rdv0v38dzLHkaDWZNiJOehj+jXrGa+J9HLOh5HQy0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1fK0RScoC9adweZ8MiY/hOylKyAilFPEr9od2MLwigKwd00+o zFzfrGqo8p7B5KnejeyEEzLb9scDOmb0mAJ2txIxCm/mvx8YWoI5cKDn7btEgASPQ/s= X-Gm-Gg: Acq92OEITKKsA2CPSqgd8Hn/0MM/zVYzAq2OTI8yQHKrg06Mh0IDQedLB4PxwHGCE57 bsvqAJYtGE6FcUxgFSuW6ifeFNmod5gaxNJhQVgDAAl5JDCPBEPzGKacVWvq4Nbc5jpay1QvLru kP9QFGVhvEwSooHxuDKK+M8CB+IGM4Mx+IIP0kkdeCCJxqVBS3F00KFV+6h6be3yRr/fYkCxxEX AHCDxsyeQdePGyuBDXHWb3jyujjOI2lPA7/3sOnHuyve0G19p+X7UQOHa/ykMhgX54vEut2Huzl F6xM5s0tfVLs0H6FSAKd9CgJnmmnq8b6BPXzQLTp9x56vSarUleoC+z9BsIZOAYVlbTDfKPA9HY vKSuVEYn2CBNQMbLnwtVIVT8HZ/c2QbeU8eH1MsWkWZFj4g9pax8ESKNpRA23UbUmS89jLztqKJ PYlSkuGEurMvLAht3S/jWpd/lYCZAWZNUr9tpgwRZVhtfIsrOgYFkKbJsAkxUulbrFrcdD1W022 1gpZnkMg38lgoOorw== X-Received: by 2002:a05:620a:2587:b0:915:9c4b:fdae with SMTP id af79cd13be357-915a9cb2d33mr3324652285a.21.1781017952150; Tue, 09 Jun 2026 08:12:32 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a411333sm2261055685a.46.2026.06.09.08.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 08:12:31 -0700 (PDT) Date: Tue, 9 Jun 2026 11:12:29 -0400 From: Gregory Price To: "David Hildenbrand (Arm)" Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, linux-cxl@vger.kernel.org, linux-kselftest@vger.kernel.org, djbw@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, akpm@linux-foundation.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, osalvador@suse.de, shuah@kernel.org, alison.schofield@intel.com, Smita.KoralahalliChannabasappa@amd.com, ira.weiny@intel.com, apopple@nvidia.com Subject: Re: [PATCH v4 4/9] mm/memory_hotplug: add __add_memory_driver_managed() with online_type arg Message-ID: References: <20260605211911.2160954-1-gourry@gourry.net> <20260605211911.2160954-5-gourry@gourry.net> <9361f783-5af4-4380-a901-8d330370491a@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9361f783-5af4-4380-a901-8d330370491a@kernel.org> On Tue, Jun 09, 2026 at 11:55:24AM +0200, David Hildenbrand (Arm) wrote: > On 6/5/26 23:19, Gregory Price wrote: > > > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > > index f059025f8f8b..d3edeb80aadb 100644 > > --- a/include/linux/memory_hotplug.h > > +++ b/include/linux/memory_hotplug.h > > @@ -294,6 +294,9 @@ extern int __add_memory(int nid, u64 start, u64 size, mhp_t mhp_flags); > > extern int add_memory(int nid, u64 start, u64 size, mhp_t mhp_flags); > > extern int add_memory_resource(int nid, struct resource *resource, > > mhp_t mhp_flags); > > +int __add_memory_driver_managed(int nid, u64 start, u64 size, > > + const char *resource_name, mhp_t mhp_flags, > > + enum mmop online_type); > > We prefer two-tab indent on second parameter line while touching code / adding > new code. > > Same applies to the other instances below. > Will fix on next spin, thanks! > > Apart from that (still) LGTM. > > -- > Cheers, > > David