From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D73148A2AA;
	Tue,  9 Jun 2026 16:44:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1781023470; cv=none; b=ZLXnjLrAk91/87SWl6nt0ffUJLawsIDiITzqmOkVtYPk/LDi2CWJxlRglkobZdoRRANOWiZJAKn8cr64ZojxoJ+ha3NjHx51FlQ4S/b4VNbN0w/8XbKuiatRaFN/cpYAKiCpXJ9SuIqSUhJ1qrDkv2wOMwXY1D4T2GkvPeyVvLw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1781023470; c=relaxed/simple;
	bh=qyLiUYQYTimn1rhpf2aWmkrFCd6NM2wRneTiaFmzHlA=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=WdCUfHA3apn3e3MVh9YL/pRE2SHMp4L3UAUy310D4VCYICUlLYSOnevuclPs0G/JLFQySLAkT7QTKDTGvnVP+bE0zjDg1JV83r30s9h6EcpJcyyBmLEak0QGLabFRXcC1CuVpe3KV/HSHGTBxtty95ZxqEe3ZsOIgHDvbRRAOHY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BorsVzHl; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BorsVzHl"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCC161F00898;
	Tue,  9 Jun 2026 16:44:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1781023469;
	bh=BmnzHaguHtKrAa2TQW4hv2Uu6Zp1K1zLfEAoMbU81Ks=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=BorsVzHls2J/YBQteZWCZbMXAOp0n+Qm7iccO3JxCW2upxHeITtBNGeiFw1Ofp4zA
	 uzAc9n3mfmV1pOgaaqu9vsZw8LzSXwJBKOGwqjCh+fLy4OPAPEF81h9jWsaiPVrzXC
	 Q838Rm/Z1UerIKhtq+bb/MkVzY0J0YnnUP6ImtNVkUEnBsoLIDa2BV8Pb5x+G3YOWt
	 68KJ1GbUGGuQ0l8eLk+6nUMzctWfcznzn2+1XWIpKd4dH2AcAzItG7TCtX+5IwYfyw
	 4QubjMAYFFMkY14ihVLoWcx3wWEZJ84RTiIAbX/aDTdnC8Vn5oXLLL4imK58duWCvS
	 EGYNXHYFLlJFg==
Date: Tue, 9 Jun 2026 10:44:27 -0600
From: Keith Busch <kbusch@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] nvmet: fix refcount leak in nvmet_sq_create()
Message-ID: <aihC67cPlS_Y6vB0@kbusch-mbp>
References: <20260609095505.227496-1-vulab@iscas.ac.cn>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260609095505.227496-1-vulab@iscas.ac.cn>

On Tue, Jun 09, 2026 at 09:55:05AM +0000, Wentao Liang wrote:
> In nvmet_sq_create(), a reference on the ctrl is taken
> via kref_get_unless_zero() before calling nvmet_check_sqid().
> If nvmet_check_sqid() fails, the function returns the error
> directly without releasing the reference, leading to a leak.
> 
> Fix this by jumping to the "ctrl_put" label, which already
> performs the necessary nvmet_ctrl_put(ctrl). This ensures the
> reference is properly released on this error path.

Thanks, applied to nvme-7.2.