From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14F4840D593 for ; Tue, 9 Jun 2026 19:20:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781032828; cv=none; b=dOQmKCZFjkXZkeBc8bCgMQZkLaZAEY7nUKAohkPT+Yf2XhgWrM28O5vrP5z3AWCl3NCmsd03cvXCn7ubY+YJTOiZk8nWbK+FYSc9BJB7XfIPA9n/P1dRQhWVJIwxanSr37xRzHPm8RcScuv3WzObx28SMrWwKxY8gF5/SJxpU7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781032828; c=relaxed/simple; bh=rlmbF+XFmpnsuEbkCrCG5OvGXP8h/md2WplUgUGwEU4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ig/NVe7L9TkqWTrwySD8GGDe3QI4DLMi6uReSRGevm6E1eYWJe3F+IXQrfvI4bufCyJnijPNJSdOHpgv1TiIKOxTxtFCf0td9AebeJHHJ1cNqfaMJL0iOvmnsY8nESyR2MynLMr1pWQv7gIey3txnHxmQHncFSDgYLBQtcGKRB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=o82RCiKt; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="o82RCiKt" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490b4e1ade7so64297705e9.0 for ; Tue, 09 Jun 2026 12:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781032824; x=1781637624; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rlmbF+XFmpnsuEbkCrCG5OvGXP8h/md2WplUgUGwEU4=; b=o82RCiKtfurXfuLpEp6G4ZzkV9Z0TMzyYf0io/uBe+bWjYQ/1hmRqAq4HFP/N/Ivpg OBgSRnxTn+Ywcvkk/toYNVU4LDCrbe1+G+Y4NOaodhKZ4OVPbp2tyEjAmdLIGeP22Lss MMyBJrPDxni/QwUGNFRs15MZA4H1NqQbv13J/Htv1ikK0LjwFqedbkMpGyQSS9GvfUYs Ik3Km0lOqg/5nGpvA2v6Kq7Eh979PyIEbfxskzde37gdU65Sp/I58P7O8Hzu5XCbRSyz ooSfF5Y/TwAlyq+PKvld/1nYR+lY5S4CYFDgNJ6yJdZZKOdn5AGIr5rF6aIBTzgoCnqx 8TWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781032824; x=1781637624; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rlmbF+XFmpnsuEbkCrCG5OvGXP8h/md2WplUgUGwEU4=; b=MO6CxKwMcGcYqrEK2RhFzwfCIT2O/V/SY9OUoZEu5Knemir16tPCSn7urb7Tdq/r/K 4ZkyO4idbY0osQHlXYE4nlgwbIlAqHnHw11kceyGX18ut68HJxHn2nokrT9PO+u5hJhj 4E3QWUP1YF5U0nsbnjysLNcb6HBxly9RSRLfmhO9VCLCdtwg2SkCqDbdkb4lCYtnp1qM 2iK/WSn9W2GpL964dQnH7rUniG7nSItcs21zkNBHLO24ex3Edq01100es/jheLOScSMJ 3LBnXYFUt3LMa2RtXpBe2gTev/FYECVE/ORBcI7LvznPwYXwktLAWfGasUCv/KVdywko Vegg== X-Forwarded-Encrypted: i=1; AFNElJ8plkWLc4H0oRSw3jq7mnZ217hOI3EdUjqlyhjLpiozMTk71PLipAUWzlR0YfokVA2THXnQA2p42ND8/lI=@vger.kernel.org X-Gm-Message-State: AOJu0YwszYEwAKGvQFfW4mwxDD6XWZz4YQNGN5sIEdHlN/30tJ5zI/NF Gyh3VKGrzhTmQtnQBQset+oBlSQgLHgRx2v0OdjoTXW6I13wFuTXxOjIMwg0jlOFHVc= X-Gm-Gg: Acq92OGOf+GwjqYqbfXeGlNI58ZHUMWxY3fAVPtWCXoOHjZGiVcS7cdTtXTZTNRA1lm ci6LDf/sImEom9BgxKaLc4L6ctZuUy5dcQQEFOgJdYAopQzMO5xFdEsIBsasySG2dFHNh2PSfEG JTS76UoLZ/oA6c3NQI1OW4pkDsSINUOQFv6JIFNQdh0cky2xJTFnVfAf+ZLArqdmaqs+sbVmovz MfgqwbQF/pGcJKFvcMSXno1eIK/UbtOAh8aQpHU5n8e/MIKM/fAQgRlK99yC3DO9iu9Q4GfZu8r CTnho+hWVskMZQfoBJ0uVsnapt9QqwmvX5zCyxhB7OWXG2AGQuK3T4tz8ldLCAMfYXkvlHvyoxW mlfbkh9LEcTKndKoLiWrsPnsfZ4j1Mzsx3yuExLVx8HxnaPj/RS4S1k2BRmX5RoGiw09lDj843l K4I2OpMP+9OHTv04FrayyCdJ21+XMHAG307Yc4PVU= X-Received: by 2002:a05:600c:530d:b0:490:b92f:ef5b with SMTP id 5b1f17b1804b1-490c25d4cfcmr389552525e9.13.1781032818258; Tue, 09 Jun 2026 12:20:18 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:559d:eec2:887f:c200]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-490dc47d4e0sm4497415e9.0.2026.06.09.12.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 12:20:17 -0700 (PDT) Date: Tue, 9 Jun 2026 21:20:15 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Jaroslav Kysela Cc: Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] ALSA: Improve style of pnp_device_id array terminators Message-ID: References: <47ae32220446ec1869898cf5e4b75ec94c32dfdf.1781023479.git.u.kleine-koenig@baylibre.com> <15b9f06b-952b-4c55-aea3-fd64f456d30e@perex.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="svdunbpcuffeoucd" Content-Disposition: inline In-Reply-To: <15b9f06b-952b-4c55-aea3-fd64f456d30e@perex.cz> --svdunbpcuffeoucd Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1] ALSA: Improve style of pnp_device_id array terminators MIME-Version: 1.0 On Tue, Jun 09, 2026 at 08:38:57PM +0200, Jaroslav Kysela wrote: > On 6/9/26 18:46, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > To match how device-id array terminators look like for other device > > types drop `.id =3D ""` from it and let the compiler care for zeroing t= he > > entry. > >=20 > > There are no changes in the compiled drivers, only the source looks > > nicer. >=20 > It's not true. Unless the matching and lookup functions are not changed, > there's difference between NULL pointer and pointer to an empty string. >=20 > See match_device in drivers/pnp/driver.c - "while (*drv_id->id)". Your > change will cause NULL pointer dereference. That's an easy but wrong diagnosis that I fell for first, too. Note that =2Eid is not a pointer but a char array. Best regards Uwe --svdunbpcuffeoucd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmooZ20ACgkQj4D7WH0S /k4emgf+KIRD+pZZMDj8W8g2J9mUL113vwgqTF5NR0dP5e7sIxITJiXnQSRTYs9U CGsJoP+vD/gKn2aI1vw16VHdQbdKdp/QJMDZTahmP2WAVQt1aWx97O5+nuy+cDXN Oc9pnO5RHjIFaxUkIFuZAZeHH42jHEqImjCA8T0HXKrbnXsjF0GHAEXP/9vAkaF9 m6ib9uJTjInRhx7WagKksvf7GA27lZGBwZtIOJwH2bzDjDXfShbKLl2JY8NUfjzu OU3tT/gSKLrEuA+j3JWN6vVqefXP2KbfJgvHhJuJQ+NTEz4j8YhVoLJtsUkIYNye Tn9/N43YdYDsVErzmsm/qbKHrGq4MQ== =e3IW -----END PGP SIGNATURE----- --svdunbpcuffeoucd--