From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: GaryWang <is0124@gmail.com>, Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Thomas Richard <thomas.richard@bootlin.com>,
Daniele Cleri <danielecleri@aaeon.eu>,
JunYingLai <junyinglai@aaeon.com.tw>,
Louis Chen <louischen@aaeon.com.tw>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: tigerlake: add some pin groups and functions for INTC1055
Date: Wed, 10 Jun 2026 17:37:41 +0300 [thread overview]
Message-ID: <ail2tWow7VwWRkL_@ashevche-desk.local> (raw)
In-Reply-To: <20260610142409.GT2990@black.igk.intel.com>
On Wed, Jun 10, 2026 at 04:24:09PM +0200, Mika Westerberg wrote:
> On Wed, Jun 10, 2026 at 04:34:23PM +0800, GaryWang wrote:
> > Add i2c0, i2c1, pwm0, uart1, ssp2 pin groups & functions in tgllp_soc_data
> > for device id INTC1055.
>
> Okay we can see that from the code but why? Can you explain it here too?
Yeah, good point. I know the why? because I reviewed the pinctrl-upboard
driver, but unprepared reader doesn't know all the details.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-10 14:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 8:34 [PATCH 0/2] upboard pinctrl support for device id INTC1055 GaryWang
2026-06-10 8:34 ` [PATCH 1/2] pinctrl: tigerlake: add some pin groups and functions for INTC1055 GaryWang
2026-06-10 14:24 ` Mika Westerberg
2026-06-10 14:37 ` Andy Shevchenko [this message]
2026-06-11 7:17 ` GaryWang
2026-06-11 7:40 ` Andy Shevchenko
2026-06-11 8:27 ` GaryWang
2026-06-10 8:34 ` [PATCH 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support GaryWang
2026-06-11 12:29 ` Linus Walleij
2026-06-11 16:02 ` Andy Shevchenko
2026-06-10 14:13 ` [PATCH 0/2] upboard pinctrl support for device id INTC1055 Andy Shevchenko
2026-06-11 12:30 ` Linus Walleij
2026-06-11 16:04 ` Andy Shevchenko
2026-06-11 17:05 ` GaryWang
2026-06-29 17:39 ` Andy Shevchenko
2026-06-29 19:03 ` GaryWang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ail2tWow7VwWRkL_@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=danielecleri@aaeon.eu \
--cc=is0124@gmail.com \
--cc=junyinglai@aaeon.com.tw \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louischen@aaeon.com.tw \
--cc=mika.westerberg@linux.intel.com \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®