mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: magnetometer: bmc150: sort includes
Date: Wed, 10 Jun 2026 13:55:36 +0300	[thread overview]
Message-ID: <ailCqPN1zGTWaua_@ashevche-desk.local> (raw)
In-Reply-To: <20260610042418.90308-2-dennylin0707@gmail.com>

On Wed, Jun 10, 2026 at 04:24:17AM +0000, Hungyu Lin wrote:
> Sort the include list alphabetically.

...

> -#include <linux/module.h>
> -#include <linux/i2c.h>
> -#include <linux/interrupt.h>
>  #include <linux/cleanup.h>
>  #include <linux/delay.h>
> -#include <linux/slab.h>
> -#include <linux/pm.h>
> -#include <linux/pm_runtime.h>
> -#include <linux/iio/iio.h>
> -#include <linux/iio/sysfs.h>
> +#include <linux/i2c.h>

>  #include <linux/iio/buffer.h>
>  #include <linux/iio/events.h>
> +#include <linux/iio/iio.h>
> +#include <linux/iio/sysfs.h>
>  #include <linux/iio/trigger.h>
>  #include <linux/iio/trigger_consumer.h>
>  #include <linux/iio/triggered_buffer.h>

Oh, I didn't noticed this one is mixed with the other linux/*.h.

> +#include <linux/interrupt.h>
> +#include <linux/module.h>
> +#include <linux/pm.h>
> +#include <linux/pm_runtime.h>
>  #include <linux/regmap.h>
>  #include <linux/regulator/consumer.h>
> +#include <linux/slab.h>

Please, make it in two groups

linux/*.h
...blank line...
linux/iio/*.h
...blank line...
"...internal header..."

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-06-10 10:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10  4:24 [PATCH v4 0/2] iio: magnetometer: bmc150: use FIELD_PREP and FIELD_GET helpers Hungyu Lin
2026-06-10  4:24 ` [PATCH 1/2] iio: magnetometer: bmc150: sort includes Hungyu Lin
2026-06-10 10:55   ` Andy Shevchenko [this message]
2026-06-10  4:24 ` [PATCH 2/2] iio: magnetometer: bmc150: use FIELD_PREP and FIELD_GET helpers Hungyu Lin
2026-06-10  4:45   ` Hungyu Lin
2026-06-10 10:56   ` Andy Shevchenko
2026-06-10 13:58     ` Hungyu Lin
2026-06-10 10:57 ` [PATCH v4 0/2] " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ailCqPN1zGTWaua_@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=dennylin0707@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®