From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40A5E282F02 for ; Wed, 10 Jun 2026 17:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781111616; cv=none; b=YOj0xyboHlgk0iaPZNvRc3kmDrazpaonZ0IS222EjygLE3TzXtL2eMnbj3jlJJfZCi/YwAaLRbSHkf9RLkqhXlf0qJHsWgr21mgdCBmlcNKog7lYKQUOqJsmB87KrpVcIbFIAEeibN+uVVxekFlABl3lpWvJc9U2qGsTQ2d8eSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781111616; c=relaxed/simple; bh=7/xcZhoKpwGcZKaMKoiJxd4/lEx1O8tqAlHKlPik40w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CDbzhdNTBxsaygohSe6XO98LGeMfqNNnyduP0A77/26WrCYgug5zgGylwBMDuof9Hm1D/HfalDPWInUWP4CdPCYD2PT3z93qGXyFFtBr4OILNBjyBjvWOoGBUrgh0O4z90cx3oKSuBm7JugDiTMFmCSDNXj2dQbCx1MjMXMQj9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=F4Q4/GBX; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="F4Q4/GBX" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-45e9f4a3510so3573195f8f.1 for ; Wed, 10 Jun 2026 10:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781111613; x=1781716413; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7/xcZhoKpwGcZKaMKoiJxd4/lEx1O8tqAlHKlPik40w=; b=F4Q4/GBXkSLZUOhJWMZvEeXpAkAbds5EQYR05ssiChmJsRlqw/USx8QDhdFOZ4SKYX /H+hlmb+df93egcRYx7UxTIDLP/ANc7MGTEBc3qouLNMtycuzabFw4yIvPH8fKcnVsyj pSToAfYP1d72jydtZpzmucsRPuKmZzhtXu+IrTFviRirwaKji3NHmugEI8DWohrfBxYW Y8VVHGCHctqiidamPwKQYI7e3nnfNbiUhDKAxz5HsXpI0XMfGAtWO1jJTCy9H0wcTgW5 b8kikL+QgKAHXMLOFXlM4783zVj8BVZbTaWnMLr2mw1+d+ShQqKKRfXnJ8ngXwMQRvSv Jxmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781111613; x=1781716413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7/xcZhoKpwGcZKaMKoiJxd4/lEx1O8tqAlHKlPik40w=; b=Jf34UkZcIGAltM2Mh7b/Ig3oV46LlCdV6d6Z6zjvdVrEMDscYYqt5SOZrok01//sgi rNT4dsWtc2i337vQlacsBN4vupwbcIOWrkYlC0lAENra4VoBClOwA3N8uHOTEx8HQkqO e2YBalzT833HL7Ig8GdxnI5KMbzWzsYn7iKxqu01cfrbvY9yc4ANRVKY/r09Mvad4TTL ipJShSaP3V8gmma77OnkD0SrVnJd6du6U7EepS2S81rlMsTiQ8ucPTcaeIUc3os38t29 /pfrEBHF+u0gWNCWVVOZNIPMLiym4I9B1lsdaB5Jvcd3vkXQ1yeiQ9AVa9lVIC4JdmUW 4EJw== X-Forwarded-Encrypted: i=1; AFNElJ+SqPZurK2+FXMWSFNvzfIqjfW8au88r8FNxCG8mI8hDnCX3cGPvrwwROWtQdiIaYHNodn/pP7WSiQxjNc=@vger.kernel.org X-Gm-Message-State: AOJu0YxC20Hh4/qArJV9i9m4PzyzujB8N7zSEtrOoxIjzcSpvgRCEixh DvWaGQyq7ozNKhjC05zwwHRLWkXY60PmGoCOLy/9mYP/E0u6t9iXaO4j7zQuRC1nkyM= X-Gm-Gg: Acq92OE4PHBwRJwcltl5bFLrvBQFVz7CvfCURZ5ROYAhiQG2pqqLcBtn6QdR8WQ5Xve GmYdJBQWKwGzsuJPZepXngGT1N7zpwVYxfNpGcWoV0anA+MsnQf+ox40SaotEgJMPrz/bcNwV2q XPcyxCgmxJwwVVbEMTk7lTNXXQpACtv09ty4SkbLOsleH0p29vP1EOqDdPZ84WSKIrHZY64WVMC gkctVRlKEBtIK1VaURyt2CbVI3TXgJuxKdizD+WDGUzvOwyicAe4ZWBr1WJZaBYoJdhD6Y+RuGE DBgs3rHCDmZ9xwXx+9B9Qf+vV+CVINj4PgXiuFDhS29hsCzZyeaPWuUKWKbtBMHMZ3OTqwJE87O nbKZV9QPHQfAnvTUDcqSEmv0lXYHEMUA2vKGc9nlexX+IvGpISqheUR24K6q4Ke3X+xCUWGvGKN TNZoNml7KpwaiF33NSWjxw41FBk0WiVMo5WWcPIiHmWmS1YEMK/+6aBtkLdWi2HflGclIZI2KRr 1QVUm+DmHguZzNGRXDYivD8yw== X-Received: by 2002:a05:600c:8b6a:b0:490:688b:ece5 with SMTP id 5b1f17b1804b1-490c261b08fmr390154585e9.30.1781111613608; Wed, 10 Jun 2026 10:13:33 -0700 (PDT) Received: from localhost (p200300f65f47db046aec8c3a4b621e71.dip0.t-ipconnect.de. [2003:f6:5f47:db04:6aec:8c3a:4b62:1e71]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4601f2e4b18sm57539850f8f.10.2026.06.10.10.13.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 10:13:32 -0700 (PDT) Date: Wed, 10 Jun 2026 19:13:30 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: David Heidelberg Cc: netdev@vger.kernel.org, Krzysztof Kozlowski , Simon Horman , Jakub Kicinski , Andy Shevchenko , Ian Ray , Carl Lee , Tomasz Unger , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] nfc: Use named initializers for struct i2c_device_id Message-ID: References: <20260518133311.644160-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4wajsa3zx244mfzu" Content-Disposition: inline In-Reply-To: --4wajsa3zx244mfzu Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH net-next] nfc: Use named initializers for struct i2c_device_id MIME-Version: 1.0 Hello David, On Mon, May 18, 2026 at 05:09:54PM +0200, Krzysztof Kozlowski wrote: > On 18/05/2026 15:33, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > While being less compact, using named initializers allows to more easily > > see which members of the structs are assigned which value without having > > to lookup the declaration of the struct. And it's also more robust > > against changes to the struct definition. > >=20 > > While touching all these arrays, unify usage of whitespace in the list > > terminator. > >=20 > > This patch doesn't modify the compiled arrays, only their representation > > in source form benefits. The former was confirmed with x86 and arm64 > > builds. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) >=20 > You need to refresh your tree to next - you miss David. @krzk: Thanks for that hint. @david: Would it help you if I resent this patch or do you have it on your radar already? Best regards UWe --4wajsa3zx244mfzu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmopmzYACgkQj4D7WH0S /k7Xzgf9Fxyi6laW4HqGp9U22Qti2JfXd4MYYOfISvcfOj/0RvVQ67QtRSlejhxY OSZx4/tqeNeWLxFcT7kfmjZF/iEbcHD/rGthcf7GPKNjM8TcVVJxK/O8Av0XvZD4 f/lw285dzS9V06C5C1DK5SX5Jh4Y/Egb3x4R3pCXaWo+s60WvgLkr4M1aRLCm8NE dism62gmIOWcyJxRdIuhXaZaXlsmDIkTsRm7A4ipH3fnYmgaSkaf0w8LyYcDu34A zrORh4OM0gK2ehBNomvlyTDDKPEwHkuldkI2VX6arXZaIddlvKHkGk+uFyHrtu/O lM3Pm/KGXYohoAT8U53UqFXxolA8Pw== =VaSC -----END PGP SIGNATURE----- --4wajsa3zx244mfzu--