From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B757344021 for ; Wed, 10 Jun 2026 17:22:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781112122; cv=none; b=c/r2IOrnXodMkg31ZUWr2hxyP8xonAgssus5JeHZSPtxsn3+GpRSqAZMYqPE+zrTI+ivtSvrHNz9v4SkcOUFK5+MU8TbdxQhy8DsiRoi3ASsh58DlJ7AZosatvmg1ud7xBJXGf9RdXJyrk56I8O3bTbt4nQYaT/NygZg9U1LC6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781112122; c=relaxed/simple; bh=fWuJGajOnWs+3KfrXV6XAqZHi2JSpT3v3CO6vOGazIA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oofmM4qjd2KfLNAz1pvOY2TdyeUAYV630dWuVl0v6EWje/pBW0yzooC1waGpoLieu7LXejq8dE6YJRNdkRK5lVesE9DX/RUsmMiARuPv394V39gd6TeuA6TsR8044OgSf94i+u6mC7YhI/AmWBUaOq0fUFhd9eL/N9zziz3vuXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=pzUYZ1HS; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="pzUYZ1HS" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-45ef82204c6so3945948f8f.3 for ; Wed, 10 Jun 2026 10:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781112120; x=1781716920; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fWuJGajOnWs+3KfrXV6XAqZHi2JSpT3v3CO6vOGazIA=; b=pzUYZ1HSGgkTWAg1hUxZiMkLCeiwxpdOLiP3IGbQkWiRnwLqXSrwdIM5IzOLjuNs5I IVdPn/gfJpyTrhWgXdpd5wV1u72CpZg4fw/6MgVL7WZfw2Gp9R4MTkCvJN+NCpBvMAPx BdHubVDufMAJHNdUBoEwiriqlQuk3mz0z0/dBKxbP/vSTGWkBKl/LSV/qWl8VBaOBmX4 2ypA7I5U9j9l008YFLcQRRNQb6zxU8dEP4H+B28+AFK1CWFOB0jKn2O+OCCmBEx6xHiw 5iSEBeqBVZ9jR+1j8GanlnXa+gxtQfP58E13GkHIjUa2i26C1yZiR+FuIinR/B4x2y23 HQeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781112120; x=1781716920; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fWuJGajOnWs+3KfrXV6XAqZHi2JSpT3v3CO6vOGazIA=; b=LlhpGui32mk8earZ8C9HYDsULARpeVEchiU6xVdDUbABtFZ4kYNVoZ+jCUBId6hgvs NV/S7N4MktTQAcqohZ+9qsej7HZ5BQ7xqZXA3vfTyKOyodH0JCMHlxpourEp5laQkmBV oxI1uHNmS+hkewi3X8dFhMQdskhMlL/h4CnlNHxI6qxNSUCWJ8H2m5QcouoPsapKGcRn XAJVfH9dCgVspz4mq5oFmLtPjtknznCBZLIvZBXsVYDc+zWJrfhmDJuf0oO1kF50MEtJ w0ZVKwKmKBsaaEOKuAnXzuwJRV8I5VYGJOYXHPYmvIqNt1uM2Ul4P8U4siiGlimZZ9f4 Za3g== X-Forwarded-Encrypted: i=1; AFNElJ8n6rAUA+e9YR5ce0x9Ir/y0bnXyZCol5soDu7Kp+g0FZ2KyJzkVISCPsTLTXtewF9A3YyubKnqMhIQQ5Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwAEjr89+BZXbSYpOUIIVFoK5O2oGzNELEVV8jtEwAg30GAvyUE G0x+bK3g9hPMbKDC7yo/3bfbBkYmoUUmAmrXTL+Uf/Kece6hafvmkh7oEveOrPAIpvE= X-Gm-Gg: Acq92OH0DXMDBAt+KrrCIkxgZ9XCWVeS8APxuQOa/Hcnn2fICqajWpUkiBuj72Td/rJ 3g1JOKsYCjjakzUxBSaQmhBQG/2pen1IKdsQH6nZPwcHCpSs8gbq59hMtdNanSw5ACpLR+dIXq/ r91J1dNr4ENXfS/yJN6X+JsxD/kUUJdJesyb8wNjROYBLI1zdBAMjNsywnc1sNGXSTApUM76GFZ TDZGXa6DYM2cao0/1dM5vPGw5flFnzgtgFTZgdkBCW9vkSqQbaekda8Djd/al9MhYM9YuZTUoBd IZxsF/fJ9w5JrCx7+z4SpeRZ6a7OKftRMXBLxGc3vtpgDfZKwsDgo/d9Cpcm3tK+zZAWxWDcQ/K 9RwqJC7EGfN6uiFy0XZroTGzzHtPydF0vrjt/oF6pc9kRMDXv2/xNEGKbO73kg3ZKloiYLsh1ct eLrfK4rqMNyV2qXwqme6wcg3rxZs0oG2VUvpHQz3ND3060l7lb53F7m/TVBCMB2K5Un5TKCbk1k 4kLwjEZ7ZUVXwcXcI7qKUUBrA== X-Received: by 2002:a5d:5f83:0:b0:43d:7b90:fa23 with SMTP id ffacd0b85a97d-46065bb858emr214196f8f.29.1781112119645; Wed, 10 Jun 2026 10:21:59 -0700 (PDT) Received: from localhost (p200300f65f47db046aec8c3a4b621e71.dip0.t-ipconnect.de. [2003:f6:5f47:db04:6aec:8c3a:4b62:1e71]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4601f2f2710sm57444222f8f.14.2026.06.10.10.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 10:21:58 -0700 (PDT) Date: Wed, 10 Jun 2026 19:21:57 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Vinod Koul Cc: Neil Armstrong , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] phy: nxp-ptn3222: Use named initializers for struct i2c_device_id Message-ID: References: <20260519151957.1593214-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="th3rlw6cxgi7cv3j" Content-Disposition: inline In-Reply-To: <20260519151957.1593214-2-u.kleine-koenig@baylibre.com> --th3rlw6cxgi7cv3j Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1] phy: nxp-ptn3222: Use named initializers for struct i2c_device_id MIME-Version: 1.0 Hello Vinod, On Tue, May 19, 2026 at 05:19:57PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > While being less compact, using named initializers allows to more easily > see which members of the structs are assigned which value without having > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. >=20 > This patch doesn't modify the compiled arrays, only their representation > in source form benefits. The former was confirmed with x86 and arm64 > builds. >=20 > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > --- > Hello, >=20 > this patch is part of a bigger quest to use named initializers for > mainly struct i2c_device_id::driver_data to be able to modify > i2c_device_id. See e.g. > https://lore.kernel.org/all/20260518111203.639603-2-u.kleine-koenig@bayli= bre.com/ > for the details. >=20 > This patch here isn't critical for this quest, as the driver doesn't > make use of .driver_data, so apart from the better readability this is > only about consistency with other subsystems. Given that this patch isn't necessary for my onging patch quest, I don't care much, but I still think this is an improvement so it would be sad if this patch wasn't applied just because it's on nobody's radar any more. Do you consider to apply this patch? If you don't like it, that's fine, but then please say so, then I drop it from my trackine. Best regards UWe --th3rlw6cxgi7cv3j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmopnTEACgkQj4D7WH0S /k7H2Qf+JPOXF1R65QTsmv6cAcIlhp5yP7AlbBKZMIW31b/MtnXDedGdYabELVV3 Job9YGFBjl8Ugj+y87cIg2E9rOQAQB0uVm/Bow/1mJw1xEwAU5rFXnm0c6QN8fJP mn2ZpI3IiIjqkFcQgcO7IlP6bfWQOMltKmDxS8RFNb26XjT39mMaoYqo0XeYmpw8 O8F6FR+IG+39e8VzCcgjVpUVH/ltod0xXztIVX8je5S0wcfTjid2G7Nlc7DX3X1f FsBjtZ6pGV0YvLwNpMMgVrsq3l6kvEmGvKK7S6Vx4NYYpa9nBAIto1Eq8LHwu6Wg jd+P9RF8Jhq3EK7buqCUTdqCzE7izg== =KjFy -----END PGP SIGNATURE----- --th3rlw6cxgi7cv3j--