From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3826279903 for ; Wed, 10 Jun 2026 17:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781114297; cv=none; b=hmLe0zoeZlEUfG7/CZ/5vsxJp2/4jWmbrkEHLqZGNM808KdtNlA3iBQbDH9432lOasPNDU8V+O86+TkNdxivbPNjLmqSa1gZ7PHuMXPqvsQSIsipP03UrpRCJfUgJUcYwd+9gyTfvIc1oedfc/v8mI9CSQxYdX0nH6ujx257zdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781114297; c=relaxed/simple; bh=DiEo+/bq8ErrnBnt4nPE9U123/wIPQRXBvgM8yxpiRo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B3MbJTNknVqO4PQN0yKwWtI1JSvHrPQVxovfWUXgdIoDgprMKQ/BxbAEgELtCs/BXQDdHOsqLKPF78K8eqFVhI2DaSCfMv+ckM3jILTqtCT2bmxKC1k1qWaDcQJkctKr7lML+m/XeU5XbKiWLUC1MBXHkIp/pcjWXGRGdb8IW68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GjY5cGN7; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GjY5cGN7" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490aaeabdb4so46496825e9.1 for ; Wed, 10 Jun 2026 10:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781114295; x=1781719095; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3avyTluAk283iBEga6wGPVoycf0Awj4BxU+6wyL2mC0=; b=GjY5cGN7ou2yfRyQ41eAQ7Z7N03FLBFMGgEAy+DhN0ouFqI/A6gT4khKZmQVmKUtIL DV5VoqyIrO4MEBC7Aq8suZgNzPbchhj1ufR5/uebsFcQqwPNQYE5dqDBAkENzfZTkDwE YflnOwzRSdt4TjbK9hVN292GCNwbDZ05tqZzlxwEcRzjEcahJ71b27x7oLaRiAAum+H1 4P8uQSyfbcy1TCePpTMm5JI+z0Aq+Y0MJuwSaWaUU/+NpyBzE4yOvlk7IEQca6cjoXgG fDVVrok86/SYgRcUIWzxYDXc1HtzwrxgBwBgiy56e/hMayAPkN6i6JHYswFtdSsBwN9f eTdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781114295; x=1781719095; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3avyTluAk283iBEga6wGPVoycf0Awj4BxU+6wyL2mC0=; b=H+IoZkZ5AVjMw5IUumzCMZUS3++rTEj7IoVvuIDlfX2+zwsGXAloOfWRxOWccFc3DF OKxCSSM2rj/6F8A4ioX5Jxu2cZmtBgrvpZ37mnbWwgXRM/Gx/6Gv284x1Ujo0IXqQ6Lb nmdChm46H9QOltPrl6y7fyrIVkGUEWqasIW5RCHhHv93kLGmGg+Bhjy2rlNl5sd1RQ6o TiD10joaz/KyxKpDOws+IxVU7dxx4f1pD4F72xouvQ4iUu8+1MbcNbx6azqHKgf2RxvY NRZnbSfNCaaihENg5qNHoo8UJfw0gt3nijyx+FVPLXlvwVddKvmbZmmlUpBNjGwE8U1b PSbg== X-Forwarded-Encrypted: i=1; AFNElJ9D8fzsRfWlMEE1SvvBCbbh0OhEXIDS7VQGOzV8nHsCfjfszXGfyBfQGKJuW6YaD4nmAvbUgqlUR8WzLu4=@vger.kernel.org X-Gm-Message-State: AOJu0YxRmEJcyqyimIRXf0PLrpncqBTTA4Gzsqk7GKA9OG72xeAuxSYO ltDzI1SqguNhSGYpvT+rjE4B/P/tSpr76ay6g6TkPo/HRt3xbIVcmk75lUOCeq6PmKEEfJXB3S9 YgZPAbSA= X-Gm-Gg: Acq92OG1StmpG0IpiSYHKj0szhW75tLQaNIxbwzaMRxDsD4mlCqjPfqJH33IbBxakVx ExUyfawbvgYZTZ6iVpB4I9YN8M/fTDPtflzhI+hy/vrRHHWUjhzWTZBMHib1rkVtrZJ/g4xu6t9 t//3bPV9liYoK8wvf+nZFdU7yhjUixPw1AYw3FqnEdSq2rGOSRP9+iaOGxKYunJq0lcULxYWyPb oTN4vhb5EaYm5b2OUjFQzIZwtyjQQSK6CuLTGPKKU13e1hkF1W5nkP7+1OaUZzQDswAHDk6Vp5L 5dqliDW3Z5t6dtb6trYB0esM61B/NyKVJ1YqqX+BxB7JN7NgnDWmGEXTdkwuxybKT1UZu0a19By pwEdNsnEIp0DfV6+ljtv4scx+xVwXUu355LBFiM/RRmbzfQJIVjflXcsi+4QDdOr9cGKRbMGY+x 78GV4KqnfgaNY3zTqEUo1j9svU+OVWbeUx1uIv4OEQ9xbn X-Received: by 2002:a05:600c:1d2a:b0:490:bbc1:d508 with SMTP id 5b1f17b1804b1-490c258f3femr428587595e9.1.1781114295096; Wed, 10 Jun 2026 10:58:15 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff23:4410:f160:c480:bee:c914]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490dc471b6dsm63912895e9.0.2026.06.10.10.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 10:58:14 -0700 (PDT) Date: Wed, 10 Jun 2026 19:58:10 +0200 From: Stephan Gerhold To: Taniya Das Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Georgi Djakov , Shawn Guo , Bryan O'Donoghue , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 04/12] clk: qcom: gcc-mdm9607: Fix BIMC PLL definition Message-ID: References: <20260609-qcom-clk-mdm9607-fixes-v1-0-5e9717faf842@linaro.org> <20260609-qcom-clk-mdm9607-fixes-v1-4-5e9717faf842@linaro.org> <022fb465-df10-4d95-a05c-1ff8e59558c1@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <022fb465-df10-4d95-a05c-1ff8e59558c1@oss.qualcomm.com> On Wed, Jun 10, 2026 at 10:43:12PM +0530, Taniya Das wrote: > On 6/9/2026 7:44 PM, Stephan Gerhold wrote: > > The gcc-mdm9607 driver was originally based on gcc-msm8916, but a closer > > match nowadays is gcc-msm8909. Looking at the differences between > > gcc-mdm9607 and gcc-msm8909, there is quite some confusion around the > > definitions for the BIMC PLL. > > > > It turns out the BIMC PLL on MDM9607 is actually an Alpha PLL just like on > > MSM8909. We can vote for it using BIT(2), which explains why BIT(3) was > > used for GPLL2. > > BIMC PLL is never controlled from High Level OS (APSS). These are > controlled by other subsystems and voting should be via the ICC for BW > requirements. > The driver doesn't really control the BIMC PLL here, the PLL is defined with fixed/shared/read-only ops so it mostly just exists to model the clock tree properly and have the clock rate readable for the PLL itself and any downstream consumers. There are multiple drivers that do it like this (e.g. gcc-msm8916, gcc-msm8939), is there a reason why we should drop this? Thanks, Stephan