From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B64B334D4E2 for ; Wed, 10 Jun 2026 21:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781125734; cv=none; b=uVDhQA/jgxOAM+RpEvP/aOa27y3Js88MLpT2+qqpkr+luxzYNIt6CNnIK6njH4oFD2Isy5NwknPwamgWy1OP5tsWiUCaGLp2a0gHYa4sUYxJTDMibazEBzpoFmv2xrH6uVMU9j+ZUUX6poxoil4qXz0LjyLn1xbOpd99117g6Dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781125734; c=relaxed/simple; bh=Ig2OVt3TBv7ddvTUNvfJSFZLo8RWweuoGZlGh1vDWos=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JLrBz9K9WAAwdF1wrh4Yi7uUpiziS3rpaJs1nap3deDgd/gtuX1RGuZftEHP8izObm5RN6jaSc/0iVV34xKACjgaJ6Q0UYnKo8y07VpPViCS3GUuJS4OvJAevza4OAXYRxazwAkZ6OBneXNqKgNC+m28yRwb3F2xuBFgkOmwU+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=ESC7eG0/; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="ESC7eG0/" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-45eeba68948so5205668f8f.1 for ; Wed, 10 Jun 2026 14:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781125729; x=1781730529; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ig2OVt3TBv7ddvTUNvfJSFZLo8RWweuoGZlGh1vDWos=; b=ESC7eG0/h0wcL/pgHYK9IZYeVLZLimwgp7TKxUs3J60QKyBa9EpnO6n4UAg8ikSDNS wdplRVodOBZewazj9JO1fDLlxZLmB1Zw5vpokf0+F2cnXy9oo49O9CDAtKmqgf0gmodF A3T08vktkSul+O38SljexB+Xitw1WxBfqKDnkSiBfMvXcS0HaUoHJ94EkFaBA8URJ+Qt 7s5NkD82Afi1accP0FRP8b2Qx7Vs0G1d/jAzhrCQqysepDJfJvE159ifmGgGOiOq6dhh 96vSZsK1sX16au7lJOs+Mh6kCkAniIJrxOdaAIM+jHJx+TD+1wLX5Pl6OmLyGByPVj8M 9Y/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781125729; x=1781730529; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ig2OVt3TBv7ddvTUNvfJSFZLo8RWweuoGZlGh1vDWos=; b=ODz83EYmquNn836JYJjOqfdKTX/Z7xivkhMa+Tv7tGZXJSYzsWL6V2g3DmrOv5nYBb co8O36iR67snVUPGpsrSnOGGTqf8T1UxyrvDTcube8TsC68YGQOH952oSz5zBm/1lN5o +EoTedCiAUpgsHNoh/pjq1S9kNZtF1k72QxETwbNw1tfpfw7lswIrvzBo7Ezk/hHXgeH zQGydjJTBVslbWof/HRlbGlp0xHPiyWRiFP8GYD49kFkos8nsTokddjO4qujfNyAD9GV H/rD2Q2ggjPji8KlxstYIhQqIGcisRRUhIIBDmKMOfO0bHhxqBK2XZQv1aqDmObqdElx /w8w== X-Forwarded-Encrypted: i=1; AFNElJ/846UiPti5ReynyTK1qkJH0BVebghFn5bouJ+ogwE47w/Atik7S2SzME+ib4Qqg66H5xC79CNUdbbK5n4=@vger.kernel.org X-Gm-Message-State: AOJu0YxYEN43OaEKTrHpYh5gwpIIvXSDUhN1mqThN2/0D0QH4WYjy2Am 5hWTGMsGVRsqYgGDfgyWXPNnJ/q259LYX9Kcqb2rNyCKLi3ivBWKh5BYdJ4pZ4CucJk= X-Gm-Gg: Acq92OEu2CnXEmbW3CRJzqzIi8C1xYTsYGmwzxwaL9hHuZbmhhHEz3SXQkWJSTGaEzs 0ZRKmYks4rEHpgHk2P7XlNc5mu5kf/f6bLW7m/CGj8C2atSs+rVtbmFNTzqTb3bOUdAlR3q8Kgp nn8RLKz4lKmmO1uCPM+6b7tSMetfQhtq821I6y//pCqI9SzaDqDOyVTE/a83hXp+FrsljzwEQ5b kv0qw/gwjWfSNRlkrh6mJsBuC/4c4eI9lbkCelgYzeVebgvBZeDVL/i5307Ut0IE0pvz46vyRlJ flWHHIjOlzYkctio0LCKkDoZrxru0zh8xFJ7v2LiQUoS7vVNlu6VQh29cQmyfUib4qGAOOOxL33 c9JTh+pAhieSgG+jYV+zWMCj63ZwVMczd+2v/gstEfsuzdiPdjFUOttdSGnQoFF+R4kkNj6Sw+T FgHUmOL2wHTuBOGYR6BAgbnaGnZzoTiJ5rnHyU3xk= X-Received: by 2002:a05:600d:640f:10b0:490:b7e6:bd1d with SMTP id 5b1f17b1804b1-490c25e30a2mr298781385e9.16.1781125729131; Wed, 10 Jun 2026 14:08:49 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:559d:eec2:887f:c200]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-46028a6dce6sm67341274f8f.30.2026.06.10.14.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 14:08:47 -0700 (PDT) Date: Wed, 10 Jun 2026 23:08:45 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Luiz Augusto von Dentz Cc: Sven Peter , Janne Grunau , Neal Gompa , Marcel Holtmann , Markus Schneider-Pargmann , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Bluetooth: hci_bcm4377: Use named initializers for pci_device_id array Message-ID: References: <20260504160940.2168650-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xqdkuhrraxjetghb" Content-Disposition: inline In-Reply-To: --xqdkuhrraxjetghb Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] Bluetooth: hci_bcm4377: Use named initializers for pci_device_id array MIME-Version: 1.0 Hello, On Wed, Jun 10, 2026 at 01:13:44PM -0400, Luiz Augusto von Dentz wrote: > On Wed, Jun 10, 2026 at 12:59=E2=80=AFPM Uwe Kleine-K=C3=B6nig (The Capab= le Hub) > wrote: > > > > On Mon, May 04, 2026 at 06:09:40PM +0200, Uwe Kleine-K=C3=B6nig (The Ca= pable Hub) wrote: > > > Initializing a struct using list initializers is hard to read, compar= ed > > > to that using named initializers is more ideomatic. Convert the macro > > > used to assign values in the driver's pci_device_id array accordingly. > > > > > > This change doesn't introduce any changes to the compiled array on an > > > x86 and an arm64 build. > > > > > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) > > > --- > > > Hello, > > > > > > this is a preparing change for making struct pci_device_id::driver_da= ta an > > > anonymous union (similar to > > > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@bayl= ibre.com/). > > > This requires named initializers for .driver_data. But even without t= hat > > > this is a nice cleanup making the macro better readable. > > > > > > Gcc is happy with simplifying the assignment further using > > > PCI_VDEVICE(BROADCOM, BCM ## id ## _DEVICE_ID), but this is a bit fis= hy > > > because PCI_VDEVICE also assigns .class and .class_mask (using list > > > initializers), so I didn't convert that. > > > > In the meantime I learned that doing that would break W=3D1 builds, so = it > > was a good choice to not go that path. > > > > > Once all pci_device_id use > > > named initializers, the two zeros can be dropped from PCI_VDEVICE and > > > this entry simplified accordingly. > > > > Is this patch still on someone's radar? Ideally for application in time > > for 7.2-rc1? >=20 > It is no longer in patchwork so if you really want to get in please resen= d. Instead I unarchived the patch, so it appears in the patch list again. I hope this is easier for everyone (it is for me). Best regards Uwe --xqdkuhrraxjetghb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmop0loACgkQj4D7WH0S /k5XeQgAoTcuZnjClD8CBiVzulCVvCVSkCfgQKHapo9L6hikgCrhNsvTOvHMFU6S XDZ2dot5rGjM/KAYI0h8FHaXTdH36OKmbjykaiP+DIFuHS7VkpWcSc2EM7hAvZha uGcJCF4xyc5CyNPElG/wDPHJdL2fJPJkKUjMeDiFSnU5qRg4spodg9e2dD03Hrap 0D0yH2F9jcYbHNC851gjYuJ3NvrJEHijOc8vg1Ylw8+9LsQDrt76yI2uffzB8/6n /CFEgnnByMZObzRw6oaxYc9jXkjK+e7oiquz56xyx0c3SqFOlMrBPo3Zj2G9LIRM UFLkgNRU51FxahnG5mJuKv98enwHMw== =zDmy -----END PGP SIGNATURE----- --xqdkuhrraxjetghb--