From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6390237D118 for ; Thu, 11 Jun 2026 09:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781169596; cv=none; b=IRkfBfE4MivqJiCokCg95/1gkBxsPNIB9+JV3kmOtLSS586o6MCyXKfI8Ylas0dc+eVgCobKSz/wi2AP0ysbSEXqfdVzPpcMBhHDk/S7+VeW6q7aFRTmZ+f6AElr9pgmzET78NqYq1DODEdzwqbrC3ADMDZWldL09jxEMq4cO6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781169596; c=relaxed/simple; bh=ajXZQKlUQjfq8KP8zbjST5yGUA03a95kKBL0PDELn/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=awXhkPk1zNZW+CxXGpLQd0eDa2ZJqVgGYxpkhs2mCWFYWjBjTJP7+UX8rHvCzCCJIjjHPWf1ckuNLykH3uKIQqVbyEKYWj3i/B44YZG4lKfqG7WnS567xwmYkxtgmhyE380FWRHCVxX7k1B4R9dXPMQioghb/+3DAdRul0wiC9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o8CVxgvc; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o8CVxgvc" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-8ccdf8d4ac5so82111376d6.1 for ; Thu, 11 Jun 2026 02:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781169594; x=1781774394; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EikgnS3vF4jqNMcBcK4JJO0h4MFVBm6MQacJ2h8Nxpw=; b=o8CVxgvcyZuL9JcxeAdnxLOkk64ySytSg9XWUzqVUKuZouoMb9hUJR8CzdPMl7qBm2 pSYS1gL1emCVtUY/hwcHRBX9i46FLRKow2G/ksDc28JeZEP8wvogPyR+s9/6oQcy8jvF 5+0H6tLUWAVEqL1baOiMh8L3hS8LX4ad48QMjKwLPnRMBFdLq9vnPLG0xNxfdaWJYhA6 QiJe5x2L0p4Zs6LyX6F/I5RVcHf7AP4IN7/i8uCsSzSzVFLb5f1y76kf5SBzT1heHfFe da0psJY+axLYyMnPPK9+ng9fUn7IDkcT3bi3StxvJ3TAGSOySXaGe5CqiB+M225mkFhf 8d4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781169594; x=1781774394; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EikgnS3vF4jqNMcBcK4JJO0h4MFVBm6MQacJ2h8Nxpw=; b=Yo8ctCX3DuEwuwIpqJdaiapJ0KHu/h3oMvIjGW0ph/BfCd6iSs3U+JriIoBM7FaX6V i6edWtIH9y5xRPyDEyoyvusNm3QGCadGCFcgurWtxYqLPH1CyBuZeGH7wUCRGThYBD/1 wZE4MNtX9zENUqer0HmC3U1i1hQd4dMA1UJDR64eNF/+wbq3CdWI74VANciFm53tvUCa CJHMqQneXfcwOV1qlCSjj4su6eylxJChF5wyKH0jTiZjo0+cxGV4I6vI0+0/SLYdoSa1 cqgeo/0DvKHdv/M/2kmnf5AZYboNGU/m44T8YOyhKLDO8TNytUTH5mNlUWzoVnx4bVBQ ACIA== X-Forwarded-Encrypted: i=1; AFNElJ/OP7qqCPGL2OBlQq71NBUdLYzKUuORRvlG8OIT0ujCGGzAnOpffynFM6JouWeBojgQSR2CAtGPRDt/Axs=@vger.kernel.org X-Gm-Message-State: AOJu0YxQIRLKIuAFgatzvtUf+P9bn6tKictX1U8vcZWJQlINrsy/aDVo SOLk4yKA5sNIpUMmwRrtiVnxY5hlHxm2kLAh5ZvwXkRejTPPg7vdCCbA X-Gm-Gg: Acq92OHb6CXWc5hoo9GhFfLX5Ck58QHn9xqjvd660fnlINCvwOJ0IbMsL6ZUBLhAhrs 623U6t8rEC/PnC7z1u9M2ZYVrIlO5pUxeWJxfBLb3Ur0jzzPQ5VK4ThRmJwLRfR2SBfyKYipsY/ iTLHNEIAVuEknGUXhII5B5MOPso807aZ7rsYEG5YQAKnMq+nYExk4s8TYF6oOiRQUB0zBHrtZx5 egQXXOQvYbeDNSQUkKRRU1+tfaLoPVBUCPrfbuFScfYykrXzzD62G7xeeXnU8Kptp96SsI43y3N cfMaAsnYyhk1DpAPrWOGKm8Mio+0YkRWX29fPLmqZa3+UicJW5v910B+d5/fXUYhQ94eaH3lEOo V7BY+Dxil9hvqbEgEFuaF5aALLLQ4aumzX9DlfFBwUgoBExlQGmYKZPbV8Kom86OZBG3DUW0AzY qtgMivMLQ7ArM3mYEFHSAtVIHWV8g= X-Received: by 2002:a05:6214:20a5:b0:8be:3da0:bba7 with SMTP id 6a1803df08f44-8d1d8726fa1mr30343866d6.16.1781169594344; Thu, 11 Jun 2026 02:19:54 -0700 (PDT) Received: from localhost ([149.40.50.215]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d1e819f58fsm12933396d6.11.2026.06.11.02.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 02:19:53 -0700 (PDT) Date: Thu, 11 Jun 2026 12:19:48 +0300 From: Dan Carpenter To: "Michael S. Tsirkin" Cc: oe-kbuild@lists.linux.dev, Eugenio =?iso-8859-1?Q?P=E9rez?= , lkp@intel.com, oe-kbuild-all@lists.linux.dev, virtualization@lists.linux.dev, Jason Wang , Cindy Lu , Xuan Zhuo , Stefano Garzarella , linux-kernel@vger.kernel.org, Laurent Vivier , Yongji Xie , Maxime Coquelin Subject: Re: [PATCH v3] vduse: Add suspend Message-ID: References: <20260610083452.477759-1-eperezma@redhat.com> <202606111115.tKKe1qCE-lkp@intel.com> <20260611050140-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260611050140-mutt-send-email-mst@kernel.org> On Thu, Jun 11, 2026 at 05:03:24AM -0400, Michael S. Tsirkin wrote: > On Thu, Jun 11, 2026 at 10:18:51AM +0300, Dan Carpenter wrote: > > Hi Eugenio, > > > > kernel test robot noticed the following build warnings: > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Eugenio-P-rez/vduse-Add-suspend/20260610-164534 > > base: next-20260609 > > patch link: https://lore.kernel.org/r/20260610083452.477759-1-eperezma%40redhat.com > > patch subject: [PATCH v3] vduse: Add suspend > > config: arm64-randconfig-r072-20260610 (https://download.01.org/0day-ci/archive/20260611/202606111115.tKKe1qCE-lkp@intel.com/config) > > compiler: aarch64-linux-gcc (GCC) 8.5.0 > > smatch: v0.5.0-9185-gbcc58b9c > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > | Closes: https://lore.kernel.org/r/202606111115.tKKe1qCE-lkp@intel.com/ > > > > smatch warnings: > > drivers/vdpa/vdpa_user/vduse_dev.c:577 vduse_vq_kick() warn: inconsistent returns '&vq->kick_lock'. > > drivers/vdpa/vdpa_user/vduse_dev.c:1302 vduse_dev_queue_irq_work() warn: inconsistent returns '&dev->rwsem'. > > > > vim +577 drivers/vdpa/vdpa_user/vduse_dev.c > > > > c8a6153b6c59d9 Xie Yongji 2021-08-31 562 static void vduse_vq_kick(struct vduse_virtqueue *vq) > > c8a6153b6c59d9 Xie Yongji 2021-08-31 563 { > > c8a6153b6c59d9 Xie Yongji 2021-08-31 564 spin_lock(&vq->kick_lock); > > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > > c8a6153b6c59d9 Xie Yongji 2021-08-31 565 if (!vq->ready) > > c8a6153b6c59d9 Xie Yongji 2021-08-31 566 goto unlock; > > c8a6153b6c59d9 Xie Yongji 2021-08-31 567 > > 9c4307e82fa1dc Eugenio Pérez 2026-06-10 568 guard(rwsem_read)(&vq->dev->rwsem); > > 9c4307e82fa1dc Eugenio Pérez 2026-06-10 569 if (vq->dev->suspended) > > 9c4307e82fa1dc Eugenio Pérez 2026-06-10 570 return; > > > > unlock before returning? > > > > 9c4307e82fa1dc Eugenio Pérez 2026-06-10 571 > > c8a6153b6c59d9 Xie Yongji 2021-08-31 572 if (vq->kickfd) > > 3652117f854819 Christian Brauner 2023-11-22 573 eventfd_signal(vq->kickfd); > > c8a6153b6c59d9 Xie Yongji 2021-08-31 574 else > > c8a6153b6c59d9 Xie Yongji 2021-08-31 575 vq->kicked = true; > > c8a6153b6c59d9 Xie Yongji 2021-08-31 576 unlock: > > c8a6153b6c59d9 Xie Yongji 2021-08-31 @577 spin_unlock(&vq->kick_lock); > > c8a6153b6c59d9 Xie Yongji 2021-08-31 578 } > > > I think this is fixed by: > > commit e4a249d15eb2d4b28213bebb1eefaf2e6d99de0b (HEAD -> vhost, linux-next-vhost/linux-next, kernel.org/vhost, kernel.org/test) > Author: Nathan Chancellor > Date: Wed Jun 10 12:16:49 2026 -0700 > > vduse: Fix error around jumping over a __cleanup() variable > > right? These things haven't hit linux-next yet. I found the email. https://lore.kernel.org/all/20260610-vduse_vq_kick-fix-guard-usage-v1-1-0ce02c08006e@kernel.org/ That only fixes the bug in vduse_vq_kick(), not the bug in vduse_dev_queue_irq_work(). I don't see a fix for that yet on lore but I may have missed it. regards, dan carpenter