From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE63B1F5821 for ; Thu, 11 Jun 2026 07:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781162433; cv=none; b=ndOjv4sBWSwO0PLoCMgoruYCYzm9IfrXTDUoa1i2DyE6HICjbITdiKn3Ltb8qbdSZlvMJ9CYC8u39JbZnPRuglG+gU0sxcZCt3FPQewvLrINPZvjMmcTSaBf0S5mP688Pktc0o8s+r2QfQYKj80Ch5emCJJdT4z1Z+pxWOi9LZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781162433; c=relaxed/simple; bh=kw59dLgGZCCUTD4kZX5EpuRs8qXPLTvQ2fO8q2Ll6Q4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hIkJ1piVm0ynIjP2BKUEm+2JSf3vMVJ6hrj9YdIw2ppdPP8cDE7CNYg3fTXhT3fIhf0c7NjT+iQFqC/vgoCirlo4kRuYUnSHd4R3+/YiTXACHXsnoePvWsytqkfkvwDQxlFhbeN2CojM/b+bzOoU3wewu5oVOZx9ciK80LKCNC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=m4IREfZS; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="m4IREfZS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781162432; x=1812698432; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=kw59dLgGZCCUTD4kZX5EpuRs8qXPLTvQ2fO8q2Ll6Q4=; b=m4IREfZSm6H0J8I4gRhK2rxm2dJ9vWST2yXGvtUkuC8g/vEIHhzkkqmG bPiEDV1RB0V2EsvoHZxqIOqZaKFjaK7VQytA8ltA7Vtdq5yQ0b9bVFnuC SwRGOx6dCSbWoEtW4Dij124mX6GkWtdvaNFo3YIj2uqiFn7AsTO5Q37Jv u3ammBmQsAtJGZT12qygnUQE1bZlvYlyc6O4cessfeWUBT/pgDOA73Sd6 hNCCAPBmwOp2Ie8dHOba8d2go9Hq01Sbb8qb4mDbH+CNVgOaHClXmjkbT blCxKXbBmfUsWurVBcQbzmoyr3Naf8hJtiIopBxz9Z9dmEK1AnVkooF1D A==; X-CSE-ConnectionGUID: g6a414MJSY2LYtFMT5NQ8Q== X-CSE-MsgGUID: b2LXH5ySQo+hqY0Q4Ye9Rg== X-IronPort-AV: E=McAfee;i="6800,10657,11813"; a="82076906" X-IronPort-AV: E=Sophos;i="6.24,198,1774335600"; d="scan'208";a="82076906" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2026 00:20:31 -0700 X-CSE-ConnectionGUID: dcHUe0R8SSGsYzKVGW+peg== X-CSE-MsgGUID: PKvEnw2+Q9mEx7Tt5mqzuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,198,1774335600"; d="scan'208";a="243457089" Received: from ettammin-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.123]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2026 00:20:29 -0700 Date: Thu, 11 Jun 2026 10:20:27 +0300 From: Andy Shevchenko To: Kaitao Cheng Cc: Andrew Morton , Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Muchun Song , Kaitao Cheng Subject: Re: [PATCH] lib/vsprintf: Make no_hash_pointers take effect early Message-ID: References: <20260610124525.59110-1-kaitao.cheng@linux.dev> <8047d447-8d5e-4b6a-9f58-ff5f8bd66682@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8047d447-8d5e-4b6a-9f58-ff5f8bd66682@linux.dev> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Jun 11, 2026 at 02:45:15PM +0800, Kaitao Cheng wrote: > 在 2026/6/10 22:59, Andy Shevchenko 写道: > > On Wed, Jun 10, 2026 at 08:45:25PM +0800, Kaitao Cheng wrote: > > > >> The no_hash_pointers boot parameter is now handled as an alias for > >> hash_pointers=never. However, hash_pointers=never only records the > >> selected mode during early parameter parsing, and no_hash_pointers is > >> not updated until hash_pointers_finalize() runs later from SLUB init. > >> > >> This leaves a window during very early boot where %p output is still > >> hashed even though the user explicitly requested unhashed pointers with > >> no_hash_pointers or hash_pointers=never. > >> > >> Set no_hash_pointers as soon as the "never" mode is parsed. The later > >> hash_pointers_finalize() call still keeps the final policy decision in > >> one place, but explicit requests to disable pointer hashing now take > >> effect for early boot users too. > > > > How is it documented now? And if not documented at all, needs to be. > > In Documentation/admin-guide/kernel-parameters.txt, the descriptions of > both no_hash_pointers and hash_pointers= are already marked as [KNL,EARLY], > which should match the current semantics. This detail should be also mentioned in the commit message. -- With Best Regards, Andy Shevchenko