From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27B51369980 for ; Thu, 11 Jun 2026 08:00:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781164860; cv=none; b=rjBIKuPFd97VwOFFRZNF85w4M4OYkpG3ZN/H8FE8ok/KWwocwBuLoGReSZUs9lR1R5HmuogYr1bhBU/aBpt1fztBjW7CSpHY8V960OcJNM5BHSdSWtdid7qmWLXNRDBHTjnM2DKKHd4wud/JIo4ay25JleyjskTYDUZsr8uUKzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781164860; c=relaxed/simple; bh=7WN9HOMrZkYQ7JoY2t9OEx9/dKdH3hDAF8ZIcEtC+jI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sy5GBbA4p92jd1VYED6CQqNtgFwpt4ySWSxxtx7xgJI93OTbCj86jNzp87UPiSMptbCksalsd0c/liL37jMtE8qEXY5rYGtnXZD6W6wD6G0E/CNCc2Jl02XiQOLpFtYvRzMmG9qt00WIm1be6a5gY/3zvAdSuIlgsn2rPfoAQZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mUr23X7P; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mUr23X7P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 688601F00893; Thu, 11 Jun 2026 08:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781164858; bh=tgObY0uopxiKfi0MZaI8nGe2B46L7H/AW6iBLbSxpLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mUr23X7PvT0So80MyuDxiJBlv4VRZKIHoQBDfbIiGtLbXYY8sRxVWUOCDhaV6HlN+ yQ0jaaXOLOOJ+jdHtdb+VPLpoQdupbswtYgliT9+C/VC7On0IXt44FryJ7YEWONApg fMbJGIgbzwDvMpzCg3ewXe0U+o7ZRRGiKrXHx/dFJY93FgB75WMAIstDgs5+mQdeB3 DXh2beeMv7nLL/lbqOSaZNWZzaCZere8wpWbB4/2oPY+3NTyDb5XIqZ8314MZM2Zsw Hgbixm2Cyo3E2dy+zE2E8uMJYcMorrSCFtSAK9NGPrZvadwfx1t+N7uGEzax4/fEwS cojp+HDHhvt2g== Date: Thu, 11 Jun 2026 10:00:51 +0200 From: "Oscar Salvador (SUSE)" To: Lorenzo Stoakes Cc: Andrew Morton , Arnd Bergmann , Greg Kroah-Hartman , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 2/3] mm/vma: remove mmap_action->success_hook Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 02, 2026 at 12:06:26PM +0100, Lorenzo Stoakes wrote: > This hook was introduced to work around code that seemed to absolutely > require access to a VMA pointer upon mmap(). > > However, providing this hook leaves a backdoor to drivers getting access > to the very thing mmap_prepare eliminates - a pointer to the VMA. > > Let's solve this contradiction by removing it. The key intended user was > hugetlb, however it seems that the best course now is to avoid allowing > all drivers the ability to work around mmap_prepare, and find a different > solution there. > > Signed-off-by: Lorenzo Stoakes > Acked-by: David Hildenbrand (Arm) Reach out if I can be of any help with the hugetlb thing :-) Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs