From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D8E13CBE73 for ; Thu, 11 Jun 2026 10:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781173659; cv=none; b=moekDvF8owJ4bwfSwr/UfqOMrOq5V+PVy4dwpPZAlFvxE8JG2dAZ3TxbGtOWxLM3UO+iAu04L9wFp3xURkjP5YjO/B6agRQEqfHpQA5ZNycsOa8KGjaN+8Bcjk0irHegX+ipalHgFG3QdrMWHA7ygtTLmgzTx+JCxHQwS9M6Lds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781173659; c=relaxed/simple; bh=fXKbee91Nqu7cJHnMhqQL9Q3B32VX3O8hKOJ+Vq54Og=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=eXI07yfkDc7+pCVumUI1jootpFqCiQvY8hyEGEOpg8qsbrvnSsNEtJgW1LPbOTfURbIOP1p/CewvwGYLVNLmdOL4ftA7iM+3uKLDsxQxFBRe0xv2zIF+b9TIzwKz1u2Atm9JaXEPAsJRN+TAKQojhdhkteQ6vIaeoe2/S16IvGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JWzFXU56; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JWzFXU56" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-9158c621ebbso911943985a.2 for ; Thu, 11 Jun 2026 03:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781173656; x=1781778456; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=tIFb7lA47yKA03mD5eNYLcNFMgrB7SUavs+fhnXbFgg=; b=JWzFXU56FTDIePDWdBVAny5xCsG+miaLP9Az2m2LU9VieDCmViakcI2rATIRPshsic h5wFm9/W1F+z5KWjy9j7Q8pX08MvySgo6aHncBNP4SAYkPI0g94XHG5reNmNn4T7jtLH mrLxjopfrR34x65Pn//11VCHXpDHeG6mDb1xlrGLYK1IwgBpQRE9yMsmNbn/ACWByVtv D1ZXbWvmQfH0uaFrDdpX5Ct/vUPWwCCtictIls7svY+tbQ1LftOezNlxItybVX+pvKaI aRkS/L+Eh7SECQn96HoEGd8xHTJwFoMchKag7k0BFBPAGFQfzPjxryNjDIWO4Xl7fEza pO+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781173656; x=1781778456; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tIFb7lA47yKA03mD5eNYLcNFMgrB7SUavs+fhnXbFgg=; b=stG8kksJ46unWY04YgkAAVtCi9ocvmdImL2FPScyX4F+tK7WPDZdl6+lXFss79V3ex XvA00y06yDcFycrlGG2EZM0CcbjaMQDCPILMyxhoqBoIiVvbczmGSTqwDBF2ihE5JbZw 5qks+KbBKIIO4cR1+v9cd9nLKux1bQmdV79B1+g+OVBwOVy4TyRfGZsef2pDqSjO/E05 DjxBnOjG5wehdY50YMPRawlECgFvHzjCNuAb3t4BbFn9IbNw1nyMyL4ApmNSJMzs3iMU sYxCRiFfgeVU6hj8EPXAFxskRFVIBF9Ph5CBxz/DUts85EZN5wI4/l445GtxActHAOaX luHQ== X-Forwarded-Encrypted: i=1; AFNElJ+fPG9f61UnGCKh6Cp3y1Bd3rgH+ywjV7fjL0h/7xu9zxrkWtJtW3g3ydYL0rO0klK5RI7cgISydrWq2Qs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywulo/h2gMmiSeMF7PBynpDCHhTA0LcMvpHYQONqzyYNRBqMJRW G7je1gfV7BL6oleDJfHXU8fDuccKtsycaR4Suid6ERE7sXYG4unvRZrz X-Gm-Gg: Acq92OFgxFq/K56xnC5z5hI3hHLkblSeKcZ2umGOGV3y4QzaQUH8FkkRccpmeSaPQJt UdCoTFzf46ExlkmAuu9XPcm/x62BgE3DsuvJ0rTbUy1nGIbCjh1vcTgHqAJqjVlq4kh1q095LPD HuTG/Ei63pwUYt77jIl5pFd8JnWlYhl2RhbTcUHqxBSVjUyG1+FMRqRI3ub10SZmGUcJv+E0whp Tt/TiGSxBnd4+4Ye/WVsG7JsX8eUwV5yTJfKrQ6ni0oWIhO582ItU82zGXrggTWOJ2sPcZPxz8f qAOJnJwBSFWm1F7ZxhGvinP3ued4vJUTLxe0gFLuZTaCxFM8gwMs3UiKAFHqB6lkzyu2TRaFYTb V7sk7P/UgCSvcfXX0emW1Ez98pjgb6OB/Ib1xHJhJjoezvdF11XCKqzOrbGS2NPOKzEW6Ilfp9l +uKoDWzqQLc54JoFZ5orOQW6k0+I4= X-Received: by 2002:a05:620a:710b:b0:915:8055:3f91 with SMTP id af79cd13be357-9160b042de9mr330058185a.43.1781173656224; Thu, 11 Jun 2026 03:27:36 -0700 (PDT) Received: from localhost ([149.40.50.215]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9160aca325csm147320685a.11.2026.06.11.03.27.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 03:27:35 -0700 (PDT) Date: Thu, 11 Jun 2026 13:27:30 +0300 From: Dan Carpenter To: Konrad Dybcio Cc: Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Harshit Mogalapalli Subject: [PATCH next] drm/msm/adreno: fix use after free on error path in a6xx_gpu_init() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The a6xx_destroy() function frees "a6xx_gpu" and so "adreno_gpu" points to freed memory. Preserve the error code before freeing the memory to avoid a use after free. Fixes: d158886cba08 ("drm/msm/adreno: Trust the SSoT UBWC config") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 8b3bb2fd433b..a44380316aaa 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -2770,8 +2770,9 @@ static struct msm_gpu *a6xx_gpu_init(struct drm_device *dev) adreno_gpu->ubwc_config = qcom_ubwc_config_get_data(); if (IS_ERR(adreno_gpu->ubwc_config)) { + ret = PTR_ERR(adreno_gpu->ubwc_config); a6xx_destroy(&(a6xx_gpu->base.base)); - return ERR_CAST(adreno_gpu->ubwc_config); + return ERR_PTR(ret); } /* Set up the preemption specific bits and pieces for each ringbuffer */ -- 2.53.0