From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE6913D524C for ; Fri, 12 Jun 2026 07:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781250242; cv=none; b=kHSWopHuKBb+NiF4+XLrnJWleCGrlL3mmaV5yV6vV+qSDooQGdU4QmrcM0a5OMO+eOk9NiAcmzJKZGc5ZEwp7gYJeUIdLVOS/tySU7zGYWesZT4D5xrWKwdU+hFeo5kIj9R/+x0AqxMButW0IT8XjHvRqRHBJkbtEm8GeMti/Hc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781250242; c=relaxed/simple; bh=xgLZ6ydEdxbm7XtxVmmjX5AJUpXge0zzzM7UHp0ej2Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JInEBvFNUp1OL+VOcVnYxrgmpWrcCuI7tsrLdaSfIYGy0VoQNWkDp1Rtv4ggH/xb+K07GALP5wkZXpRkXbcmjLHFQb2DSJdVMdd71WIk4jAPhmZyvYVV0G8u8yZNrAjkvkf4lI9Mk+xQMyBtehPL9K/GWDcJURd644C4NBzToW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=jn4oyUUm; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="jn4oyUUm" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-490b1bbcf3aso4937475e9.1 for ; Fri, 12 Jun 2026 00:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781250238; x=1781855038; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5Rxr3RDnrGDap9ET6pVXLfD4X7lIkVPiU/6HValFYlE=; b=jn4oyUUmU8lFKGSp8oNixWQduVa9uqTC/hdb2bhX0boJZxKCDb0/eV+xtQZ4l6Nesf W8cHOolrQsecZGM7VsEqIXPjkK1dfRymfFFz9625BqO0JQYOjWacLgz/vcLMPY1xsCpl BfXdbTqtfZIEgCNoZhDnuBxd85tCgSPN9VC3KgkBxgZiDiDAIBOl6OuVQO4VxwnxPv3O Dq4qaTd/LH90YPNQOfC6Vga52c2DiXF4TZk475KEWMu88PkhIWGukXXEH1F3r0FJbYeq 4QfEHB8gx/GA8C3rxokF4Or6OEb/LAhyU/uUn7NlId47MACyLYDcArYE/Szisgqxt5Y1 k65g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781250238; x=1781855038; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Rxr3RDnrGDap9ET6pVXLfD4X7lIkVPiU/6HValFYlE=; b=RiNUeqXv3DUS078fC77CuclwFqPIlzABVDzvmhfUClYy1Rcsd+JePfo6ldCV9uDATD oPXG56elQ4H6eWoBFN31amD+XB9rFfOBvg3f+Z4uvGSdqyV5Z69vsvRIorGNgOYbUoOd h7l/LcY3AujVUJOpiob0dEE8k9udcZ15F3scWEu+4rcw57SHVZHooKChPfwQWki1bp1E W7JjDvAvFgFs8rFYbJgBJkrOxuKPm9MHiS2GyseD37Hiiz0JM+Z5C4jHP5cVPhuMRipo jb0GPmfhZBsKPe18rY63ZLRXdveRbJfBpEF8gEtpn2Hwp7zyUplqIeog1ymWg3j8XaKs GmGA== X-Forwarded-Encrypted: i=1; AFNElJ8I6p8pz2QXiTf8N9w8A/Vk4wraLLpxL9LrlRtRGXjAdeg06wzEPFyJ1w87BbgvimxLSQP/MlzWCR9ldvE=@vger.kernel.org X-Gm-Message-State: AOJu0YwS9JEpbZ2rQrY6oY/ZVbs9jvnmEKVil6UcS2eyQ+JTzfUurXPs gdYhVrks8T0YV1tUvItm0m+OORCKcnw9hBDAkWRFFDn/SLsKD7oyETVbdtijLnyBEGU= X-Gm-Gg: Acq92OGOvPjB9GMxZmW4aF9/+oyFuMhCMAkrTN6c2QMduj5+8SLSdLpSpauDvf93t9j Fg8qdkK3DGVzaMsfiVAScv3HFYeKS8r6LWiOJ2T3nUnUjAtFPHfum066IigCUoNG0/hU77Ld1tp 0LA2WKKs40C0fKOartbL1DK4cuMSj3SnK7sEEW0+GVTcptdG3vqHHTdD8rHmkYK189PCohFqgGy kZ9YP8GStliiKUHH7NNaKzBaxWjaqJUwlwZzGlPxVUnO3elmFkXKsW7HkkBt/XL6DRo7y158RZG +rPmnAGbenyH/QtgghO6Nkg4UjmZG//R5rG0vmo13i8Z5miZ1+E8BHudQqzwvFX+5N1Gno0QLYg SVLEa3n9kKOmFBi8qfBZ33KseAZMnKcrCVCx9qoksc1ZWanAt7m2WLTV3bzraI8udgIkNFJwg7r tXQi48iJT3ROMojjJi5mm4bsZaHBO2N131kyXGLZiQ6yYG21rnsFq1IixIQjcAZW2FMQlsgA30q 3SoRuIDiDLcBg== X-Received: by 2002:a05:600c:820c:b0:48e:5d91:cfe3 with SMTP id 5b1f17b1804b1-490ec4cd08fmr20296955e9.1.1781250238091; Fri, 12 Jun 2026 00:43:58 -0700 (PDT) Received: from localhost (p200300f65f47db040e4e5c1e98e7f0ff.dip0.t-ipconnect.de. [2003:f6:5f47:db04:e4e:5c1e:98e7:f0ff]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-490ea7c09bcsm44786175e9.2.2026.06.12.00.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 00:43:57 -0700 (PDT) Date: Fri, 12 Jun 2026 09:43:56 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Liam Girdwood , Mark Brown Cc: Kuninori Morimoto , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/4] ASoC: renesas: fsi: Simplify driver_data handling Message-ID: References: <308c08c0fb309c190412f5ceb21b0027842b6294.1779958164.git.u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="33zssqxog3lq5pt6" Content-Disposition: inline In-Reply-To: <308c08c0fb309c190412f5ceb21b0027842b6294.1779958164.git.u.kleine-koenig@baylibre.com> --33zssqxog3lq5pt6 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 2/4] ASoC: renesas: fsi: Simplify driver_data handling MIME-Version: 1.0 On Thu, May 28, 2026 at 11:06:01AM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > Instead of hiding the fsi_core struct for the only supported (non-of) > device behind an abstraction for multi-device support, hardcode the used > pointer which gets rid of (open-coded) platform_get_device_id() and two > casts. >=20 > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > --- > sound/soc/renesas/fsi.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) >=20 > diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c > index 8cbd7acc26f4..efd1447eacb9 100644 > --- a/sound/soc/renesas/fsi.c > +++ b/sound/soc/renesas/fsi.c > @@ -1905,8 +1905,8 @@ static const struct of_device_id fsi_of_match[] =3D= { > MODULE_DEVICE_TABLE(of, fsi_of_match); > =20 > static const struct platform_device_id fsi_id_table[] =3D { > - { "sh_fsi", (kernel_ulong_t)&fsi1_core }, > - {}, > + { .name =3D "sh_fsi" }, > + { } > }; > MODULE_DEVICE_TABLE(platform, fsi_id_table); > =20 > @@ -1929,9 +1929,7 @@ static int fsi_probe(struct platform_device *pdev) > fsi_of_parse("fsia", np, &info.port_a, &pdev->dev); > fsi_of_parse("fsib", np, &info.port_b, &pdev->dev); > } else { > - const struct platform_device_id *id_entry =3D pdev->id_entry; > - if (id_entry) > - core =3D (struct fsi_core *)id_entry->driver_data; > + core =3D &fsi1_core; > =20 > if (pdev->dev.platform_data) > memcpy(&info, pdev->dev.platform_data, sizeof(info)); With commit 38d3273075d6 ("ASoC: renesas: fsi: remove platform data style support") this patch doesn't apply any more. I will wait till after the upcoming merge window and then respin this series. (But if you take the other patches until then, I won't be angry :-) Best regards Uwe --33zssqxog3lq5pt6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoruLkACgkQj4D7WH0S /k61EggAgll/pk23f8RfaCUiIfOyRHFxGAcldRRnRxxCMNzlPUzrpNxBfDyxg2y7 DAMOlGiBXys0r4vCUHYvDH+ShS0qQifZV8oNXy3r/mRaRRP20Fw4xhopzGiQUYCQ aDsBs1NOQUaD0VraBA53JBkLQpL2I7osSlq62GgF9n1dkL0qIXgK1WNYaLc1QT5l oUzcBzyGVrldHnG5D8TMfZRAx206Kamj04Qki7zp6R7QG0IuiuIq4IMd2006FMES uBi/B7T1fctq8uLYMqkBwAbyy3mYsaWEpIfAYCi7GjJwpmPhnd6FiaQ24sWnRHvT sboWrBbS1d8HbAmFGsG+Ed4IB3xH3A== =3Yia -----END PGP SIGNATURE----- --33zssqxog3lq5pt6--