From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2E5A26CE2D for ; Fri, 12 Jun 2026 04:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781237779; cv=none; b=Fupr4V0GQvkXENu1GGcSC5Vh/ATvIm9FSUgTKFZuTfPkdhkt16X212tZsqWKOi8vIC/iJwa4hbofb2uFK40dhA6mr+ss/wridcd9xdT7hPC0ARoQUeesHvnFCGXaxhkEnWQ9E/Pf9J3phkQ+PC0za0KsFMz6bcQrEcSJK5d5CB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781237779; c=relaxed/simple; bh=S45NGb5nHnP1iFpxpFlQ0YTorvzPHiJtJltQczKK3kI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lYyyiLuqKv5w8hLNAddvhxRAWinxtuJlMowmc2TFjKJFQNNaDvtGKtrTw41Aa7pwyCSa4IP77y2W5t3K3afbByar/tgrsrgBzWq3EiohiB92x9aw7VbkAf/h9ciMLyeaR59+1lOa0kBCXgRM6I/QMkVRLdSGzISti4TVbfnS4aM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X9k/kSie; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X9k/kSie" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-36babe2c4bdso353504a91.1 for ; Thu, 11 Jun 2026 21:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781237777; x=1781842577; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tzOTMyOpfLnyNK+VGAde0WzU286Gd6+LpsOa0E/ts9o=; b=X9k/kSiezeARoKznaBGdd38vBsfyKloyopiJmHJ5dUxcfSHfvsQoxSELmmzj66bgLE LKleYIKPwF53ZVKx0IMjqTz9GdJZhC/DdY+PWucioiNisbqQnLH3vhhooOj8AOxtKEw3 yWzGpzz8VaceEj0LFEvE6dGPOo1ruH1fncfxp2TDFiL9PQvBWCOqSbpjX6LNShs1K223 gSSaZypcDchsr3JCW8tts4WZYrJ59Wdn1FOlgJt5mkYDqnkfWtattK+o6E0JLfvh2tBQ wCMoG/0gks9jz7jM5JVq/xC38oJ67BBqXrqE0swgbSm2mpL4d+1DJ8QXe3YaspYY4Q8Z 4A/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781237777; x=1781842577; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tzOTMyOpfLnyNK+VGAde0WzU286Gd6+LpsOa0E/ts9o=; b=ITAM46oKudQ2ScOIiCeE4EM26PxOhwyhxjQR3Zvw38tphhsSCPIMaG66n3MZRAwglK hfhjl3ELbtDSHiujaQxhCAuXCSllvpX/3zcD0IZWSCcvqBovdKnA48yPc9hn0U9DDuGC ugY2ovI5zYxZYoaV8jkT6yACMoJg8azvkVHbPYPmyVAflW1AuOUfA8NhrS9yNk0BKIe8 vkj3T6UkQFYIRkoEOgLvSh234mR3nwO3FfWqn/5QlGRtrwxR3bcNaB141ruDtxobue96 uOUMwYAqsW10Y39I+Pmr3EmVRh+rHjgiOz2SToGFmkbK7Fofw9eqcHDWvIAoqfxn50hw Wqww== X-Forwarded-Encrypted: i=1; AFNElJ8aXpMomFW4qMoxvX13SbIC8JiYOf9WRK75TXYK21o2r8i2QWq9o6DX8F+HkWhwXllugTBMmqPLO4/Dgv0=@vger.kernel.org X-Gm-Message-State: AOJu0YySIMadlfAPRHsaUnQ+qSqTrF4pfXM/DbCk27hLtqI9medLH5Gv yxyXRCBtZj8XSEH1zIgY6UPiFhujqSp+LUwqw2f36l7YiCmoccILVdX1MV7Qww== X-Gm-Gg: Acq92OGlcBdBeZtA7bg025Vo0HVEEEBV0tcHoLdoCZ+exTVi5EcSmp13V+mSpV2sZm0 nAyBfkA0ls5dS9580iTm2W3sHTnB/HqzJ5bpZBeBhXzubeyoDOZ2PdSgaj+cjkYOpNxYPGj0xV2 CUtkz5vBVEqpk43XLND7JwpisQ0dZGsTA1fdtkMJxyhPsmZUC3C1PnQJA4rcUdyTVD8Pua+ALhV n9BJVJkuC21D+OkjMFjzo9oruBP7hPlzN5BuMIV9lV43/pJObhKtlcMrOQLB9QlFU6EkxaqKJ/G oLOSXUaSZZ2HW4IVmwn4K4Kd8Bse+PerdJ0nbB0ck5myM/d1WOnoXG6jEF9iEQ43RocDWLBJxWr HESy95LjSoKd4pRkAjzTIctbuKgFXKyoiSBd3XNn51Pob2s81r42BeYQP1V99pG1JYs1pI7rnt7 HhoGnnaHTBuQ7JJtVTGwokOOkb0pBCyxPpO58tmM63Shc= X-Received: by 2002:a17:903:247:b0:2c1:a19:8396 with SMTP id d9443c01a7336-2c413dbb942mr14852495ad.31.1781237777134; Thu, 11 Jun 2026 21:16:17 -0700 (PDT) Received: from page.local ([2402:a00:163:2ce9:95bf:5776:9b95:85ee]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e535csm5089475ad.6.2026.06.11.21.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 21:16:16 -0700 (PDT) Date: Fri, 12 Jun 2026 09:46:10 +0530 From: Ajit Singh To: Konrad Dybcio Cc: Bjorn Andersson , Bartosz Golaszewski , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] arm64: dts: qcom: Add Vicharak Axon Mini Message-ID: References: <20260607113658.25117-1-blfizzyy@gmail.com> <20260607113658.25117-4-blfizzyy@gmail.com> <39228ace-9404-4ade-bcb1-28e763548b7f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <39228ace-9404-4ade-bcb1-28e763548b7f@oss.qualcomm.com> On Wed, Jun 10, 2026 at 02:58:19PM +0530, Konrad Dybcio wrote: > On 6/7/26 1:36 PM, Ajit Singh wrote: > > Add DTS for the Vicharak Axon Mini board based on the Qualcomm > > QCS6490 SoC. > > > > This adds debug UART, eMMC, UFS, SDIO WLAN, USB 2.0 host, PCIe > > support along with regulators. > > > > The UFS ICE block is kept disabled because enabling it currently causes > > an SError during qcom_ice_create() on this board. UFS works without ICE. > > > > Signed-off-by: Ajit Singh > > --- > > [...] > > > + vreg_l12c_1p8: ldo12 { > > + regulator-name = "vreg_l12c_1p8"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <2000000>; > > + regulator-initial-mode = ; > > + > > + /* > > + * VREG_L12C_1P8 supplies the Ampak WLAN/BT module > > + * VDDIO and the external 32.768 kHz oscillator. > > + */ > > Sorry for the long review timelines on the previous patch, many of us > were out for conferences.. > > Is the oscillator used for that WLAN module? Would you ideally like to > be able to turn it on/off? yes, oscillator is used for WLAN modules. Oscillator is powered from the same VREG_L12C rail as WLAN VDDIO, so there is no separate regulator control to put in pwrseq. So I think this will work fine? > > Perhaps you could get that with a simple pwrseq driver (+Bartosz) > > Konrad