From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010034.outbound.protection.outlook.com [52.101.46.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FCD3381B07; Fri, 12 Jun 2026 08:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.34 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781252567; cv=fail; b=pXuHAcYzjYMzQ+9stn0yD2/4yf008YOXUIfsxynl9sTTPo4mvJiTYWzOLMtPCP7rCHlTnf+tU//x+ItaXSImkGywRsxiatOcfKF8pl1ueLJYykwQjOVL2DoidOMhgqV31k1lFRzcHQisZ1zpVnsbAVAFXX+Q9BUzVsnyRYZJQgc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781252567; c=relaxed/simple; bh=hMhOpicBQnOx/BcychnCpDAGt9jjwwbMXDsLSA87VC0=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=GC6sBiFpjx7ODJfcJFwc6r0J1AE8PsM7on99zCRIDoqBsLSWkg+yGouJHf8eKpMcg2JM3NL26KvPBZL4fT+X/EAvVRaZa2Cbwv2KhvUMd2W4hl1k7TxkRMwiJChywxEjshu2NsJaQScwW7BlPrMjrQNWfqj5aGmBi55nfw9bJ7g= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=nbWpzpVp; arc=fail smtp.client-ip=52.101.46.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="nbWpzpVp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nCueoHLqn3LwPXYIeX5qI1pQEkfcNBvCaMguXZVhHb6qUpUVNDyAOC5UAsqNEWnAeoDYf6AKkZ4xvFdEDDt8YvH1dIGSXTTm9kgP57qGZqNsJSeIAtCPj8nGfL+oOIuTJEvgHUihJhR1itqOB6REsZWzXOKcHsEsckfyRPnc9wqHqQeqpLLEEYK/efmqYwgOsqoAl1A96FYICHFfPD2FVnFv9C61PQFkYkbUmB3Fr71J+dJFG/QoDTSWn4NTXFjZ1npcIodwOmbYXuvnJWOJwIxyhAK4f7VR11iDgpjg1VlkOlu0RPdeHd4/FYVKc8RhERdIFEgzy+YFXE6L8tZYnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cCkWijr9+FmHTTNd5tVOF+na/i5xAL7Oi5Gr5nK1Y/w=; b=BEOKv5jBeqQvS7MV/CweG4PNS0+Imm2c3MQrij72h5K3WCGWwG9GH1Dv7GkpmRz9PaSbktf+R9s/qTWY1Lr2MFmkP3Igy7zB3q3usseRqYm8RQzNn50cbTIfca/Ul+Bj7Ri96+U4H10ZRZVRqFL6poDQq8gZaLTucw64ys9PMENu7jh1JFM8SkfVZH17Mbv7FIKLlaTqWMH7Znnh9qcgkKoN+KeF/PgA9XufImMGrqWaCHi6fTJ28rXr/ttiuFFcc9Nzc3tZMDCy+bHRA/FPAgVYJWGEliFu5/qL/qF3Z46szBBbgCsbUDdarpYfy6SE59XYT9e9rTp/r5MjXW9Ndw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cCkWijr9+FmHTTNd5tVOF+na/i5xAL7Oi5Gr5nK1Y/w=; b=nbWpzpVp2fIC37D9eEaYX4sf9NisA4/OYGBzpS4EGNCQLnj4CRGxz0FAQ2Xjv2aSdV10mGCaTQ/Zh9IcNtd3oeW4XMr+LV5/5PQgKPAf0FC6gw8xkGY4E/5WCWm0atVnPBxle26frnLOQ5S/hr1YE+uD3rU7YCOJzeWXDVgvV1FEpdenTDM5h3kkyZIuddUgu6iAhxomHjHWfvpk32FcQ0WsaMPUK0BTLTVZy7uEFD++SqFEjYelEffdlZB0VPCiRvVJLkmXxXEsiuLVtDx5Oq/glu4agyuRrxNz7HlLd/4jeaZ9GGsx6YNKrcV7xNG2whE2RokHHJm5HIGxT36INQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB5001.namprd12.prod.outlook.com (2603:10b6:610:61::18) by SN7PR12MB8129.namprd12.prod.outlook.com (2603:10b6:806:323::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.14; Fri, 12 Jun 2026 08:22:39 +0000 Received: from CH2PR12MB5001.namprd12.prod.outlook.com ([fe80::89e3:6df0:de90:8dfe]) by CH2PR12MB5001.namprd12.prod.outlook.com ([fe80::89e3:6df0:de90:8dfe%5]) with mapi id 15.21.0092.016; Fri, 12 Jun 2026 08:22:39 +0000 Date: Fri, 12 Jun 2026 18:22:34 +1000 From: Balbir Singh To: Aboorva Devarajan Cc: Andrew Morton , linux-mm@kvack.org, Jason Gunthorpe , Leon Romanovsky , David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Ralph Campbell , Matthew Brost , Alistair Popple , Alex Sierra , Matthew Wilcox , Sayali Patil , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] selftests/mm: remove hardcoded THP sizing assumptions in hmm tests Message-ID: References: <20260611034102.1030738-1-aboorvad@linux.ibm.com> <20260611034102.1030738-3-aboorvad@linux.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260611034102.1030738-3-aboorvad@linux.ibm.com> X-ClientProxiedBy: MEVPR01CA0002.ausprd01.prod.outlook.com (2603:10c6:220:204::19) To CH2PR12MB5001.namprd12.prod.outlook.com (2603:10b6:610:61::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB5001:EE_|SN7PR12MB8129:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bbe4644-9e41-4d26-6045-08dec85bc41f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|376014|7416014|366016|18002099003|22082099003|4143699003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: UTakmnDw0nOVbGiRixWBoo2yuvdnZ0n5Yzymmm6QvwPPtQAT52k2VNnMDv6N9IXXyrs+qPJlFgMYo073eERMbPlttN67sFRRS1guUTpyjfWQKbvvclEm5XDlk6spJEbSvRibNBI4VAh+RRoN6OWw+hhC3Y0/ot9wablmWdeTJXSY0Gbwk4UpZEvwRwgmhZt2MEEgzLtgBkGgqRmMH9QaNl85PnJuMPAg6odJi7PzRhbQtiRICSF0qwkgFTx00fqhJBUc8aUwLeprYmfWaVHQfZc95/52LY1ilsQtcXGRwy3p6onS1Z5Ec0FDxSk35Lzv2fs9GUYhzNwPlcr+5EXovMK7eyzsFmnxbVx1SHa9xPEUGo+ePgHV/+qm6R+RMOGpFe918KO56sKBLUZ9kYgW5EUzg1SAVznJyv6K16/ExpLXWwJklu53fsV+k9nVMQmoPkfnYNXnCctn7/0mahLujxbtwB2/Yh5PT+Tk+93Jm4KWfAQuxXErVkoZ065Bf+b8Y70E4kZCa+Lw4o2ANRHRrN712IR7gDeTbtf/CuXaWf4PkdgGEEwqEdWu7Niqwck2Ig0S5PmrJLFDcMPCktgfPDaKLVl0Vu29NJ6YLfDBZ9iODIe6+z9GsWiV3Hg1yQXahKKNfmnOnkZo4Z8OxO7teHmibx1suCT1HGVG+LRmYscH5RbcGkc1ohJu+YEQTX/2 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB5001.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(376014)(7416014)(366016)(18002099003)(22082099003)(4143699003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ilYBLLK2hNu5dB64RO0vyn8WyktQ7Le0G3ZsP2+1+vuUxEZYghensUudP8lJ?= =?us-ascii?Q?V3Upu5Nl4PnrrqlUBuoOKZ4U/qa9whTELE2E3onMqjswWqcaTE90I76EioWk?= =?us-ascii?Q?m4o1q5CBiaK20ANJ65o8oCVVu6KnVC8hQYH+0rAWGwd4oTn6rcZ8FqcIXI6o?= =?us-ascii?Q?1e2TjzsqU8sWzcI09oiuqMG0Gb35qKF05xoQAeHobTlc+XbLl9uuye3Y6leG?= =?us-ascii?Q?pPJEJgwdz04ozBd9QIVoGNqz8KPQZtxR2l5tC81VEh7x9DI17jT9CF6WB0Bh?= =?us-ascii?Q?mxpseXfkZUtFjUWSBuypeW+OUVguokU2kq5YKnM/UL08OnaMDe6/j65h0zFI?= =?us-ascii?Q?/ezWlpF/uA4FlMg9Yc/wrXE44onJJtDu82DdlJMmoa1+Bo3GLXpFnP5cg6+D?= =?us-ascii?Q?PaGzd120IFuLS6UhrI8zhyzGMjOpUe1dSa+q3aym7RgITcf+E6btiDjAKRzM?= =?us-ascii?Q?jLlzFDzfV2mPttZYQMG3kDLeVenKmNyHyC7yQOjx2HBIf3U268QDKYCX0WLj?= =?us-ascii?Q?SThISj7AeDRpJvzO25d/uvs9Lq3e0GYmkUqcNjHBR/ZRlMDr9HyBWHrEXPMT?= =?us-ascii?Q?E+HxnIic+s08TuFDBuyzqsFrtcob9HBhpWNKBwv2TSrC2PBnure/djNiY1rY?= =?us-ascii?Q?O1QMX+b/VrE6UXl8l2Yfv0KxDqoV2U48cumK+Q3wI43jF4HJqmX5A/UTMQUq?= =?us-ascii?Q?FCIZpzANatvzLnM77kn6pckuBiaEF2+JG7ZYLap73qc7kvIctoSvJROx2djV?= =?us-ascii?Q?S5FjfJsvbyJVoz+g5HtUoBmUCr21v3F3BSRVNS3Cgg7zDlQX5jnI/KpAAYeq?= =?us-ascii?Q?GeQLxn6wZJHb+g8gnO4h0Wsz+3TwxJt2RVTlXJU//S2mvUJGRbIfVWpIb5kl?= =?us-ascii?Q?dSw1IvN+02DsgG4mx0yaKFMOLM0y5s+TbtHV4nvobGuaEIITS/MRFTY9Np6Q?= =?us-ascii?Q?FL211fTcYSzHoRYYPNxdH+IZ94yLeSPe9Ivf+1dwXGEFDEoq+f7kybbxN8o0?= =?us-ascii?Q?T4E3hN5NKUNrxqbhHb9mBl1g0rgAx+x9TTO+AECsGiACnqQ889KW6/ya2zjq?= =?us-ascii?Q?ENocJjChZYhA+fIFC/H67nAoTuBQ1fSFmfnDKRVhcldlLFODXEj7Czw8jnhg?= =?us-ascii?Q?pRoNef+ujYPmbPRzaIr81psO7An3AP6CgBuh+dl1X75cDd4FhMZ9eKgAA1wx?= =?us-ascii?Q?bJoLC/V172fdY4N9BEXx+imKIeisY6vZ6DDWd2U/byK4H8CpZWv46xSj3pGp?= =?us-ascii?Q?dS7Yz2ys4lC7UxJKd7NO2DgK7S5OjU1Vsl6jERrt1U71kRAM9C5gW7oWS7Q9?= =?us-ascii?Q?7Sshv0SenEXmdl4RS0fgNerqGYByUKj57kg4jLoEmKovf/PrbOuAiEdy9S0/?= =?us-ascii?Q?AuvtRtEaoj3KO54ItAErViJFKdE84r57tDL7ZVll09ZoKtlvRuWimRh3h/YN?= =?us-ascii?Q?9DLSd4GLjwqUluy5r4eBGvucUkrMDBYR0CdBczRfjtpoxm0fzG7wpEazKuIO?= =?us-ascii?Q?xTzseY2AoDaMS/QfxZODAECh/1QtkzkcPmBn2X1r4w8ZAgzZUVRHotzL/ovA?= =?us-ascii?Q?HW2hOvgQe3Di1Y2vp0t0Pv8pZtGL260FQDLNNau2kGkgEqyCvcepMwQ0aECB?= =?us-ascii?Q?advsnywWCoUM6A5QUhLEFxPT+hQTQcr6lEyxWXoOP1+WSHtKSAscfFMSr7nm?= =?us-ascii?Q?cMBCqwvXkIwwN5F8LEjG3bXjmhFLsUuvlhwL/sWlt4k/bLTliRHpXuwn2Wxl?= =?us-ascii?Q?AaWDKUcmhA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bbe4644-9e41-4d26-6045-08dec85bc41f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB5001.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2026 08:22:39.2960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UHOQusaG2pXFQos7KAvAFKeLJ4FnkjTbJWXkMz1OWxBPAdOgTN7JmVfT/HjmAwC8iQI2wmh4vHJfyIuU2fk4hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8129 On Thu, Jun 11, 2026 at 09:11:01AM +0530, Aboorva Devarajan wrote: > From: Sayali Patil > > migrate_partial_unmap_fault() and migrate_remap_fault() use > hardcoded offsets based on a 2MB PMD size. Similarly, > benchmark_thp_migration() assumes a fixed 2MB THP size when generating > test buffer sizes. > > Derive offsets and test sizes from the runtime PMD page size returned > by read_pmd_pagesize(). If unavailable, fall back to TWOMEG. > This allows the tests to adapt correctly on systems where > PMD-sized THP differs from 2MB. Also replace the fixed 1MB unmap > size with a PMD-relative value derived from the runtime PMD size. > > On systems with larger PMD sizes, computed test buffer sizes can exceed > INT_MAX. Skip such test cases to avoid overflow. > > Fixes: 24c2c5b8ffbd ("selftests/mm/hmm-tests: partial unmap, mremap and anon_write tests") > Fixes: 271a7b2e3c13 ("selftests/mm/hmm-tests: new throughput tests including THP") > Signed-off-by: Sayali Patil > Signed-off-by: Aboorva Devarajan > --- Thanks, Acked-by: Balbir Singh