From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4739374A04 for ; Fri, 12 Jun 2026 08:42:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781253724; cv=none; b=NM6NO+/IiJyl6x1Ks/+W4+pqxinp8xCs2QO2SsJ1wf3LB6wr9emKSJLPQf4GY0Igd9/eOX+aFiyQFYdCpNF1NXFOGOC3DIUrWK+gEmY986XqsTq596sFRKWjZ5F666zMikSPXhHpeipV4s02d4CEglC8GaabDJ5TIWgpaY7rKw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781253724; c=relaxed/simple; bh=8t+oQ/MAeRgM9WAvXcEp1Dd4GJpKy0GTEo0AaN2ZQrU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H15EhaqFCAOjv8AWTNowu+PvHoerXy8XJd8Cf1RRJ1UmUIfpLwejsOZ5jS9tEuejj/cyccNVnW4puEXBT2ayjEpBsG30RsCrjhsYdghWjGRQtSASsKRKgBd8T6L9afzwqB1XQa+H9FySKv2zPwarM9+qm45SONSNRPEzLsPftuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kjToAs3H; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kjToAs3H" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490b23c828aso34765e9.1 for ; Fri, 12 Jun 2026 01:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781253721; x=1781858521; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=h8kiyJfpS4AJieM5GN1HD0Jnn9d/pspH0taYDU8KwA8=; b=kjToAs3HKZmrmuD2JdmcW6/kb/Glmjwb9OvcTHYzDk/TDfR0q3y+HaHHwZ9QaXz8xO 1S1GO0NIW/5tNk4TVf5pKiZmg5lTR7aQ9U1viop5J4WBcHp4bmvdbiDWkfB/26mdhlBM JyfVcEAw0UeK5UybYQVLxaGtv17yEIQ8q6IQXS/HW7gbA5ZKeWav/InWKgC8iR3hF96y wkxXoNwJtR4ma8hol6AgVl06QqjmkHwM+a9GB6DJ6AEBKuCxd9MvoD2pJWoPyzH0WdHH TXT1SVgIsB9hZOtV45xuzZ7NFop3xxWk4p/7q66Sudg1Tycj8OIZ5cmE+42HPWGDXmsn hDPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781253721; x=1781858521; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h8kiyJfpS4AJieM5GN1HD0Jnn9d/pspH0taYDU8KwA8=; b=fmo9vi+frz9qmHK8WMkKkSauled7I5OOLYp21IAdH+pcu1Dcmu4pVEQcmjDNxGZIoY lYzOxwiwkTd7mTe54ohuMl5OYHFEYiXroSowrTIgEdIOxdMJwQN6WvkNrp7m7/jcgofU DqjehXaCWkKxJxTiOcmwyZpR5fX2gFuZIfVurCcGDN+qwK7qwbvd0BdwIVPeAZVrGdPE tw0Ul+ZbpHLYsFIz/7vTLO+/eYNjF+XBPFKHeBKYOsSg8X4fEdhO0dYAAA0cmH8+JIh7 WVUzyETw8leKQTzD4vMqHIl6gaDSqBJm/r3Ahl7AoYUYu2Q+zADB7nG0Qwd9LS6VS7in jnBQ== X-Forwarded-Encrypted: i=1; AFNElJ+z135O6D6EvUe6kpicx0yYT6IZclFuCL3T8f0yET1P5XRvdi49CI9WE66IGCdZX0LJBppew+G/k0Vc6gI=@vger.kernel.org X-Gm-Message-State: AOJu0YwQ5EsVF6SYrE9n+L06bysaxnpa3nUajukJCvE09LKTAqI4069z PeKwATL5OIJSi6sybPsHMlDoA8/1PWT5x2kQWsgBtZciH6yylzvTZ/9r381rx3bGpQ== X-Gm-Gg: Acq92OE61B+SwFwdRX8BmPxrZrvpF5FsB9cgZ0vzFkFDiVfIZlkwoXDdW2wSkAgrYis fT5aT3DZsO1Hpr1rY3+RyYJYOBEtwR1mXJBSxbZA//z9zXEetN5deC4GnBdmzEjgra2Owjl5d79 J+RkAvPxCjcO/PLIQ752iIYlcvSZkmF+CCscoNMeqHPI0EdBbtD6KOhjQSD8i6FbO5tntXENhYU kM174GCJnH4xsn3UR/FK6C8/V4V2UVJF7C8MNUjVVs8H+Ws6oS0CaUFvLsM7yzTRtsGs20kB1q5 ve6VNCYQye0Kb8OMo5Rtig/BgwBQBIdLgJoQWNSWutvV6NJFbPhcqVbujtD2+gU8OCGg08uAXuP RubL6fOcojj1O0WEwhifTp0uMIaoKLu79njNMUM0L3miwv/74WLEsjPJ0o4yf1cceZ5dX5itLHP DX39KyN8Xzy8ZRi7r951Q1TVFr72QjecQgQiVb0xHaH+dK8YbgDOGTzXmiZMLPen7YiLejHCTX X-Received: by 2002:a05:600d:4452:20b0:490:b2ae:44e1 with SMTP id 5b1f17b1804b1-490eabf94bcmr544755e9.5.1781253721001; Fri, 12 Jun 2026 01:42:01 -0700 (PDT) Received: from google.com (140.240.76.34.bc.googleusercontent.com. [34.76.240.140]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2cf5537sm158942595e9.9.2026.06.12.01.41.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 01:42:00 -0700 (PDT) Date: Fri, 12 Jun 2026 08:41:55 +0000 From: Mostafa Saleh To: Jens Wiklander Cc: Sebastian Ene , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, sumit.garg@kernel.org, vdonnefort@google.com, sudeep.holla@kernel.org Subject: Re: [PATCH v5 1/6] optee: ffa: Add NULL check in optee_ffa_lend_protmem Message-ID: References: <20260526151934.3783707-1-smostafa@google.com> <20260526151934.3783707-2-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jun 08, 2026 at 03:16:49PM +0200, Jens Wiklander wrote: > On Fri, Jun 5, 2026 at 2:01 PM Sebastian Ene wrote: > > > > On Tue, May 26, 2026 at 03:19:29PM +0000, Mostafa Saleh wrote: > > > Sashiko (locally) reports a possible null dereference under memory > > > pressure due to the lack of validation of the allocated pointer. > > > > > > Fix that by adding the missing check. > > > > > > Signed-off-by: Mostafa Saleh > > > --- > > > drivers/tee/optee/ffa_abi.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c > > > index b4372fa268d0..633715b98625 100644 > > > --- a/drivers/tee/optee/ffa_abi.c > > > +++ b/drivers/tee/optee/ffa_abi.c > > > @@ -698,6 +698,9 @@ static int optee_ffa_lend_protmem(struct optee *optee, struct tee_shm *protmem, > > > int rc; > > > > > > mem_attr = kzalloc_objs(*mem_attr, ma_count); > > > + if (!mem_attr) > > > + return -ENOMEM; > > > + > > > for (n = 0; n < ma_count; n++) { > > > mem_attr[n].receiver = mem_attrs[n] & U16_MAX; > > > mem_attr[n].attrs = mem_attrs[n] >> 16; > > > -- > > > 2.54.0.746.g67dd491aae-goog > > > > > > > Thanks for fixing this and for including my other patches in the series > > Reviewed-by: Sebastian Ene > > Please add a Fixes: tag. This patch is independent of the others in > the patch set, so if you send it alone with the Fixes: tag I'll pick > it up. I posted a v6 for this patch with the Fixes tag [1] [1] https://lore.kernel.org/all/20260527150236.1978655-2-smostafa@google.com/ Thanks, Mostafa > > Cheers, > Jens