From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14A903FE65F; Fri, 12 Jun 2026 16:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781282486; cv=none; b=t0x4AlsNJ/BqUgOYWf5dofPMQa1kT3PkbJCVCzCt7WapFDiCmUkrDtrEHvZtJ2Ngdhk5YxVJNWXaExpnhW2YjdQ2dIFRQ7izT4hY9XQ+KMi0WrZdJW7d1CJ71nqpStOuhfpf+NaH4J58K9KR2UEmZ/3PX+rCxyjNr0w6u1Qvksk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781282486; c=relaxed/simple; bh=hpIOFq02kqJlChjw+UQcihDpokRd9fou6FOwtsRenUQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RGiJileTfUDag8tMdg489JC6OCPCRnaaU5BlqFUAUUyiiw91f6zPn7IgpKiZov9Q8yRCQkqZ6qhjO6cHd3eZSYla8xh0Eb0L4VeFnEpo0k+EfaS7ON4svbpQ1iVIkOd9Wpvd0KIAA4RnlFfUkvGqBrTRpbjBhSDQXKssEHispzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kk4bDBKZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kk4bDBKZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 804C11F000E9; Fri, 12 Jun 2026 16:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781282484; bh=H6VSC3WKELPd1vO7ngpqqEQy2JlL/CllqgvI8yj6l6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Kk4bDBKZqjNkLC3tSiq0hps9LjFbfbWci+mM369v/l4k8uE7AdNDr1YBQK1oeYRde OAR5nw5HVAJtDXPtTd5LrptPTsp+HJpIncCT6IoIkzvlHbg8cS0FTK60lfBKd19weY B+MyXzq85KBzgZnBWM/M8GhcCSzptqJiSD25XDiqQfzWltZsTrHJR08+/qnA7LLeRw CSwLa8mGVv46VmTIQdnq3t25Pb1Ah5kh+7/n2gfp8CQ76Ai26e0/CnPK81yZrsy8Zz uzGsiTWiKEQ48GDnjoeRPYQUYKXfrldplWVoUYlVqe5mX18aHEzwLV7in/n9h+XUKd qnkKxDMmOQ6SA== Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id B20DB1AC5AC2; Fri, 12 Jun 2026 17:41:21 +0100 (BST) Date: Fri, 12 Jun 2026 17:41:21 +0100 From: Mark Brown To: Biju Cc: Liam Girdwood , Biju Das , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 07/11] regulator: renesas-usb-vbus-regulator: Add RZ/G3L VBUS regulator support Message-ID: References: <20260612143048.317907-1-biju.das.jz@bp.renesas.com> <20260612143048.317907-8-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="prfcgpyF4G2Ul5+f" Content-Disposition: inline In-Reply-To: <20260612143048.317907-8-biju.das.jz@bp.renesas.com> X-Cookie: Nice guys get sick. --prfcgpyF4G2Ul5+f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 12, 2026 at 03:30:35PM +0100, Biju wrote: > -static int rzg2l_usb_vbus_regulator_probe(struct platform_device *pdev) > +static int rzg2l_usb_vbus_regulator_common_probe(struct platform_device *pdev, > + bool multi_regulator) This multi_regulator thing feels not super scalable - it might be better to pass in a pointer to an array of regulators. --prfcgpyF4G2Ul5+f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmosNrAACgkQJNaLcl1U h9AwyAf/b6dSy62ZTm4smDU4sc9Y3OY1vT9QG5UOJZPQjs1rncdhwfjJhypYsDM+ DfOvt+JDoQGSyv9p57eRbXT0+97KOSlSRamQZrHfe3qgTBo0xIMtNcHJ+xZGxCw1 TR5K/Hne+j2636zjLx/Y3T29qNtgyLs5+xaslZcypWpRJ0tC57JOgFqGHONfil69 6EtylIojLnlN68QxLowKldFfiKD66BVwCwPxgDt2zqGuuM9qnXbsH9lsCoGwKMbw LhdNyqPx4Xja5HqzgZhRLcysIFF227bU0qyo62Vt9ucDl37O5R1IMKdGB2uFZKcx jimK+cp6eDATGP0NHA+SwPR76hsgiw== =qppE -----END PGP SIGNATURE----- --prfcgpyF4G2Ul5+f--