From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A47F21CC71 for ; Sat, 13 Jun 2026 06:15:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781331319; cv=none; b=utmwdystMT+nvarcB/+Z66z/15aSIryDoURBDRl1Y8IIg0mB9V2ScIIcpK2wdWn6PkzG9SyvYo0Slp7Xj+tHWatV82PyeZDrSFJZg63BjS1cHb5X3xQV7IyYzwvXzq6TqPHnQVHSsEbl7sXQH8c8N5gV8GrA1M9wjvG86pyv+D4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781331319; c=relaxed/simple; bh=kvgu2pwMGJHdiz92AYeJ3+oJ29XoTJnTSAyWyiLRUiY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iiPJtq7lIjiIH2EOV8DAVYgpj24aIe8vs/H67cFkvhndlivTZ+lG9YjFs5HUjA2lwxe06ndES5dqk0x5cR+lVkUh5WVsTdsZpHNj0IYrKk3VjrlXX4p/pibYXv3imNYa+cDtYZcsqqxAjsl9WegiSStHWCJdK8QfV7fyGAHi+vw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MAHftmF0; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MAHftmF0" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-9158643e538so158799885a.1 for ; Fri, 12 Jun 2026 23:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781331317; x=1781936117; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Biw74RXDhRrXl/+hvcvrUJ20txGwKAJRoRdTi99B8aw=; b=MAHftmF05m/Dck26+BFHlesRN2lwAcFcEBxOno8jjmt9mZwq03PdkSRdVuXzxn5vBR CSH3IFHuXWuMwVDpzdM/JZRsk/UYx3FtBGTmiZuiGxhl1FYnaPvQFqkYsyTJ4NNmSZNE odMOBMNrQtiObeIGI9a3O6UTX3bTaC4Y6pUayzdZls2xb8z/TrY+O4KQfIKB3LTEsuw7 E4m2XOfTBP1QSMiyRZLr6bK/zvO+sGSLOFCIhm+WZC7BHXK9WhqtWHITm5zuljKSv1XC yu+omTO5C4lq2hTb88ZQ5UBtnkK///AW61XUMLiFfPp1GnoyHMZczHJNy+hQxbIGXoJM atTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781331317; x=1781936117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Biw74RXDhRrXl/+hvcvrUJ20txGwKAJRoRdTi99B8aw=; b=itH0oQzI7L+10EgNItOeX2j95T3uFrrNz/7Qu95BMQIbi8Onwm8LNQgIPnmYEVXSlB gLaowzGB9wRWvheEAxygGemcvhWniWPXRcEOG2vNGZjaIGbwOA8dJWEZWtwTX2FcakI+ XuY3yWCTnHBXf4zINX1rZTlhZ6NsGSwOUkSN39ABFMSzc+MjQhHiXUEWZvOh/yZPLClQ HKI+5ZiUzwwXGucmSi1ryyQYg0JzpDNaiFEyx9XeBGz99DrnqsU2MznBoA7PvC2bA74i rcTaZpOHvh/pNkRiRnirugn4IvuwOmX8SxwhD41hlsP8OLYo21C54dq3RohA1QW0duSr YX9g== X-Forwarded-Encrypted: i=1; AFNElJ+tas1pPXj3FPeHFgxe/kjSvrRqKUbGozG6dRtchdsRCfXlmHKd8ruAdUbxo/RVsS0RIyORlIRbeSm54R0=@vger.kernel.org X-Gm-Message-State: AOJu0YwClGQeCSDH5WW9xXRDRq27Ux9YNLvsPf6sQVAKGeF+5mOlPlR+ YAiCjv3TpADG1OF85itHMIQ8AyAwfhLhVGelpuyh0MfXk9YFu7eoxZhH X-Gm-Gg: Acq92OGj6vgzXyqQ6RJ5/4wKhz7Mj4eu01GR/n6J9a1PIWwHWUcF3b/aDoijG+R4CDJ 8F72tb+D4OkBCjjy85PxiiI7pDrvzpWr8SfcUEqUgmWnrBev9vg6nlhC2Do/HivCl4kBFLFGtmq kuraeuv6k/4MNUXfhzyvwf00slfBHqs6CC1pFVRwheXOW2gUME9z/l1c8us6nmCZrMVSEW5HuvR tEzyqcFkIb+baS1INT4UK8oFRxYGI9ybCIOb/qRGoDIig+F9I7v0jn7JbIKEUKh4wmGi5hNguAG pDBv4o2Zz75AptyC7YOjWgoi4WxhDmmccQsBu3sCCrvtN6c4ZPHQ5FAXUs3P5HO9u07BbJFozug 5itDKvFjM5P7bl0LhmpLB76CvYeFNe1h7w6RNji0r0jYaCF7thRhdaVTaTff2SsyWSrQjaSt4VY phgzryM68rhpdh835HgP5t44Qtl0Y= X-Received: by 2002:a05:620a:1725:b0:916:18b1:ea5d with SMTP id af79cd13be357-9161bf58812mr898215585a.39.1781331317132; Fri, 12 Jun 2026 23:15:17 -0700 (PDT) Received: from localhost ([43.225.189.75]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9161a006426sm417186785a.22.2026.06.12.23.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 23:15:16 -0700 (PDT) Date: Sat, 13 Jun 2026 09:15:08 +0300 From: Dan Carpenter To: Brock Haftner Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , outreachy@lists.linux.dev, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: audio: add missing newline to sysfs_emit formats Message-ID: References: <20260613014905.48458-1-brockhaftner@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260613014905.48458-1-brockhaftner@gmail.com> On Fri, Jun 12, 2026 at 06:49:05PM -0700, Brock Haftner wrote: > The sysfs_emit() function is used to format strings that are returned > to userspace. According to the sysfs documentation, these outputs > should include a newline character for visual clarity. > > Fix the checkpatch.pl warnings by adding the missing '\n' to the > sysfs_emit() format strings inside several functions. > > Signed-off-by: Brock Haftner Please don't do this for existing code, only for new code. There is a risck that user space relies on the old behavior. regards, dan carpenter