From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013068.outbound.protection.outlook.com [40.107.162.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A961F39A81E for ; Thu, 25 Jun 2026 14:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.68 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782397709; cv=fail; b=e4agPUyB832ok+pdXgVI4DC8hn3IFlMfGoxON6Du/WJZNIgJNXkfaujnRfTTPK59+kV5s5Lj/Wl52t6LkW17QcU2S1QueSq+ISnzWrw++MkwTIVPHlvgt+cjufBJfwjImDV3JBKHxYsbm9lYrYMHF106JXJ7KUVAV+KSkYP+FFQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782397709; c=relaxed/simple; bh=zeQrzYdJ1DBcI56kvQIzD41gkEtWitj4tKXczXtvZ2w=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=doRdYqrL7eMQaSC3GljAhjk/3+ecQDmHvoXZdLYtKdxLZt2o33bTLX1X3MzQJJPtoY6/SL7W7AilCe4nIblPgn9QkiWGH9V5fvVdM6s6k24gEdDJKDG8pJ3H5c4bozcYIlaNSZr3ldWoeRzSaGPrgnrZhzFwh1egILphc6R5rZQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jM0WqmNK; arc=fail smtp.client-ip=40.107.162.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jM0WqmNK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kKimwNhQflp93TQfetXTC3a3XIFDcGeJGQgkDM84p5Bg9RUwlB1fg3Om80MqHW0XZbfh1+CFH2PY7xnmeunhZ16pDRp2t+W9KaJZiPMqf+uUVmtrjf1wRPHc7qXz+lTHBkXEHduzrAKQqLvrNCGcEKs9pbGhpd86IhK5TjoGJKozUpO731yGxHpjinYNPS+/h55uxkYvvmVuS7zymCm9ZwUYgOTuOuiIXn4i3yQOg5KwmB9xxHNItLCrqK3y8Ox+baj2AK8F8PeBkyJkGFTOd3fgbG24xVnGRkm+N7mGryvQ8lrtq4yuke5fpiXpUTwPJicXPQQ0bCKHwmbbbtnyTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wKPK5QhawMXRq4cv5jGPhaE7ucZ6XetpH6P4Q1x2AXU=; b=ItygnvONNxMQG/98o9qOiXHZdksoWSzYIcTjWq9pi7/xfpjgmfkNEuTUlOioYBRrRENsP1KgooCRvfgcd99WM9nHv8Gtj4hUwXCYnIoSpZI4jxVbQvFtmW5ylF7sEfrHj7efckKtJd+hSW3skR4d0Z2hQ5tubECTa7AIwPWpOfcE8qW/q5dlUg+sh2mVZfNLvLw8OapuiMq3Af9+jh//zQek4EgTVtC+3HPTUTjjDnYlQ0xRnvbg0i/3bTao2seNWdECSRhLa1SazjE8IKx6LD/0yw0AvwcIgyC9Rntkga0g3QiV+JBs1xosmbKMmdKFGv0B5mKgR3fw7qenqtddSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wKPK5QhawMXRq4cv5jGPhaE7ucZ6XetpH6P4Q1x2AXU=; b=jM0WqmNKEpd6Py57MWTn3aVlClH+yxenm+GGvZemcFbAk9/cDtNM4Gx7JXdNB6wQbnDys6snSvxfVvCQUiqyRC1A6xupuzURoXTXAo3oyR8sluqQz/NHdHPOpxlVhlhO96G14CxYo4n4d7aYMmxM085s3Y84keki9w3ICYOe5mdD9baxyblcUBIm9q7oE/P4sKLOcE6jj6dwrQAdDgbhORIVXchhhlXM8qg4d9AiWhLXBdpkEQpNdR0QBpVrmiqQy72iEeTQ1gbcIEDr4XJQ2EbDSq62to8lwLE514K+2u419VhZzLzrxseAOVLJ5SH/8mM8loOxLPvHwZ695iSbYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by VI1PR04MB6976.eurprd04.prod.outlook.com (2603:10a6:803:130::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.16; Thu, 25 Jun 2026 14:28:20 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%6]) with mapi id 15.21.0159.007; Thu, 25 Jun 2026 14:28:20 +0000 Date: Thu, 25 Jun 2026 10:28:13 -0400 From: Frank Li To: Pengpeng Hou Cc: Wolfram Sang , Tommaso Merciai , Alexandre Belloni , Frank Li , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i3c: master: renesas: reset xfer status before each wait Message-ID: References: <20260625030357.87402-1-pengpeng@iscas.ac.cn> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260625030357.87402-1-pengpeng@iscas.ac.cn> X-ClientProxiedBy: SN7PR04CA0091.namprd04.prod.outlook.com (2603:10b6:806:122::6) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|VI1PR04MB6976:EE_ X-MS-Office365-Filtering-Correlation-Id: ab5d3bb4-3363-47f2-4da9-08ded2c60166 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|19092799006|366016|1800799024|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: LXuMYBLj/bzVFmdKJtYcfxfkTATdwYe/I47K16gU7a0TkU3ZMuVg29zLh5pqG6Nc/vMtfoahyVN9P1ypk9yaG4aPvErvjCagkAe9m5IeZhSwOJGnWHuoDm/ibLfkPdiuNYFDXTJXfM2GPbxu/76nrLYXEqXwGT9csHk9Xw9LqaruZGd2tlS2QWmtL+GWqs4i/DrBsraO+ac/EczpNuyuowKh/KF407cr6wCvLAbwJPA9H3mRgXKFqcj3+qeygSMrW8q87ARdBm359jR1P0E8Oo5YLlyUDoeYG1+Cu3S641dlQk62TXWaxugGJOO6brYWxvOd+YELC6YCqrNmFEwlG2b/iJ0GOVrPXAcOyubt+D/PnAHH55VjwqL0BRfa6ONBpqfx1+YVpYeVt3GILTTs9Z9J/FLTGbI72JxbkIfU7KQ79RCW8O+CUAAHBE8uA0bqe7TVbJqoy/sRqNuo/Ctk1ZIGYiVJNjIJ+0d8rgmv0aD4Y+dDmZ/3vq6KBkesQ3EHqrVhEAhN+o8ArDqhmXrKG/sxofaWKqLHEj7lgpyditBLWDHgACh2P6R4Ie4U/3C40L9UNV8yOqTzDVYMGl1RR2WApr9ZRGxhNPm183da0HQq42wQIqRnQK4gu5VryeUznM60T02ZDGbE0gQuB9gP2AeNS5x5aLQfjAgr4VVav9s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(19092799006)(366016)(1800799024)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Sz3B/WCsLWO7TVWWy0pejvW5W2ug5QvDEG8nw2138fmWfr5w02J5uGY6dBgx?= =?us-ascii?Q?8Glo5AqGG82k9or9Sin0wQiBGGVWEdwuqdQFSMG2r8MZ1HjRF+LewXyFCtOg?= =?us-ascii?Q?OHb92dTrvX1fSncECOQLORZg+JggBXFPKSmBFmyOTcuUGvA8GOIs5NUP3n5J?= =?us-ascii?Q?yuz4J5POgAXN5uc1lZ4kt9RajJbMwmE68auf10T4eP4gGcbfaJLgnfsDcoWp?= =?us-ascii?Q?fLCaoRgRGqwS5QsBg2qdYmWxLxBLaptCmVBQXVsbR9GiKRPJhVHlPWX0OrfX?= =?us-ascii?Q?CbafVZHxV7DYSnm57sZeBAsbzHh57POC+C/Q6o3LH0NccfbXjOD8L+r1vFru?= =?us-ascii?Q?/QAN+/C3ojC0+uUcoOgKsU4f5gvcKAxTm8QmiR+iDeL1Pc50tel4ojvfBaRl?= =?us-ascii?Q?pu/f3K/DLHEOCA4xFj5Br8SYdWBAAN0KmXlhdGUaMRoG+/i3Y9YKkAphddi8?= =?us-ascii?Q?kTaAPuZ1dVWMx7HigwrPwNLYWhEMtH4lXX/thiD7fzNfvQ+KiKnh8q2CR7gP?= =?us-ascii?Q?AbH0DVMS0wzB+WXliRTB7A3RhbrVEbGd1HeGgu6PA3a6HXmfFW3WmuHGrJvp?= =?us-ascii?Q?hlllA2mRy0XRJ3lwImjdi8PcNX4RVJhBLqvB6/LS7EckAtL9awd8XCOgwe2G?= =?us-ascii?Q?6qWFiFev/Ohbn4+bKaozJZu4D7y4NF4M0ufICxbMcNLdf2Xz1Ry21h4OtKds?= =?us-ascii?Q?rh1WNcCnvyqbVEk5AMb9cHwSuVRFEMzD3rN9dxwPBgMSuR8hWL4ARiPRSOgs?= =?us-ascii?Q?slBEQoRT++LQRk0nY8oe1Rq44g1UqKMiBJkH2TP5KBF5dnmNeXbe+IE68Gde?= =?us-ascii?Q?UzB5HmRGBmhASkgqn4EfhyKVGUxUYWQhmVFRKujwtsvgVxYtozHlwZ0PRWNG?= =?us-ascii?Q?BhOsjkzDifTW+CbW2rwVM3s8GhyyqARd0b013f+6ByqRjq7NhmSBtLkB8XM0?= =?us-ascii?Q?+m0/u2jGUcbMjmOlCaXVMA19rbL4XxtnJ+15Nzjew4irB72mpxXvJ3UXer10?= =?us-ascii?Q?74hpF58tTzoFC1UmlcbA70j2mnC/chi+6KJYTHJDTugiLAvJaoDXd/G1XnHy?= =?us-ascii?Q?UhS2AEVqp7EophnJkzWGht7hssfci0i/MoRlGBQE61KytDir4mt4fpTgo+cg?= =?us-ascii?Q?OXzO9FJYsKBROUfJ7jZpUrMT0K+e2U2m/e4TIHBolxZanDE6pVwLEWqBemYh?= =?us-ascii?Q?l3QN5K8/ZxH02F6FctcFV3RndpJQpubN9ongysSwnkBlFxbANfqf4i40RUuc?= =?us-ascii?Q?y8H8USSCD2DWjYnZ8WfXVPrhoJmDa4V3r+8Yl+o+sdZ0+AoUHSDMD3Y1cfwf?= =?us-ascii?Q?cPUkyoXDGMJLhuhdZ5TKbh65Q2PGju5hqYehsGYVXlttJrEqNWnFEsbIE5lG?= =?us-ascii?Q?UFhOydlvIFxdkQfXJTQgvKv0K0GMg/WcLQLDDN/74lkETa10KU4L05c+b0nG?= =?us-ascii?Q?MW5bgH6hOcEaW/AdU5abk7UY2a2kWmOXfnBXe6huoDFeML6RAy/KWSnu3Xeb?= =?us-ascii?Q?/Oj8GtDKqnNld9BAfBfx+lfg8mwqUSm2Y1/r8zFmZhnqHS/wSJ1r1iTZ9xQ2?= =?us-ascii?Q?O17gPxyzzpCzBAfWCg3Q52ojgywCU5yBCIasMHwYy28SkQ2tAGf4+iOv0eTJ?= =?us-ascii?Q?5wNRjdQIwixtcYGH8+ZEKkNYvy77wjMr0pYWw8Qu4AN8AL3awctXum2At4aB?= =?us-ascii?Q?+WIfbnjGOK4dX9oFmyH5MZzpth6ZrtSrc5PeU+J7mCBZ0G6bQ3lJ35pF1drl?= =?us-ascii?Q?ipKw2aYjo5Jn9X0BVcnFRTL8Z4egKfsgir0bYDPT2A0YLG9Q1RhW?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab5d3bb4-3363-47f2-4da9-08ded2c60166 X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2026 14:28:20.4330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LEWP0FfpQElsyd1BsEDHu+ThMIKK4Ew7uL6mNTN6IUnV1NaaKmR3vZG8l9xKbjdq2nNn0fOIKVzc4Qg4l9OEGImMTRTdBeFQJ0RPmwHECb7lzZ0hAdBFNgKfy8pAO5Ju X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6976 On Thu, Jun 25, 2026 at 11:03:57AM +0800, Pengpeng Hou wrote: subject: reset xfer ret value before each wait Frank > renesas_i3c_wait_xfer() reinitializes the completion before queuing a > transfer, but it leaves xfer->ret unchanged. After one transfer completes > successfully, a later timeout can therefore reuse the old zero status. > > Reset xfer->ret to -ETIMEDOUT before each wait, return the transfer > status from the wait helper, and propagate it from DAA, CCC and private > I3C transfers. > > Signed-off-by: Pengpeng Hou > --- > drivers/i3c/master/renesas-i3c.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c > index f39c449922ca..7f123cd72cdf 100644 > --- a/drivers/i3c/master/renesas-i3c.c > +++ b/drivers/i3c/master/renesas-i3c.c > @@ -433,15 +433,18 @@ static void renesas_i3c_enqueue_xfer(struct renesas_i3c *i3c, struct renesas_i3c > } > } > > -static void renesas_i3c_wait_xfer(struct renesas_i3c *i3c, struct renesas_i3c_xfer *xfer) > +static int renesas_i3c_wait_xfer(struct renesas_i3c *i3c, struct renesas_i3c_xfer *xfer) > { > unsigned long time_left; > > + xfer->ret = -ETIMEDOUT; > renesas_i3c_enqueue_xfer(i3c, xfer); > > time_left = wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000)); > if (!time_left) > renesas_i3c_dequeue_xfer(i3c, xfer); > + > + return xfer->ret; > } > > static void renesas_i3c_set_prts(struct renesas_i3c *i3c, u32 val) > @@ -687,7 +690,9 @@ static int renesas_i3c_daa(struct i3c_master_controller *m) > NCMDQP_CMD(I3C_CCC_ENTDAA) | NCMDQP_DEV_INDEX(ret) | > NCMDQP_DEV_COUNT(i3c->maxdevs - ret) | NCMDQP_TOC; > > - renesas_i3c_wait_xfer(i3c, xfer); > + ret = renesas_i3c_wait_xfer(i3c, xfer); > + if (ret) > + return ret; > > newdevs = GENMASK(i3c->maxdevs - cmd->rx_count - 1, 0); > newdevs &= ~olddevs; > @@ -800,9 +805,7 @@ static int renesas_i3c_send_ccc_cmd(struct i3c_master_controller *m, > } > } > > - renesas_i3c_wait_xfer(i3c, xfer); > - > - ret = xfer->ret; > + ret = renesas_i3c_wait_xfer(i3c, xfer); > if (ret) > ccc->err = I3C_ERROR_M2; > > @@ -815,7 +818,7 @@ static int renesas_i3c_i3c_xfers(struct i3c_dev_desc *dev, struct i3c_xfer *i3c_ > struct i3c_master_controller *m = i3c_dev_get_master(dev); > struct renesas_i3c *i3c = to_renesas_i3c(m); > struct renesas_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev); > - int i; > + int i, ret; > > /* Enable I3C bus. */ > renesas_i3c_bus_enable(m, true); > @@ -854,7 +857,9 @@ static int renesas_i3c_i3c_xfers(struct i3c_dev_desc *dev, struct i3c_xfer *i3c_ > renesas_set_bit(i3c->regs, NTIE, NTIE_TDBEIE0); > } > > - renesas_i3c_wait_xfer(i3c, xfer); > + ret = renesas_i3c_wait_xfer(i3c, xfer); > + if (ret) > + return ret; > } > > return 0; > -- > 2.50.1 (Apple Git-155) >