From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E7543DA5AF for ; Thu, 25 Jun 2026 11:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782388705; cv=none; b=MbShUMXTMrHgzdmpnoNYTC8Lp1eGnaGDVct2lTQ3I3nMUM8exXxTz2MuT8UyvkT2h7vpvPFsYGCmM1QrdP4kXlltuFuTNItZ2vJA/aVkVu+74iZjjvvQO/Qzs/Szm4KHH63iggHRqqGt+n7otaOlggoYbLAjFR3Fk5ThHK6KBuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782388705; c=relaxed/simple; bh=3eDaWhVrdaI5qhweYpUlO2HERuSAQJQ4eQARlgRWWQM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SVYl4QK6WLpIwwQjx3Y+611WzH/DDMpN4qY1PWJy9FrVP9Hd3XyoubCTYeqpZ5SxpWuotuT3HEWSqk3s6XSQ7OtDUqlmCg772df8XyGaTrKW4tsdodPiTNHXZul3fN2UvmChI30JxI66ZDzqkawv+WVqSlq/6ivkkrwfZxYMZRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hK4JFKBf; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hK4JFKBf" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-4864a8e80bbso1247742b6e.0 for ; Thu, 25 Jun 2026 04:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782388703; x=1782993503; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1cMFsB9TOtodHy+6dDwE6KCdh5Q1jF5GsF6eebxqdQw=; b=hK4JFKBfa2BOz7t5Fi3CJDG2wdIZFy5IkNvc4nesf5OAWEX+gilv9GoBbpzRB0VWdC SMtPsKmPjIVaupmbEGEC3dw8Z0qZtzWjjaTYZozQvpe/1nMiwL5ofNBCAk55CHP7kprM KemuixU3GLaNnFhxax1bV98/A8hOIKj/o94zC/oy3f3xUXzI/+QehQBkm6VfqpxfD9Ef KlFwb0GKLRsdBI6CT5XC7puG1PK/SLSyaT/wBU07Pd7nlu0/oVxpcjKcT4cl4VDTokOW 6tQZ+iUjnV8/jsaeJcKww21Hz428RTStl9K9iiNWLYj9lm9ux/VNxMlJ9vBnag2Yi+N1 RdhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782388703; x=1782993503; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1cMFsB9TOtodHy+6dDwE6KCdh5Q1jF5GsF6eebxqdQw=; b=kX1kWLdM9243AAYMSq3n2vBmT8DpyH+K6Zgm0bvCbahh76m/sep9kby47LsqwfUEqe H+7yw2DQ/rSVidm4PKY8s4avk9bkyfoTOd8b+imEO3ESY8rOP/w8fR7cdvH/D+388J47 aYd1l50dXzvWje72q5bRhQdKD6iLiRl5ifzc4SODM31pJnD6yhC7Dnd3ZFbOCu0neO6h rcCE8fxebXblRxL6TTOsaBdlDjePWK3ZpZfuZk2rkW5my/VZ7kcX5EBGO3A5bCdp/RA4 dMkQht25fiHBYg0TYXzwWSCVwp7orUu61e8T9jWt5IiC84d6OV5dHf65S2vckar5bjQ0 0F0g== X-Forwarded-Encrypted: i=1; AFNElJ+VTzqLpWnW3xUuJDAEqNaF6e/Cx59HwnQuBm6DLn+huGJMozWnTAnNO9l5FbmpBbXd7i6BcXCO2R6CZLA=@vger.kernel.org X-Gm-Message-State: AOJu0YwrvFmPUqydAQNyxiJANASGv/B4xqeo8jrxjUYSllb0atEERVLl lRxir5pdDZ/Vu3+Z6sNS02xxpmRjA+TcnOACa2aTzKqvbKriduTtnZQABsWj8Kxb X-Gm-Gg: AfdE7ck+7QrRktEcLNhXSyMisTlt9C79xDrodnKEQESMfJSvs2yUI6zDpAfIjf9KZGO ffb3bhiFvfB9RFNtdX2yuZJff76I+4gTS86nzlaikFstuJa0ibzZrutp84DC0iVgqjDQMcln6Fi TAAo4Tg0VZIKXIihIebenLTTGde5tCiz2YIVMcTzZZxcBzqPINfwsq9Y2m7vMfZITv8b0awDTI8 MBFSeYXSHz0n8n1d0C6Zl6hUH+6qJ7Pf82h8qpwioOA2He2DnVD8SOrpw01d58woSwS4cBIUMbo C6e6dQxzknueqhDnvfRomLk2r38G7DAG/BOoE3eczCf7zVjZKHVYM7IsIhLxqPV27n3OpmCaJWX e2ZeWCLf6JFFMpt7TrDMICi6oRZuAyKpwNi9BUzXAHrgjfcK1PzQh0iQM/3uLekO0Nsi5y+Bxj+ BRKEYe X-Received: by 2002:a05:6808:16a5:b0:486:39db:ebfd with SMTP id 5614622812f47-49217f19cb1mr2129934b6e.33.1782388703550; Thu, 25 Jun 2026 04:58:23 -0700 (PDT) Received: from localhost ([74.80.182.98]) by smtp.gmail.com with ESMTPSA id 5614622812f47-48aee43c088sm10674654b6e.14.2026.06.25.04.58.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 04:58:22 -0700 (PDT) Date: Thu, 25 Jun 2026 14:58:14 +0300 From: Dan Carpenter To: Yousef Alhouseen Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vme_user: bound slave windows to DMA buffers Message-ID: References: <20260625093137.6589-1-alhouseenyousef@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 25, 2026 at 02:51:55PM +0300, Dan Carpenter wrote: > There are two bug fixes in this patch: > > 1) The driver allows you to set any value for size. > 2) The vme_get_size() function returns zero on error but nothing > checks for error. > > There is a third bug as well which is not addressed. > > 3) The slave.vme_addr is not checked and it allows you to read/write > to any memory. > > It sort of looks like bugs 1 and 2 only affect > drivers/staging/vme_user/vme_fake.c. Actually, no. The bugs seem to affect drivers/staging/vme_user/vme_tsi148.c but the variables are stored to registers instead of variables so it was a little more convoluted. regards, dan carpenter