From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A05DB3DDDBE for ; Thu, 25 Jun 2026 12:53:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391982; cv=none; b=TOtkYRLEbnc2sOAVAga4jwd6HjWPo7VpXPFkX+C4UPlGOipUErlWXyBYvR1P/8gXDDu8/LXvEOoNsyK51KOGStmE2KSDEGSvOPlH9/LS+XbArt6Sat8CTvhQExiRUFid90ljI/RA5z6cD6d0pkWldKJ30ZG3R9djoVac8rA+Xdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391982; c=relaxed/simple; bh=Wu2gVj+SwhQ/qnkaHLMk9iYuRLCsRNkVEumRENjwIcU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q3TjvJiTzOL8LQPbqqI3nd0j6fcXflFFpiJVHW+B8rC4/zlEWr9SfPJ9Ah9orzB/ilS/9RFgvQZx+rvnwXchxgi62pDKHKE9/RBu4Bzr0aHawr/RYH6zxVvknT7OClqg4Fj52EcYC/Id1DlvrJxPFTq/+tom7e5m5F/hRebIYH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=mORjrCzc; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="mORjrCzc" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4922244f7c7so19707375e9.0 for ; Thu, 25 Jun 2026 05:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1782391979; x=1782996779; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Wu2gVj+SwhQ/qnkaHLMk9iYuRLCsRNkVEumRENjwIcU=; b=mORjrCzcbodBsL72vPlECjCsKZHxsNPhWzrA7ZhZ9MazH4LR48JpUsLEb8BoY8pjGd blm3734foDWrKjdO8ZwTBzHZNYO+Iz1UsZfTMy/lm1fOGqKencPFk7XiyOQfSDxDOjI7 DamDQM4GA5nG820Tnk0hSIA2/NjiyORWZCnQQI2vtk10GBhaZ7WNu7CsOrjluM7tMfxN eSdVpX9VX24wHe+Jt+WsvyOLEKkfSCLMNgwU6VvXac4L2r6Rlw8yGWNfjgYFQT4HyBnD GRovWxeEuSe+kLkuy5cB/4Jwjm2q+IyOtH1edbaOfzHxBrNmS3zqWeWkC6Crrmx0jqwK 7Maw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782391979; x=1782996779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wu2gVj+SwhQ/qnkaHLMk9iYuRLCsRNkVEumRENjwIcU=; b=qkxNQ1JkAyMdWoclINinQE0ID6efFB8Uz4j60OY5NA8S4u2dGNRJtFZhZIzJDQqWWl guwngEapzV26d9SEHQBDHENWXfD1DJB8lQSpf6sRU8l2Qq+97QQaYwvvhTlXZpMnUFU7 oiMmHRCbbHsJnprD1ctjH3+UBY9/sgZc6WlL9ZkiLqA9wwnrQFZXKo4LwApx0L9pfoG4 YrpGflhAnICGaIlMjKRlLcw5JYziyVYsdKOF/aJiEbjVKhP3ocX414FoHd3usP/ggUqP GJsUK3bTb7Tj8+3tF3hFZaPI2w1Vndl96eUB6i3pOl/kwL9IksIYPyHSjEA2b1YsGhuN wV9g== X-Forwarded-Encrypted: i=1; AFNElJ/5YGn89dmNfOdpwCpUsCPsDZn5h2o1Je7YzofVAnfl632/D2a1p65RHIBs7BSoUWp0q3/tjGcRqr9sF78=@vger.kernel.org X-Gm-Message-State: AOJu0YzA63+PgsefM8vJipkqVJhV5a2KaM3NPeTyNppagnrkDzOSXEhn GgAysKeSwc5L59k0gGUA83oPn/F12vV4IADjb68R1rxspnEJppJcnb7pvwRUG4j33mk= X-Gm-Gg: AfdE7cmxiTWqdqBvWDV0EJgsCUirFehlF0UqY7eCn4mLDj/BKVZ5MaFxndPBjS1XdvA TTXkmKwcnr7q2menF+nu/ImTUEmZDIvUi+hYbwHESYs7hvaeiAR6zgkmSV3IxmKmy0i0ONjuAoH BJQggXTi39QYKyZzcJspV6Mn/LUQ3vM9Dyt3JhvBbPB8vQjDzx2LtUP++b5CVX0SzUDd8usLI8u /2B7OehbGwHTiXAnw/8YuIkDCLE6E+yS9st7vfOh8OrVZO+FwsDIYR7Tig6VojVKc9Zav4eCBG2 ZKpOQ5WxAlptM5RFVuXsR+BmYfgUXodU66FYiEO5azFZqwTNTjFxDYBE+XSEz6Gz5o9WMAGZWsN 0/4Zlagz01tMkH7vnOXDfpedtenUg/CLkudgbMfBgf/aaB5G1sPe0te5klbf48g7V2CItv+sROg +l26Ag3GQFgLPKx8ZDvRdasmTzy2QSwJpLuOowYrFxI6nVIrihTx/hgMRlmwJ4Tio1wRtUR+wjV gNkW06eg87jyaFSf4otvU63d1sY5/KWEEfHDS3seoXLL+rwn53xbplVcTnrav82KvalbLBvIw== X-Received: by 2002:a05:600c:a55:b0:492:59fe:4a15 with SMTP id 5b1f17b1804b1-4926687e800mr34922205e9.24.1782391978664; Thu, 25 Jun 2026 05:52:58 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4926401a2e7sm100688185e9.3.2026.06.25.05.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 05:52:58 -0700 (PDT) Date: Thu, 25 Jun 2026 13:52:56 +0100 From: Daniel Thompson To: Naveen Kumar Chaudhary Cc: dianders@chromium.org, david.laight.linux@gmail.com, jason.wessel@windriver.com, danielt@kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] kdb: unify CMD_BUFLEN definition into kdb_private.h Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 17, 2026 at 07:58:20AM +0530, Naveen Kumar Chaudhary wrote: > CMD_BUFLEN was defined separately in kdb_io.c (256) and kdb_main.c > (200), causing kdb_main.c to use the wrong size when formatting the > prompt string into kdb_prompt_str (which is 256 bytes). > > Move CMD_BUFLEN (256) into kdb_private.h so all users share a single > consistent definition, and remove the local definitions from both > files. > > Fixes: 5d5314d6795f ("kdb: core for kgdb back end (1 of 2)") > Signed-off-by: Naveen Kumar Chaudhary Thanks for this patch. Just wanted to let you know that I've applied this patch (and your others) locally. However, since I have to update the test suite to match the changes to CMD_BUFLEN, I'm afraid they won't make the cut for v7.2 (since the merge window is about to close)! Daniel.