From: Matthew Wilcox <willy@infradead.org>
To: Nhat Pham <nphamcs@gmail.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Shuah Khan <shuah@kernel.org>,
linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/3] ovl: support cachestat() syscall on overlayfs files
Date: Thu, 25 Jun 2026 13:53:15 +0100 [thread overview]
Message-ID: <aj0ku26XNT7Xc8x9@casper.infradead.org> (raw)
In-Reply-To: <CAKEwX=MedyK8aDM=oe=Hbzo77mJOEp0Pmo0u8N4HhvikosVbSw@mail.gmail.com>
On Wed, Jun 24, 2026 at 12:06:54PM -0700, Nhat Pham wrote:
> I'm more concerned with undocumented/unexpected behavior (error type
> in this case). -EIO was an example that I saw in ovl_real_file()
> itself, but I'm not familiar enough with overlayfs to know if that's
> the extent of it.
>
> But I'm OK with just updating the documentation with a simple note
> that other error maybe propagated from the underlying fs, if no one
> else thinks it's a problem :)
That's ALWAYS true. POSIX even says so explicitly in section 2.3:
Implementations may support additional errors not included in this list,
may generate errors included in this list under circumstances other
than those described here, or may contain extensions or limitations
that prevent some errors from occurring.
We don't generally bother to document that pretty much every syscall may
return -ENOMEM if it can't allocate memory. That's just ... expected.
open(2) documents the possibility, but read(2) doesn't. I think it's
the same for EIO. Any operation which accesses storage can return -EIO.
next prev parent reply other threads:[~2026-06-25 12:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 11:14 [PATCH 0/3] ovl: make cachestat() work Pavel Tikhomirov
2026-06-23 11:14 ` [PATCH 1/3] fs, mm: add ->cachestat() file operation Pavel Tikhomirov
2026-06-23 13:48 ` Johannes Weiner
2026-06-23 14:55 ` Pavel Tikhomirov
2026-06-23 15:34 ` Amir Goldstein
2026-06-24 11:59 ` Pavel Tikhomirov
2026-06-24 14:11 ` Amir Goldstein
2026-06-25 10:36 ` Christian Brauner
2026-06-26 15:18 ` Amir Goldstein
2026-06-30 7:55 ` Christian Brauner
2026-06-30 9:45 ` Pavel Tikhomirov
2026-06-30 10:56 ` Amir Goldstein
2026-06-23 16:01 ` Nhat Pham
2026-06-24 11:46 ` Pavel Tikhomirov
2026-06-23 11:14 ` [PATCH 2/3] ovl: support cachestat() syscall on overlayfs files Pavel Tikhomirov
2026-06-23 17:12 ` Nhat Pham
2026-06-24 11:45 ` Pavel Tikhomirov
2026-06-24 14:16 ` Amir Goldstein
2026-06-24 19:06 ` Nhat Pham
2026-06-25 12:53 ` Matthew Wilcox [this message]
2026-06-25 16:12 ` Nhat Pham
2026-06-23 11:14 ` [PATCH 3/3] selftests/cachestat: add an overlayfs test case Pavel Tikhomirov
2026-06-23 16:13 ` Nhat Pham
2026-06-24 12:22 ` Pavel Tikhomirov
2026-06-24 20:50 ` [PATCH 0/3] ovl: make cachestat() work Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aj0ku26XNT7Xc8x9@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=nphamcs@gmail.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®