From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F04F33C1BD for ; Thu, 25 Jun 2026 13:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782395517; cv=none; b=G48cLdsZ8ttE8GVioQbRTFCZN46FYcDN+ZS4SP0o1iv4JDUqurkwPHMWAjppAyuFiLv2hnpjNUSCjYlFyn52emibgtcUoYUiXys//X2tVfSdEsJmK+29cA4355g6w5vkg2TZQWC+RMRzkAvqD5TPWnGZXvldqAGq8HkYK5Lcs4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782395517; c=relaxed/simple; bh=JDkLWjbmzJPakTXKZ5tOhGc6IMEjNEx11N/rhMAfCFU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d5SgTdLk0GcSteYo87+UMhXUjMA2OjtjkTija/f9oMA080Zkn2WbndNOS1JFbNWyQ8X7VnhAD/83xLABZWCV5BwW3FHhfjhs+lHIidxW4WpLF+Vqd9h89nSV3aSCxZ+FQohp6bM7E+qa0zKw/DiH2mdRQOAMR/674eBO60rGuL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hLAC/xFF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hLAC/xFF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD0381F000E9; Thu, 25 Jun 2026 13:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782395515; bh=Ua5RN1s2i/OqK90Ydax/XI8pp/DaZSEnF259m5rP1ok=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=hLAC/xFFt77m/QH4NX/S+W/YIkDM7I31jYy4HEpODyQ7eKNB4pM+vSlAQGv5gP51l 0Uf5hYOwsydgCtvUmTXcZmg4Oc6wVJbXews0b4QDQL+5oBRgIjTVaBPk5cKjr7Y6HB hlheiHQACCufWXeBzVxxCZZpeHclT8DHTjj/xn8SFgKwTf0NPmVZP943rctl2KID6C qr8QXMafCyZYG8JoQtjEJHkY+TC1uhJ2gJBpV6DFxL30KaW9FkhgggntHgFRgdKF83 C//pawojA1lu7mn1d6Ycvr/82jN/UIivBk0x+L9Yyf3WAEwfQ2+uVPpbqSKGyn+DOf 6I4ZFh8uVKgcA== Date: Thu, 25 Jun 2026 14:51:47 +0100 From: Lorenzo Stoakes To: Wei Yang Cc: Andrew Morton , david@kernel.org, riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, lance.yang@linux.dev, balbirs@nvidia.com, Roman Gushchin Subject: Re: [PATCH] mm/page_vma_mapped: guard check_pmd() with CONFIG_TRANSPARENT_HUGEPAGE Message-ID: References: <20260624082359.2869-1-richard.weiyang@gmail.com> <20260624131457.ac81fbac373f78aa80a516e3@linux-foundation.org> <20260625034629.nmgdwl2c4luwod77@master> <20260624215943.332f1bdcc99a3b85b7df0822@linux-foundation.org> <20260625064102.tcmvrctcqibl54yr@master> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260625064102.tcmvrctcqibl54yr@master> +cc Roman for Sashiko discussion On Thu, Jun 25, 2026 at 06:41:02AM +0000, Wei Yang wrote: > +cc Balbir > > On Wed, Jun 24, 2026 at 09:59:43PM -0700, Andrew Morton wrote: > >On Thu, 25 Jun 2026 03:46:29 +0000 Wei Yang wrote: > > > >> >Sashiko had an off-topic complaint about the surrounding code: > >> > https://lore.kernel.org/oe-kbuild-all/202606240042.ffPsEXVc-lkp@intel.com/ > >> > >> I see this robot reply, but not see the Sashiko comment. > >> > >> How can I view Sashiko's commnet? > > > >oop sorry. > > > >You can go to https://sashiko.dev/ and search for the email subject. > > > >Or append your Message-ID to "https://sashiko.dev/#/patchset": > > > > https://sashiko.dev/#/patchset/20260624082359.2869-1-richard.weiyang@gmail.com > > > > Got it, thansk > > This one mentioned two things: > > a. page_vma_mapped_walk() return without check > b. whether __split_huge_pmd_locked() would split device-private pmd > > For a., it is being fixing at [1]. > > For b., to be honest I am not 100% for sure. If a device-private pmd could be > file backed, then this looks like a bug. > > Balbir, > > Would you mind taking a look at the second comment raised by Sashiko? > > [1]: https://lore.kernel.org/linux-mm/20260624065353.1622-1-richard.weiyang@gmail.com/ I continue to dislike that sashiko does this. Series with... interesting use of AI :).. are already taking up more of the time we reviewers don't have... but interrupting existing review to mention random stuff is unhelpful I feel :) I think the better use of time here would be for Balbir to perhaps ask AI to examine all cases where a PMD device private entry might crop up and to check to see if there's any other bugs similar to the ones we've encountered before? Given Sashiko is very token-constrained, I also wonder whether this feature wouldn't be better disabled (or maybe have the ability to turn off per-subsystem?) In a couple other cases the 'also consider' stuff actually took a bunch of time unnecessarily and I felt they interferred with the series landing. Given the time constraints we all work under, it'd be better not to add to workload this way (having to figure out if the points are valid are a time drain in themselves). Thanks, Lorenzo