From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DFC13C6A38 for ; Fri, 26 Jun 2026 05:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782453252; cv=none; b=DFg+M/tBjKOkKE5/LRpE1FK+4gE27tiFp0ULhht15YWS7mBM0ECt/Mzv82R7ZpRJtPeV3kL1r9VInNqIOIGKfAEy0mhnvZ3IO3R8TzRUNWt93D7pvZBfaD9RYGhhYJHiQgXLI4Ttis+Z9waEwE7+ysLSxWwFJ7AS1gvhoeGqXUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782453252; c=relaxed/simple; bh=/GcFpXL65EmhfXDCTFH2PgDW06dYc3XaEFHjf6jG1lY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S3ddZ9/V0PXM0IfPXQ2yv/Mc1W7cox79JY+g8e1pCHPOPwY+Wpq1UokpmiezV1PvRWUOmTU7P1GFRp3g7Et4xvEfR/OZ0qJHPeVz9fC8z9AiM5+24BllOnMqB5cWDFdNCr5mS3e0XVMk2qPpXJa8JLhYpzZf3PohPcgexUhkj1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RWaKDtRh; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=cK7I7wxo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RWaKDtRh; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=cK7I7wxo; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RWaKDtRh"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="cK7I7wxo"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RWaKDtRh"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="cK7I7wxo" Received: from kunlun.suse.cz (unknown [IPv6:2a07:de40:b306:2000::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2A29A75BA2; Fri, 26 Jun 2026 05:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782453249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tHJX+/j6dKMpSwR1pPR5+WZRefWjtKKPN5BWHqL2m04=; b=RWaKDtRhFipsb/IW9aOHcqkFQyQZNjobycHlu6Rvb3y9cjJWoHkE8c491kuoJq8Piuulnl oYH53dz3rMY2CyyclHx10OXZJgs79L9kzn76loWbM2LiGlLDZuBNSCJucNzf6AlpgQYxN1 0Pmg0t/6baxU/FrCYl8w9EulMwPm77s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782453249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tHJX+/j6dKMpSwR1pPR5+WZRefWjtKKPN5BWHqL2m04=; b=cK7I7wxosCY2Int1G05vwrQsWbcLuiwSUyWXaXsPpLEeLrx8gNqu3OmNeZfvZdpK5WcS81 GZqOIWo4aLK0P0BA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RWaKDtRh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cK7I7wxo DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782453249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tHJX+/j6dKMpSwR1pPR5+WZRefWjtKKPN5BWHqL2m04=; b=RWaKDtRhFipsb/IW9aOHcqkFQyQZNjobycHlu6Rvb3y9cjJWoHkE8c491kuoJq8Piuulnl oYH53dz3rMY2CyyclHx10OXZJgs79L9kzn76loWbM2LiGlLDZuBNSCJucNzf6AlpgQYxN1 0Pmg0t/6baxU/FrCYl8w9EulMwPm77s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782453249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tHJX+/j6dKMpSwR1pPR5+WZRefWjtKKPN5BWHqL2m04=; b=cK7I7wxosCY2Int1G05vwrQsWbcLuiwSUyWXaXsPpLEeLrx8gNqu3OmNeZfvZdpK5WcS81 GZqOIWo4aLK0P0BA== Date: Fri, 26 Jun 2026 07:54:08 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: "Mukesh Kumar Chaurasiya (IBM)" Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, sshegde@linux.ibm.com, mkchauras@linux.ibm.com, kees@kernel.org, mark.rutland@arm.com, ryan.roberts@arm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/syscall: Fix seccomp errno handling with GENERIC_ENTRY Message-ID: References: <20260624171520.772408-1-mkchauras@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260624171520.772408-1-mkchauras@gmail.com> X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: ** X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [2.49 / 50.00]; BAYES_HAM(-3.00)[100.00%]; HFILTER_HOSTNAME_UNKNOWN(2.50)[]; RDNS_NONE(2.00)[]; ONCE_RECEIVED(1.20)[]; HFILTER_HELO_IP_A(1.00)[kunlun.suse.cz]; NEURAL_HAM_LONG(-1.00)[-1.000]; HFILTER_HELO_NORES_A_OR_MX(0.30)[kunlun.suse.cz]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FREEMAIL_CC(0.00)[linux.ibm.com,ellerman.id.au,gmail.com,kernel.org,arm.com,lists.ozlabs.org,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b306:2000::2:from]; MISSING_XM_UA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim] X-Spamd-Bar: ++ X-Rspamd-Queue-Id: 2A29A75BA2 X-Spam-Score: 2.49 Hello, On Wed, Jun 24, 2026 at 10:45:20PM +0530, Mukesh Kumar Chaurasiya (IBM) wrote: > After enabling GENERIC_ENTRY on PowerPC, seccomp filters using > SCMP_ACT_ERRNO without an explicit errnoRet value return ENOSYS > (Function not implemented) instead of the expected EPERM (Operation > not permitted). > > The issue occurs in system_call_exception() when syscall_enter_from_user_mode() > returns -1 to indicate the syscall should be skipped (e.g., blocked by seccomp). > The current code treats this -1 as a syscall number and compares it against > NR_syscalls. Since -1 (when cast to unsigned long) is greater than NR_syscalls, > the code incorrectly returns -ENOSYS, overwriting the errno that seccomp > already set via syscall_set_return_value(). > > The generic entry code in syscall_trace_enter() calls __secure_computing(), > which sets the appropriate errno in regs->gpr[3] and returns -1 to signal > that the syscall should be skipped. However, the PowerPC syscall handler > was not checking for this -1 return value before validating the syscall > number. > > Fix this by explicitly checking if syscall_enter_from_user_mode() returns > -1 and returning the value already set in regs->gpr[3] (the errno from > seccomp) before performing the syscall number validation. > > This aligns PowerPC's behavior with other architectures using GENERIC_ENTRY > and restores correct seccomp errno handling. > > Fixes: bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature") > Reported-by: Michal Suchánek > Signed-off-by: Mukesh Kumar Chaurasiya (IBM) > --- > arch/powerpc/kernel/syscall.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/powerpc/kernel/syscall.c b/arch/powerpc/kernel/syscall.c > index a9da2af6efa8..5b58c8d396c8 100644 > --- a/arch/powerpc/kernel/syscall.c > +++ b/arch/powerpc/kernel/syscall.c > @@ -22,6 +22,10 @@ notrace long system_call_exception(struct pt_regs *regs, unsigned long r0) > add_random_kstack_offset(); > r0 = syscall_enter_from_user_mode(regs, r0); > > + /* Seccomp or ptrace may have set return value, skip syscall */ > + if (unlikely(r0 == -1L)) > + return regs->gpr[3]; this should use syscall_get_error instead of accessing the register value directly. The error is represented differently in the scv and non-scv case, and for non-scv case this will return wrong value. Thanks Michal > + > if (unlikely(r0 >= NR_syscalls)) { > if (unlikely(trap_is_unsupported_scv(regs))) { > /* Unsupported scv vector */ > -- > 2.54.0 >