mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Svyatoslav Ryhel" <clamor95@gmail.com>,
	"David Heidelberg" <david@ixit.cz>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries
Date: Fri, 26 Jun 2026 15:26:06 +0300	[thread overview]
Message-ID: <aj5v3rDRlY7H39Tq@ashevche-desk.local> (raw)
In-Reply-To: <20260625-fix-al3xxx-kconfig-v2-0-796cf8d7cc49@gmail.com>

On Thu, Jun 25, 2026 at 09:38:07PM +0200, Joshua Crofts wrote:
> This series adds REGMAP_I2C support to three AL3xxx ambient light
> sensors that were previously missing this dependency, causing build
> failures.
> 
> To reproduce the build failure, run `make allnoconfig` and `make menuconfig`
> in which you select IIO, I2C and any AL3xxx sensor and `make .` will
> fail with errors such as:
> 
> drivers/iio/light/al3010.c: In function ‘al3010_probe’:
> drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
>   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>       |                        ^~~~~~~~~~~~~~~~~~~~
> drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>       |                      ^
> drivers/iio/light/al3010.c: At top level:
> drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
>    48 | static const struct regmap_config al3010_regmap_config = {
>       |                                   ^~~~~~~~~~~~~~~~~~~~

Now all is better. The only thing is missing is Cc: stable@ line.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

> I made a separate commit for each driver, to ensure a proper Fixes:
> tag is appended for easy backporting. Let me know if you prefer
> squashing!

I prefer per-driver patches, but let Jonathan to handle that.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-06-26 12:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25 19:38 Joshua Crofts
2026-06-25 19:38 ` [PATCH v2 1/3] iio: light: al3000a: add missing REGMAP_I2C to Kconfig Joshua Crofts
2026-06-25 19:38 ` [PATCH v2 2/3] iio: light: al3010: " Joshua Crofts
2026-06-25 19:38 ` [PATCH v2 3/3] iio: light: al3320a: " Joshua Crofts
2026-06-25 19:50 ` [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries David Heidelberg
2026-06-26 12:26 ` Andy Shevchenko [this message]
2026-06-26 12:38   ` Joshua Crofts
2026-06-26 13:57   ` Nuno Sá
2026-06-26 14:13     ` Andy Shevchenko
2026-06-26 14:28     ` Joshua Crofts
2026-07-01  1:09       ` Jonathan Cameron
2026-07-01  1:11 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aj5v3rDRlY7H39Tq@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=clamor95@gmail.com \
    --cc=david@ixit.cz \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®