From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66DFF2EB5B8 for ; Mon, 15 Jun 2026 18:11:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781547063; cv=none; b=Tw8oa0/mI39reZoq/6GbnL0TnVVFVC4HwFpE7EtDfwM4lQtlX0UxqOSHiBArD7h4NZ/45f/P5n5QqWlSB1lU8r/ssER3YiChFhL3jqMX4y1JZnY0TWiL6GXVt5saOuiy2pY48MHNiEy1ydey1gAuL3vu96uB8pasNMAf/Yzx0dk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781547063; c=relaxed/simple; bh=EOIIsL+l58MSUfx2dp+rAZlL+BVuojndnAZd5IL62Ug=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cK3CWWn82qcu3/ceEHF6TOAE8/FS/VlpbxHaq5v7aWfQKEYrOVJdRm9AkS4Ti4vsHkrSxNjU4H6dUVOda0MLyeF3KGPAh19uGwpYEp3CEowI9sXD09E5dVL7M+x1Kl4p+y21SheYJWXHIAmX8W7k6X/2qiIUKX99WTMQ6BZESwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wbinvd.org; spf=pass smtp.mailfrom=wbinvd.org; dkim=pass (2048-bit key) header.d=wbinvd.org header.i=@wbinvd.org header.b=K3vEDNVZ; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wbinvd.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wbinvd.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wbinvd.org header.i=@wbinvd.org header.b="K3vEDNVZ" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-13817614cd3so7787416c88.0 for ; Mon, 15 Jun 2026 11:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wbinvd.org; s=wbinvd; t=1781547061; x=1782151861; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=T/nPfUvDQznXq33ySNfhzOyn7370rIWy4aAB79eoT1k=; b=K3vEDNVZxJB2zsgr7cOQT4vlqBBaoZMCADuqdrmNjMjkZJ7DxGn+ChKnNcAL5pMMq6 AYeyaJhyBBdgO7Ai2sZr1MA1vbIKPh2aULGo8FE2DPx+hUxfsbPOyR/aEg5QxMliqv26 JK4Co9taDuDYSeUL0YvN+NKfA7k6JooPOb1jiyIxiM6cqGNcCSEmLwfWqdUvpVnTTdIP 9qfDrH1LZtuUGKqzSPcwI/g16o9EOb9ql6WtfW4GdbguTbsRvB3GBjdcjIb1Fmiwbt7U 4aSe2HlwUVbwR+3KD+esAznEQD4QzikzXSRvSy7nWIEz3AMZ+fdW1vRI2tcgjUpn2g8Z I4Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781547061; x=1782151861; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T/nPfUvDQznXq33ySNfhzOyn7370rIWy4aAB79eoT1k=; b=BaXDRmDrfn1B4go+95cgy0ZhH8OYFXmYpAGwEciXm7e9l0xu2zJy/yD3fKLPw7VMqB NqMOkou8EwZrEtaIGpmYbUP1I4OPdLEAjARy1lPhDxxc9E/229rA5oOxa0sivmuXkZU6 V07MMOPgSgt9I4AlkHQ/DpJCo8In0esCnFuKya4b/GlovYsrwxYTNTmtdDqH4kToJZat R/TtpdfRmbcv+RhusfNWK/N7DPGF9eHIEfzO3FqqJ4ZMHkdv7jld1yElGKW8OS6momVL 3wd8yHiz18xFPEINjb8rTdBgN7AHuaPNO/4HLQPw5tnuKyWVpa4g6ogeJ/qpwPIIPrXi 7KPQ== X-Gm-Message-State: AOJu0YwWVw+xgn9hVSpOw0vNNcdMwOLmV11w+afBlON9BuAsMK2Sc3qe VYpqXTDF7HZ3vqePU1vxrpqZTygHinn1+hHZc0eOB/9DsnpYAAvDJukItxQk469iprYBr1OCFbL L83IG X-Gm-Gg: Acq92OFMyMfKYD1Cummfae0l/E63Re1TCmTGDUfpHPIUsT/pw1hj9UIE9HKRNwE/Nti K6I62Xo4QDGNPh1ERJWndTz8IgyuksI1TLaejtPq8/JKFDD2aoFjVO2gUa76PgYcPK+3AjYDoBw ZNnlsFV4vmccO3RSMAiG9/PAB/4Pc2Ip+peT/vwKACFVVNxjqxYvT9lBV8LsHyOFU91KWz4c0cr K8YNTjT0L+Hf/aAeYd9wn6/QA7uu2oMbHhvbrt9J43G1kBaaw8JspfctSNNsN7gL89WfwYBuTQX 8AwitQjP+gbgFDw7wdWoYSglJQXmIUN0yyFKB1y70el2XjhTCWFr7SZllOReNUbRFwqgVMky+Rr NkrSfMKWw6D8JAV5v6RXmPisg5PdRS8mTW7TJjFgQ1mtqEbxV/tEkqn1dkiT9tsRo0solP1yk2/ J7KZ97b3pM5Mist1bkLpHiYn1HzA== X-Received: by 2002:a05:7301:5f81:b0:2df:7fe3:96a with SMTP id 5a478bee46e88-3092dce2af1mr6372831eec.0.1781547061404; Mon, 15 Jun 2026 11:11:01 -0700 (PDT) Received: from mozart.vkv.me ([2001:5a8:468b:d015:4587:288f:cffc:4ef7]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ba6b7f840sm141089eec.19.2026.06.15.11.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 11:11:01 -0700 (PDT) Date: Mon, 15 Jun 2026 11:10:58 -0700 From: Calvin Owens To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Roman Gushchin , David Rientjes , Christoph Lameter , Hao Li , Andrew Morton , Harry Yoo , Vlastimil Babka Subject: Re: [PATCH next-20260615] mm/slab: Fix build error due to extra argument Message-ID: References: <8a5c513e810a216ca221bbec94c96ffbf65da4be.1781540225.git.calvin@wbinvd.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Monday 06/15 at 10:12 -0700, Calvin Owens wrote: > On Monday 06/15 at 09:32 -0700, Calvin Owens wrote: > > mm/slub.c:5553:30: error: too many arguments to function call, expected 5, have 6 > > 5552 | return __do_kmalloc_node(size, NULL, flags, node, > > | ~~~~~~~~~~~~~~~~~ > > > > Fix by removing the nonexistent size argument. > > > > Closes: https://lore.kernel.org/all/178153914528.15282.16770125845520023465@330cfa3079ca/ > > Signed-off-by: Calvin Owens > > --- > > I needed to test -next this morning, so passing this along, but please > > don't go to any extra trouble to use it or credit me if you already > > fixed it :) > > Ugh, nevermind, a different kconfig now fails the opposite way: > > mm/slub.c:5551:24: error: too few arguments to function ‘__do_kmalloc_node’; expected 6, have 5 > 5551 | return __do_kmalloc_node(NULL, flags, node, > > > mm/slub.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) I guess the line number should have been a clue... I was building on different machines that fetched at different times, and there were actually two different SHAs for next-20260615 this morning: 700f8f17ac2c Author: Mark Brown Date: Mon Jun 15 15:43:39 2026 +0100 (3 hours ago) Commit: Mark Brown Date: Mon Jun 15 15:43:39 2026 +0100 (3 hours ago) Subject: Add linux-next specific files for 20260615 8d6dbbbe3ba6 Author: Mark Brown Date: Mon Jun 15 17:26:20 2026 +0100 (2 hours ago) Commit: Mark Brown Date: Mon Jun 15 17:26:20 2026 +0100 (2 hours ago) Subject: Add linux-next specific files for 20260615 My patch was for the first one. But the second one has a fix for this applied, so just drop this patch :) > > diff --git a/mm/slub.c b/mm/slub.c > > index b1de95046b0b..7660f7fa0b2c 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -5549,7 +5549,7 @@ void *__kmalloc_flags_noprof(DECL_TOKEN_PARAMS(size, token), gfp_t flags, > > }; > > > > if (alloc_flags_allow_spinning(alloc_flags)) { > > - return __do_kmalloc_node(size, NULL, flags, node, > > + return __do_kmalloc_node(NULL, flags, node, > > PASS_TOKEN_PARAM(token), &ac); > > } else { > > return __kmalloc_nolock_noprof(PASS_TOKEN_PARAMS(size, token), > > -- > > 2.53.0 > >