From: Christoph Hellwig <hch@infradead.org>
To: Aditya Srivastava <aditya.ansh182@gmail.com>
Cc: Carlos Maiolino <cem@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] xfs: prevent close() from hanging on frozen filesystems
Date: Mon, 15 Jun 2026 22:22:21 -0700 [thread overview]
Message-ID: <ajDdjR-Y4xwvZ3J4@infradead.org> (raw)
In-Reply-To: <20260616033821.2238-3-aditya.ansh182@gmail.com>
On Tue, Jun 16, 2026 at 03:38:20AM +0000, Aditya Srivastava wrote:
> Also, rename the flags parameter in xfs_free_eofblocks() to trans_flags as
> suggested to make its usage stand out, and update existing callers to
> pass 0 to preserve standard blocking paths.
It is only renamed compared to the previous patches, because this
patch actually adds it.
> - error = xfs_trans_alloc(mp, &M_RES(mp)->tr_itruncate, 0, 0, 0, &tp);
> + error = xfs_trans_alloc(mp, &M_RES(mp)->tr_itruncate, 0, 0, trans_flags, &tp);
Overly long line here.
Otherwise this looks good.
prev parent reply other threads:[~2026-06-16 5:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 3:38 [PATCH v4 0/2] xfs: resolve close() deadlocks " Aditya Srivastava
2026-06-16 3:38 ` [PATCH v4 1/2] xfs: add a XFS_TRANS_WRITECOUNT_TRYLOCK flag Aditya Srivastava
2026-06-16 5:20 ` Christoph Hellwig
2026-06-16 3:38 ` [PATCH v4 2/2] xfs: prevent close() from hanging on frozen filesystems Aditya Srivastava
2026-06-16 5:22 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajDdjR-Y4xwvZ3J4@infradead.org \
--to=hch@infradead.org \
--cc=aditya.ansh182@gmail.com \
--cc=cem@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®